Page MenuHomeFreeBSD

so_splice: Disallow splicing with KTLS-enabled sockets
ClosedPublic

Authored by markj on Apr 19 2025, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 4:24 PM
Unknown Object (File)
Thu, Jul 3, 4:03 PM
Unknown Object (File)
Wed, Jul 2, 1:29 PM
Unknown Object (File)
Wed, Jul 2, 2:47 AM
Unknown Object (File)
Tue, Jul 1, 5:40 PM
Unknown Object (File)
Tue, Jul 1, 9:18 AM
Unknown Object (File)
Tue, Jul 1, 6:36 AM
Unknown Object (File)
Mon, Jun 30, 6:21 PM
Subscribers

Details

Summary

Suppose the sink socket in a splice has KTLS enabled. When data is
transmitted from the source socket, sosend_generic_locked() receives an
mbuf rather than a UIO as it would if userspace were transferring data.
In this case, ktls_frame() expects the mbuf to be unmapped, but in
general this won't be the case.

Simply disallow the combination for now. Modify so_unsplice() to handle
dismantling a partially initialized splice, in order to simplify error
handling in so_splice(). Make sure that one can't enable KTLS on a
spliced socket, or more specifically, that one can't enable RXTLS on the
source side of a splice, or TXTLS on the sink side of a splice.

Reported by: syzbot+9cc248c4b0ca9b931ab4@syzkaller.appspotmail.com

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable