rc.subr: add 'settime' to svcj options
ClosedPublic
Actions

Authored by ivy on Tue, Apr 15, 6:01 PM.

Details

Reviewers

jamie
cy
kevans
des
ziaee

Group Reviewers

Jails
manpages

Commits

rG3a0eb293164e: rc.subr: add 'settime' to svcj options

Summary

<svc>_svcj_options="settime" enables the jail allow.settime privilege,
which allows to set and slew the system clock. this allows NTP daemons
to run in a service jail.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Tue, Apr 15, 6:01 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptTue, Apr 15, 6:01 PM

ivy requested review of this revision.Tue, Apr 15, 6:01 PM

Harbormaster completed remote builds in B63526: Diff 153698.Tue, Apr 15, 6:01 PM

ivy added a child revision: D49846: jail: allow jails to call settimeofday() if allow.settime is enabled.Tue, Apr 15, 6:01 PM

ivy removed a reviewer: network.Tue, Apr 15, 6:02 PM

ziaee added a reviewer: cy.Tue, Apr 15, 6:39 PM

The kernel side (PRIV) of this patch is missing (compared to to the github pull request).
The svcj part is OK.

In D49845#1136436, @netchild wrote:

The kernel side (PRIV) of this patch is missing (compared to to the github pull request).
The svcj part is OK.

because you can't put multiple commits in one Phabricator diff, i submitted the kernel patch as a parent diff: https://reviews.freebsd.org/D49846

ziaee added a reviewer: manpages.Tue, Apr 15, 7:52 PM

ziaee added inline comments.

share/man/man5/rc.conf.5
5013	Is it supposed to be skew?

ivy added inline comments.Tue, Apr 15, 8:13 PM

share/man/man5/rc.conf.5
5013	no, i intended to write 'slew' as this is the common NTP term for slowly adjusting a monotonic clock. but i don't mind changing it to "skew" if this is preferred (i feel like this is less accurate though).

ziaee added inline comments.Tue, Apr 15, 9:01 PM

share/man/man5/rc.conf.5
5013	In that case, maybe a Roff comment above this line explaining that for the next person who thinks it's a typo?

guest-patmaddox added a subscriber: guest-patmaddox.Tue, Apr 15, 9:12 PM

add a comment to descibe the word 'slew'.

Harbormaster completed remote builds in B63530: Diff 153707.Tue, Apr 15, 9:28 PM

ivy marked an inline comment as done.Tue, Apr 15, 9:29 PM

imp added inline comments.Tue, Apr 15, 10:37 PM

share/man/man5/rc.conf.5
5013	Slew means to adjust the phase error slowly over time while maintaining mobotonicity . It's a general time keeping term that NTP uses, but so does PTP and all the time keeping programs.

adding kevans, des (mentors) to review. i am ready to land this but would appreciate approval from (at least) jamie@ and ziaee@ first.

des accepted this revision.Sat, Apr 19, 10:15 AM

This revision is now accepted and ready to land.Sat, Apr 19, 10:15 AM

No opinion on slew vs skew, the rest looks good.

The slew vs skew was my ignorance about timekeeping. My suggestion to comment that slew is correct so people in the future won't think it's a typo was incorrect. Please excuse my mistake.