Page MenuHomeFreeBSD
Differential D46970

kinfo_vmentry: report posix shm and path
ClosedPublic
Actions

Authored by kib on Oct 7 2024, 8:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 24, 7:56 AM
Unknown Object (File)
Tue, Jul 22, 10:02 PM
Unknown Object (File)
Mon, Jul 14, 12:41 AM
Unknown Object (File)
Fri, Jul 4, 5:10 PM
Unknown Object (File)
Fri, Jul 4, 8:07 AM
Unknown Object (File)
Jun 23 2025, 10:24 AM
Unknown Object (File)
Jun 21 2025, 5:20 PM
Unknown Object (File)
Jun 17 2025, 9:57 AM
View All 43 Files
Subscribers
glebius
imp
olce

Details

Reviewers
markj
emaste
Commits
rGba40b2b89962: vmstat -o: report objects backing posix shm segments
rGa1258191d5e2: procstat vm: report posix shm segment mapping
rGb0b18b57a55b: sysctl vm.objects: report objects backing posix shm segments
rGa8c641bbcba7: sys/user.h: report posix shm mappings
rGbda73e441f25: posix shm: add shm_get_path(9)
rGa10870ecea81: posix shm: mark backing objects with SHM_POSIXSHM flag
rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Oct 7 2024, 8:32 AM
Herald added subscribers: olce, glebius, imp. · View Herald TranscriptOct 7 2024, 8:32 AM
kib requested review of this revision.Oct 7 2024, 8:32 AM
markj added inline comments.Oct 8 2024, 12:23 PM
sys/kern/uipc_shm.c
952

Why can't we use obj->handle rather than adding this new field? Looks like it is currently NULL for all POSIX shm objects.

2242

Extra newline.

kib marked 2 inline comments as done.Oct 8 2024, 12:30 PM
kib added inline comments.
sys/kern/uipc_shm.c
952

Phys pager assumes that the object with a handle is on list. Fighting with it is IMO not worth it, the new field is in union' free space.

kib marked an inline comment as done.Oct 8 2024, 12:32 PM
markj accepted this revision.Oct 8 2024, 12:36 PM
This revision is now accepted and ready to land.Oct 8 2024, 12:36 PM
Closed by commit rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope (authored by kib). · Explain WhyOct 8 2024, 12:39 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope.
kib added a commit: rGa10870ecea81: posix shm: mark backing objects with SHM_POSIXSHM flag.
kib added a commit: rGbda73e441f25: posix shm: add shm_get_path(9).
kib added a commit: rGa8c641bbcba7: sys/user.h: report posix shm mappings.
kib added a commit: rGb0b18b57a55b: sysctl vm.objects: report objects backing posix shm segments.
kib added a commit: rGa1258191d5e2: procstat vm: report posix shm segment mapping.
kib added a commit: rGba40b2b89962: vmstat -o: report objects backing posix shm segments.

Revision Contents
Changeset List

PathSize
sys/
kern/
12 lines
48 lines
sys/
1 line
2 lines
vm/
2 lines
10 lines
usr.bin/
procstat/
2 lines
vmstat/
2 lines

Diff 144369

View Options

sys/kern/kern_proc.c

Loading...
View Options

sys/kern/uipc_shm.c

Loading...
View Options

sys/sys/mman.h

Loading...
View Options

sys/sys/user.h

Loading...
View Options

sys/vm/vm_object.h

Loading...
View Options

sys/vm/vm_object.c

Loading...
View Options

usr.bin/procstat/procstat_vm.c

Loading...
View Options

usr.bin/vmstat/vmstat.c

Loading...