Paths

Table of Contentst

Differential D46970

kinfo_vmentry: report posix shm and path
ClosedPublic
Actions

Authored by kib on Oct 7 2024, 8:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 19, 1:52 AM

	Unknown Object (File)
	Nov 17 2024, 6:55 AM

	Unknown Object (File)
	Nov 3 2024, 9:33 AM

	Unknown Object (File)
	Oct 29 2024, 3:33 AM

	Unknown Object (File)
	Oct 26 2024, 3:27 PM

	Unknown Object (File)
	Oct 13 2024, 9:46 AM

	Unknown Object (File)
	Oct 9 2024, 1:46 PM

	Unknown Object (File)
	Oct 9 2024, 12:33 AM

View All 12 Files

Subscribers

Details

Reviewers

markj
emaste

Commits

rGba40b2b89962: vmstat -o: report objects backing posix shm segments
rGa1258191d5e2: procstat vm: report posix shm segment mapping
rGb0b18b57a55b: sysctl vm.objects: report objects backing posix shm segments
rGa8c641bbcba7: sys/user.h: report posix shm mappings
rGbda73e441f25: posix shm: add shm_get_path(9)
rGa10870ecea81: posix shm: mark backing objects with SHM_POSIXSHM flag
rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 7 2024, 8:32 AM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptOct 7 2024, 8:32 AM

kib requested review of this revision.Oct 7 2024, 8:32 AM

markj added inline comments.Oct 8 2024, 12:23 PM

sys/kern/uipc_shm.c
952 ↗	(On Diff #144369)	Why can't we use `obj->handle` rather than adding this new field? Looks like it is currently NULL for all POSIX shm objects.
2242 ↗	(On Diff #144369)	Extra newline.

kib marked 2 inline comments as done.Oct 8 2024, 12:30 PM

kib added inline comments.

sys/kern/uipc_shm.c
952 ↗	(On Diff #144369)	Phys pager assumes that the object with a handle is on list. Fighting with it is IMO not worth it, the new field is in union' free space.

kib marked an inline comment as done.Oct 8 2024, 12:32 PM

markj accepted this revision.Oct 8 2024, 12:36 PM

This revision is now accepted and ready to land.Oct 8 2024, 12:36 PM

Closed by commit rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope (authored by kib). · Explain WhyOct 8 2024, 12:39 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG71a66883b58f: kinfo_{vmobject,vmentry}: move copy of pathes into the vnode handling scope.

kib added a commit: rGa10870ecea81: posix shm: mark backing objects with SHM_POSIXSHM flag.

kib added a commit: rGbda73e441f25: posix shm: add shm_get_path(9).

kib added a commit: rGa8c641bbcba7: sys/user.h: report posix shm mappings.

kib added a commit: rGb0b18b57a55b: sysctl vm.objects: report objects backing posix shm segments.

kib added a commit: rGa1258191d5e2: procstat vm: report posix shm segment mapping.

kib added a commit: rGba40b2b89962: vmstat -o: report objects backing posix shm segments.

Revision Contents
Changeset List

Path

Size

sys/

kern/

7 lines

vm/

5 lines

Diff 144474

sys/kern/kern_proc.c

Loading...

sys/vm/vm_object.c

Loading...