Page MenuHomeFreeBSD

vmm: Use make_dev_s() to create vmm devices
ClosedPublic

Authored by markj on Aug 30 2024, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 10, 10:15 PM
Unknown Object (File)
Sat, Oct 10, 12:31 PM
Unknown Object (File)
Thu, Oct 8, 10:42 PM
Unknown Object (File)
Sat, Oct 3, 2:36 AM
Unknown Object (File)
Fri, Oct 2, 3:07 PM
Unknown Object (File)
Mon, Sep 28, 1:04 AM
Unknown Object (File)
Wed, Sep 23, 11:31 PM
Unknown Object (File)
Wed, Sep 23, 11:24 PM
Subscribers

Details

Summary

This avoids creating windows where a device file is accessible but the
device-specific field is not set.

Now that vmmdev_mtx is a sleepable lock, avoid dropping it while
creating devices files. This makes it easier to handle races and
simplifies some code; for example, the VSC_LINKED flag is no longer
needed.

Suggested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb added a subscriber: jhb.

Hmm, so nothing was checking for si_drv1 being NULL in the cdevsw methods? Oof.

This revision is now accepted and ready to land.Aug 30 2024, 3:41 PM

Yikes indeed! Nice catch. It likely was usually fine, but yikes!

This revision was automatically updated to reflect the committed changes.