Page MenuHomeFreeBSD

add virtiofs mount utility
Needs RevisionPublic

Authored by emil_etsalapatis.com on Aug 14 2024, 3:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 11:21 PM
Unknown Object (File)
Wed, Nov 20, 9:04 AM
Unknown Object (File)
Mon, Nov 18, 1:39 AM
Unknown Object (File)
Sat, Nov 16, 3:02 PM
Unknown Object (File)
Sat, Nov 16, 2:11 PM
Unknown Object (File)
Nov 5 2024, 10:54 AM
Unknown Object (File)
Oct 5 2024, 12:51 PM
Unknown Object (File)
Oct 3 2024, 2:46 PM

Details

Summary

Add a mount userspace utility specific to virtiofs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59023
Build 55910: arc lint + arc unit

Event Timeline

asomers requested changes to this revision.Aug 21 2024, 4:37 PM

Can you add a man page, too?

sbin/mount_virtiofs/mount_virtiofs.c
4–11

These copyright holders look copy/pasted. You should remove them.

This revision now requires changes to proceed.Aug 21 2024, 4:37 PM

Do we actually need the utility? mount.c says,

/* XXX: We need to get away from implementing external mount
 *      programs for every filesystem, and move towards having
 *	each filesystem properly implement the nmount() system call.
 */

And for tag-as-first-argument convenience (instead of specifying tag=) just take the tag as the "from"?

Can you add a man page, too?

Sounds good, I will add it in this diff if we keep the utility.

Do we actually need the utility? mount.c says,

/* XXX: We need to get away from implementing external mount
 *      programs for every filesystem, and move towards having
 *	each filesystem properly implement the nmount() system call.
 */

And for tag-as-first-argument convenience (instead of specifying tag=) just take the tag as the "from"?

That would be nice, I'll try out using the generic mount utility to see if we can make do without it. I made a new utility for virtiofs because I started off of the FUSE dedicated mount utility, but it turns out that virtiofs shares very little mount logic with FUSE.