bhyve: Assert success in a couple of libvmmapi calls
ClosedPublic
Actions

Authored by markj on Jul 31 2024, 3:19 PM.

Tags

None

Referenced Files

	F166005567: D46197.diff
	Mon, Aug 10, 11:25 PM

	F165919831: D46197.id141618.diff
	Mon, Aug 10, 1:08 PM

	Unknown Object (File)
	Sat, Aug 8, 6:11 AM

	Unknown Object (File)
	Wed, Aug 5, 8:12 AM

	Unknown Object (File)
	Wed, Aug 5, 3:19 AM

	Unknown Object (File)
	Tue, Aug 4, 7:17 AM

	Unknown Object (File)
	Thu, Jul 23, 7:15 AM

	Unknown Object (File)
	Mon, Jul 20, 12:17 PM

Subscribers

Details

Reviewers

jhb
andrew

Group Reviewers

bhyve

Commits

rG4c5188bbeb88: bhyve: Assert success in a couple of libvmmapi calls

Summary

In vmexit_smccc(), copy an assertion from amd64.
In fbsdrun_addcpu(), make sure that our vm_suspend_cpu() call is succesful.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jul 31 2024, 3:19 PM

Herald added a reviewer: andrew. · View Herald TranscriptJul 31 2024, 3:19 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

markj requested review of this revision.Jul 31 2024, 3:19 PM

markj added a parent revision: D46196: bhyve: Optionally put vCPUs back in the debug state after resuming.

Harbormaster completed remote builds in B58901: Diff 141596.Jul 31 2024, 3:20 PM

jhb accepted this revision.Jul 31 2024, 9:21 PM

This revision is now accepted and ready to land.Jul 31 2024, 9:21 PM

Closed by commit rG4c5188bbeb88: bhyve: Assert success in a couple of libvmmapi calls (authored by markj). · Explain WhyJul 31 2024, 11:45 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG4c5188bbeb88: bhyve: Assert success in a couple of libvmmapi calls.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

aarch64/

vmexit.c

3 lines

bhyverun.c

3 lines

Diff 141618

View Options

usr.sbin/bhyve/aarch64/vmexit.c