Page MenuHomeFreeBSD

pci: Only add special VF handling for direct children in bus methods
ClosedPublic

Authored by jhb on Jun 5 2024, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 9:38 AM
Unknown Object (File)
Wed, Oct 1, 1:35 AM
Unknown Object (File)
Sat, Sep 27, 1:08 AM
Unknown Object (File)
Sep 6 2025, 5:21 PM
Unknown Object (File)
Aug 12 2025, 1:44 PM
Unknown Object (File)
Aug 7 2025, 4:59 AM
Unknown Object (File)
Aug 2 2025, 9:26 AM
Unknown Object (File)
Jul 29 2025, 5:27 AM
Subscribers
None

Details

Summary

For activate/deactivate resource, use a more standard check at the
start of the function since the addition of the PCI_IOV code made this
more complex. For the three recently added methods, just add the
typical check at the beginning that I missed.

This wasn't always fatal as if your system only had PCI device_t's as
children of PCI bus devices it would happen to work ok, but if you
have a non-PCI child device (e.g. an ATA channel) then dereferencing
ivars for non-direct-children could fault.

Reported by: Cirrus-CI (via emaste)
Fixes: 871b33ad65ba pci: Consistently use pci_vf_* for suballocated VF memory resources

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable