Page MenuHomeFreeBSD

pci: Only add special VF handling for direct children in bus methods
ClosedPublic

Authored by jhb on Wed, Jun 5, 3:24 PM.
Tags
None
Referenced Files
F87367061: D45499.diff
Tue, Jul 2, 4:16 AM
F87318325: D45499.id139517.diff
Mon, Jul 1, 5:25 PM
Unknown Object (File)
Sun, Jun 30, 7:59 AM
Unknown Object (File)
Fri, Jun 28, 6:06 PM
Unknown Object (File)
Sat, Jun 8, 12:00 PM
Unknown Object (File)
Fri, Jun 7, 4:30 PM
Unknown Object (File)
Wed, Jun 5, 5:00 PM
Unknown Object (File)
Wed, Jun 5, 3:33 PM
Subscribers
None

Details

Summary

For activate/deactivate resource, use a more standard check at the
start of the function since the addition of the PCI_IOV code made this
more complex. For the three recently added methods, just add the
typical check at the beginning that I missed.

This wasn't always fatal as if your system only had PCI device_t's as
children of PCI bus devices it would happen to work ok, but if you
have a non-PCI child device (e.g. an ATA channel) then dereferencing
ivars for non-direct-children could fault.

Reported by: Cirrus-CI (via emaste)
Fixes: 871b33ad65ba pci: Consistently use pci_vf_* for suballocated VF memory resources

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable