Page MenuHomeFreeBSD

LinuxKPI: Move kstrto* functions to linux/kstrtox.h
ClosedPublic

Authored by wulf on Jun 2 2024, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 12:37 AM
Unknown Object (File)
Sat, Jun 8, 11:45 AM
Unknown Object (File)
Tue, Jun 4, 5:10 PM
Subscribers

Details

Summary

from linux/kernel.h to match Linux and
allow direct linux/kstrtox.h inclusion.

Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jun 2 2024, 3:43 PM

In general I am fine with the moves.

sys/compat/linuxkpi/common/include/linux/kstrtox.h
9

Likely to be a - not a ,

11
d2f312e0e7590   hps
    Sponsored by:           Mellanox Technologies
cbfc3c73cea62
    Sponsored by:   Mellanox Technologies
b382b78503b56   bz

8e52f22b25e20   manu
    Sponsored-by: The FreeBSD Foundation

f82cf28b317b6   bz
    Sponsored by:   The FreeBSD Foundation

61f7fe6b2d147   hps
    Submitted by:   ashafer_badland.io (Austin Shafer)
    Sponsored by:   Mellanox Technologies

c427456fd560d   wulf

35555d474b21e   hps
    Submitted by:   Johannes Lundberg <johalun0@gmail.com>
    Sponsored by:   Mellanox Technologies
    Sponsored by:   Limelight Networks

c840d5cec2607   bz

8e587a5f13ce6   manu
    Sponsored by:   Beckhoff Automation GmbH & Co. KG

f82cf28b317b6   bz
    Sponsored by:   The FreeBSD Foundation

Looking at D45455 I start to wonder why (likely historically and then kept style) we use Linux types here. Should we fix that in a follow-up?

Adjust years in The FreeBSD Foundation copyright

In D45454#1036731, @bz wrote:

Looking at D45455 I start to wonder why (likely historically and then kept style) we use Linux types here. Should we fix that in a follow-up?

Done. See D45465;

Adjust years in The FreeBSD Foundation copyright

I think there's still a line for just bz and no Foundation missing but I am fine with passing that to the Foundation independent of work done for them.

This revision is now accepted and ready to land.Mon, Jun 3, 9:05 PM