Page MenuHomeFreeBSD

FFclock: Man page and file header updates
AcceptedPublic

Authored by Darryl.Veitch_uts.edu.au on Dec 7 2023, 12:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 9, 6:33 AM
Unknown Object (File)
Oct 21 2025, 12:41 AM
Unknown Object (File)
Oct 21 2025, 12:41 AM
Unknown Object (File)
Oct 20 2025, 2:54 PM
Unknown Object (File)
Oct 14 2025, 3:03 AM
Unknown Object (File)
Oct 4 2025, 7:03 AM
Unknown Object (File)
Sep 26 2025, 7:02 PM
Unknown Object (File)
Sep 21 2025, 2:46 PM

Details

Reviewers
phk
imp
brooks
Group Reviewers
manpages
Summary

Manpages

ffclock.2, ffclock.4
Updated with respect to FFclock code revisions and terminology, in
particular the three FFclocks natFFC, monoFFC, and diffFFC.
Substantially modified descriptions to provide more detail and insight,
including reference to bpf changes documented in bpf.4 .
Authorship footnotes updated.

File headers

subr_rtc.c

FFclock authorship note removed as no FFclock code remains.

_ffcounter.h, timepps.c

FFclock authorship note amended to include Veitch.

kern_ffclock.c, kern_tc.c, timeff.c

FFclock authorship note amended to include Veitch, and extended to
cover FFclock code revisions.

bpf.c, bpf.h

Authorship note added, with reference to origins of work under the
2011 FreeBSD Foundation sponsorship for the FFclock code.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54838
Build 51727: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 20 2023, 6:30 PM

This will introduce a lot of linter errors into the manual. It's been a long time, so if (God forbid) OP has lost interest and doesn't reply back, I can clean it up and commit it.

lib/libc/sys/ffclock.2
35

This is not a sentence and should not begin with a capital letter or end with a period. Similarly, the need to break it onto a second line is a violation of the spec "one line about what it does" in mdoc(7).

I suggest "get and set native feedforward clock counter and parameters". If there are no objections, I can do this as my own commit after this is merged.

159

New sentence, new line

164

New sentence, new line.

203

This needs to be written as

.An Darryl Vietch Aq Mt darryl.veitch@uts.edu.au .

Because mdoc can be rendered many ways and there are applications that parse this.

share/man/man4/ffclock.4
52

New sentences need to start on a new line.