Page MenuHomeFreeBSD

lockf: add some tests
ClosedPublic

Authored by kevans on Nov 22 2023, 5:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 14, 2:26 PM
Unknown Object (File)
Mon, May 20, 10:49 AM
Unknown Object (File)
May 8 2024, 8:30 PM
Unknown Object (File)
Apr 28 2024, 8:38 AM
Unknown Object (File)
Apr 26 2024, 2:21 AM
Unknown Object (File)
Apr 14 2024, 5:34 PM
Unknown Object (File)
Apr 12 2024, 9:01 AM
Unknown Object (File)
Apr 9 2024, 3:10 AM

Details

Reviewers
allanjude
Group Reviewers
Klara
Commits
rG296a5a4db1fc: lockf: add some tests
Summary

Provide basic coverage for the existing options, nothing deeper (e.g.,
pipe closing behavior) is tested in this set.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54564
Build 51453: arc lint + arc unit

Event Timeline

Stop waiting on some of the sleeps, improve reliability

0mp added inline comments.
usr.bin/lockf/tests/lockf_test.sh
94

What's the reason for that? Why is failing under 10 seconds considered a success?

allanjude added a subscriber: allanjude.

reviewed-by: allanjude

usr.bin/lockf/tests/lockf_test.sh
94

the -n flag means: exit immediately if testlock does not already exist

This revision is now accepted and ready to land.Nov 22 2023, 1:49 PM
des added inline comments.
usr.bin/lockf/tests/lockf_test.sh
37

style(9) no longer requires a blank line at the top of a function

This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.