Page MenuHomeFreeBSD
Differential D42714

lockf: add some tests
ClosedPublic
Actions

Authored by kevans on Nov 22 2023, 5:12 AM.
Tags
None
Referenced Files
F86556439: D42714.id.diff
Sat, Jun 22, 3:33 AM
Unknown Object (File)
Sun, Jun 16, 6:49 AM
Unknown Object (File)
Fri, Jun 14, 2:26 PM
Unknown Object (File)
May 20 2024, 10:49 AM
Unknown Object (File)
May 8 2024, 8:30 PM
Unknown Object (File)
Apr 28 2024, 8:38 AM
Unknown Object (File)
Apr 26 2024, 2:21 AM
Unknown Object (File)
Apr 14 2024, 5:34 PM
View All 31 Files
Subscribers
0mp
allanjude
des
imp

Details

Reviewers
allanjude
Group Reviewers
Klara
Commits
rG296a5a4db1fc: lockf: add some tests
Summary

Provide basic coverage for the existing options, nothing deeper (e.g.,
pipe closing behavior) is tested in this set.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54564
Build 51453: arc lint + arc unit

Event Timeline

kevans created this revision.Nov 22 2023, 5:12 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 22 2023, 5:12 AM
kevans requested review of this revision.Nov 22 2023, 5:12 AM
Harbormaster completed remote builds in B54562: Diff 130418.Nov 22 2023, 5:12 AM
kevans added a parent revision: D42713: lockf: don't hold stdin/stdout/stderr open.Nov 22 2023, 5:12 AM
kevans updated this revision to Diff 130420.Nov 22 2023, 7:02 AM

Stop waiting on some of the sleeps, improve reliability

Harbormaster completed remote builds in B54564: Diff 130420.Nov 22 2023, 7:02 AM
kevans added a child revision: D42718: lockf: allow locking file descriptors.Nov 22 2023, 8:02 AM
0mp added a subscriber: 0mp.Nov 22 2023, 9:39 AM
0mp added inline comments.
usr.bin/lockf/tests/lockf_test.sh
94

What's the reason for that? Why is failing under 10 seconds considered a success?

allanjude accepted this revision.Nov 22 2023, 1:49 PM
allanjude added a subscriber: allanjude.

reviewed-by: allanjude

usr.bin/lockf/tests/lockf_test.sh
94

the -n flag means: exit immediately if testlock does not already exist

This revision is now accepted and ready to land.Nov 22 2023, 1:49 PM
des added a subscriber: des.Nov 22 2023, 3:12 PM
des added inline comments.
usr.bin/lockf/tests/lockf_test.sh
37

style(9) no longer requires a blank line at the top of a function

Closed by commit rG296a5a4db1fc: lockf: add some tests (authored by kevans). · Explain WhyNov 26 2023, 4:13 AM
This revision was automatically updated to reflect the committed changes.
kevans marked an inline comment as done.
kevans added a commit: rG296a5a4db1fc: lockf: add some tests.

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
usr.bin/
lockf/
5 lines
tests/
6 lines
154 lines

Diff 130420

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/lockf/Makefile

Loading...
View Options

usr.bin/lockf/tests/Makefile

Loading...
View Options

usr.bin/lockf/tests/lockf_test.sh

Loading...