HomeFreeBSD

lockf: don't hold stdin/stdout/stderr open

Description

lockf: don't hold stdin/stdout/stderr open

None of these are essential in the lockf monitor (parent post-fork), so
close them to maintain the illusion that lockf hasn't been inserted into
the pipeline. This ensures that the correct effects happen on other
programs in the pipeline if the locked command closes or redirects these
elsewhere.

The original patch used -s to close stdout/stderr rather than closing
them unconditionally, but it's not clear that we really care that much.
kevans dropped that part when taking the patch, patch is otherwise by
listed author.

PR: 112379
Reviewed by: 0mp, allanjude (both earlier version), kevans
Feedback from: des
Sponsored by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D42713

Details

Provenance
Alexander Melkov <melkov@comptek.ru>Authored on Nov 22 2023, 4:46 AM
kevansCommitted on Nov 26 2023, 4:09 AM
Reviewer
0mp
Differential Revision
D42713: lockf: don't hold stdin/stdout/stderr open
Parents
rG35095fd23f07: lockf: correct omission in the usage statement
Branches
Unknown
Tags
Unknown