Differential D42689

bhyve: Split backends into separate files
ClosedPublic
Actions

Authored by markj on Nov 20 2023, 11:07 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 6:49 PM

	Unknown Object (File)
	Apr 12 2024, 4:54 AM

	Unknown Object (File)
	Apr 6 2024, 11:54 AM

	Unknown Object (File)
	Feb 5 2024, 10:36 AM

	Unknown Object (File)
	Jan 12 2024, 11:01 AM

	Unknown Object (File)
	Jan 5 2024, 7:04 PM

	Unknown Object (File)
	Dec 30 2023, 11:59 AM

	Unknown Object (File)
	Dec 30 2023, 11:59 AM

View All 16 Files

Subscribers

Details

Reviewers

jhb
corvink
vmaffione

Group Reviewers

Commits

rG40993deee7d6: bhyve: Split backends into separate files
rGbe74aede49fb: bhyve: Split backends into separate files

Summary

Currently the net_backend structure definition is private to
net_backends.c, so all of the backend definitions are there. While
adding a new backend to use libslirp, it was noted that this file is
somewhat cluttered. Move the netmap and netgraph backends to their own
files and clean up includes a bit. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54529
Build 51418: arc lint + arc unit

Event Timeline

markj created this revision.Nov 20 2023, 11:07 PM

Herald added a reviewer: bhyve. · View Herald TranscriptNov 20 2023, 11:07 PM

Herald added subscribers: bcran, jonathan, rgrimes, imp. · View Herald Transcript

markj requested review of this revision.Nov 20 2023, 11:07 PM

Harbormaster completed remote builds in B54529: Diff 130357.Nov 20 2023, 11:07 PM

markj mentioned this in D42510: bhyve: Add a slirp network backend.Nov 20 2023, 11:08 PM

corvink accepted this revision.Nov 21 2023, 7:28 AM

This revision is now accepted and ready to land.Nov 21 2023, 7:28 AM

jhb accepted this revision.Nov 22 2023, 5:56 PM

jhb added inline comments.

usr.sbin/bhyve/net_backends.h
98	Should this be in net_backends_priv.h instead?

markj added inline comments.Nov 22 2023, 5:58 PM

usr.sbin/bhyve/net_backends.h
98	Yes, will fix before commit.

Closed by commit rGbe74aede49fb: bhyve: Split backends into separate files (authored by markj). · Explain WhyNov 22 2023, 8:20 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbe74aede49fb: bhyve: Split backends into separate files.

Ok

markj added a commit: rG40993deee7d6: bhyve: Split backends into separate files.Dec 14 2023, 2:43 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

5 lines

net_backend_netgraph.c

191 lines

net_backend_netmap.c

384 lines

8 lines

661 lines

net_backends_priv.h

150 lines

Diff 130357

usr.sbin/bhyve/Makefile

Loading...

usr.sbin/bhyve/net_backend_netgraph.c

Loading...

usr.sbin/bhyve/net_backend_netmap.c

Loading...

usr.sbin/bhyve/net_backends.h

Loading...

usr.sbin/bhyve/net_backends.c

Loading...

usr.sbin/bhyve/net_backends_priv.h

Loading...