Page MenuHomeFreeBSD

cr_canseeotheruids(), cr_canseeothergids(): Man pages: Impacts of rename
ClosedPublic

Authored by olce on Jun 20 2023, 1:44 PM.
Tags
None
Referenced Files
F86122058: D40630.diff
Sat, Jun 15, 6:58 PM
Unknown Object (File)
Thu, Jun 13, 12:37 PM
Unknown Object (File)
Thu, Jun 13, 12:34 PM
Unknown Object (File)
Mon, Jun 10, 1:35 PM
Unknown Object (File)
Thu, Jun 6, 2:29 PM
Unknown Object (File)
May 16 2024, 1:54 AM
Unknown Object (File)
May 12 2024, 8:00 PM
Unknown Object (File)
May 5 2024, 2:49 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52677
Build 49568: arc lint + arc unit

Event Timeline

olce requested review of this revision.Jun 20 2023, 1:44 PM
zlei requested changes to this revision.Jul 2 2023, 7:21 AM
zlei added a subscriber: zlei.

Unless D40629 is approved.

This revision now requires changes to proceed.Jul 2 2023, 7:21 AM
olce requested review of this revision.Jul 10 2023, 12:45 PM

Update context lines after update of D40626.

mhorne requested changes to this revision.Jul 18 2023, 4:19 PM
mhorne added a subscriber: mhorne.

I do agree that the "can" part of the name is confusing. To me, it implies a boolean return value, but in actuality a return value of zero means "yes you can".

However, many functions in kern_prot.c follow this cr_can*() or p_can*() naming convention. At this point I think it is better to keep these functions consistent with the others, and update the names of the man pages.

This revision now requires changes to proceed.Jul 18 2023, 4:19 PM

However, many functions in kern_prot.c follow this cr_can*() or p_can*() naming convention. At this point I think it is better to keep these functions consistent with the others, and update the names of the man pages.

Yes. But I thought I would rename these despite that since they are now internal functions, in order to reserve the cr_can and p_can prefixes for functions that can actually be called from outside. But I don't mind changing the man pages instead.

olce retitled this revision from Rename (back) cr_cansee*() internal helpers to cr_canseeotheruids(), cr_canseeothergids(): Man pages: Impacts of rename.
olce edited the summary of this revision. (Show Details)

Rename man pages and fix references instead of renaming the functions.

What you have looks good. The only thing you are missing is to add the old names to ObsoleteFiles.inc. This ensures the old files will be cleaned up with make delete-old.

olce edited the summary of this revision. (Show Details)

Add old man pages to ObsoleteFiles.inc.

This revision is now accepted and ready to land.Aug 7 2023, 8:03 PM
This revision now requires review to proceed.Aug 10 2023, 3:14 PM

Revalidate after rebase.

This revision is now accepted and ready to land.Aug 10 2023, 3:15 PM