Sponsored by: Klara, Inc.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| usr.bin/tftp/tests/Makefile | ||
|---|---|---|
| 7 | But in this case, they _are_ trying to bind to the same ports, right? | |
| usr.bin/tftp/tests/tftp_test.sh | ||
| 8 | Kyua runs each test case in its own temporary directory, and automatically cleans it up when done. So you should put all of these temporary files in PWD instead of TMPDIR. | |
| 13 | Annoying. Can you think of any other way to close the race? Would it be worthwhile to write a "mini-inetd" just for this test suite, which knows only how to invoke tftpd? That could fix the exclusivity problem too, by using a different port for each test case. | |
| usr.bin/tftp/tests/Makefile | ||
|---|---|---|
| 7 | As each other, sure, but ATF does not run them concurrently. | |
| usr.bin/tftp/tests/tftp_test.sh | ||
| 8 | Kyua sets TMPDIR correctly, so this is a non-issue. | |
| 13 | No, and it's really not an issue. The check is intended to catch the case where someone tries to run the test manually and already have tftpd enabled for some reason. We can't use a different port for each test case because the client doesn't fully support alternate ports. | |
| usr.bin/tftp/tests/Makefile | ||
|---|---|---|
| 7 | atf executes an individual test, it does not do orschestration of multiple tests. People do regularly run parallelized kyua runs (see kyua.conf(5), parallelism), so this is needed. | |
| usr.bin/tftp/tests/tftp_test.sh | ||
|---|---|---|
| 101 | You should skip if IPv6 is unsupported. See tests/etc/rc.d/routing_test.sh for an example. Also, in tftp_put_ipv6_body . | |