Page MenuHomeFreeBSD
Differential D38958

tftp: Correctly propagate transfer errors.
ClosedPublic
Actions

Authored by des on Mar 7 2023, 7:48 PM.
Tags
None
Referenced Files
F157478514: D38958.id118488.diff
Thu, May 21, 9:52 PM
F157438411: D38958.id.diff
Thu, May 21, 11:46 AM
Unknown Object (File)
Mon, May 18, 4:28 AM
Unknown Object (File)
Sun, May 17, 12:33 PM
Unknown Object (File)
Sun, May 17, 8:30 AM
Unknown Object (File)
Mon, Apr 27, 11:21 PM
Unknown Object (File)
Apr 13 2026, 9:29 PM
Unknown Object (File)
Apr 13 2026, 12:56 AM
View All Files
Subscribers
markj

Details

Reviewers
imp
jhb
markj
Group Reviewers
Klara
Commits
rG92570f67c791: tftp: Correctly propagate transfer errors.
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 7 2023, 7:48 PM
des created this revision.
Harbormaster completed remote builds in B50206: Diff 118488.Mar 7 2023, 7:48 PM
des added a parent revision: D38957: tftpd: Make the transfer functions return success / failure..Mar 7 2023, 7:49 PM
des added a child revision: D38965: tftpd: Make the -d option behave as documented..Mar 7 2023, 11:10 PM
markj added a subscriber: markj.Mar 8 2023, 3:09 PM
markj added inline comments.
usr.bin/tftp/tftp.c
105

Or just add a return value to this function and use that to signal an error? Then txrx_error can be private to main.c.

des mentioned this in D38957: tftpd: Make the transfer functions return success / failure..Mar 8 2023, 4:58 PM
des retitled this revision from tftp: Set txrx_error if and only if an error occurred. to tftp: Correctly propagate transfer errors..Mar 8 2023, 6:10 PM
des updated this revision to Diff 118540.Mar 8 2023, 6:11 PM

Reduce use of global error flag.

Harbormaster completed remote builds in B50234: Diff 118540.Mar 8 2023, 6:12 PM
des marked an inline comment as done.Mar 8 2023, 6:15 PM
markj accepted this revision as: markj.Mar 8 2023, 6:27 PM
markj added inline comments.
usr.bin/tftp/main.c
504–505
This revision is now accepted and ready to land.Mar 8 2023, 6:27 PM
Closed by commit rG92570f67c791: tftp: Correctly propagate transfer errors. (authored by des). · Explain WhyMar 10 2023, 1:29 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG92570f67c791: tftp: Correctly propagate transfer errors..

Revision Contents
Changeset List

PathSize
usr.bin/
tftp/
14 lines
5 lines
44 lines

Diff 118618

View Options

usr.bin/tftp/main.c

Loading...
View Options

usr.bin/tftp/tftp.h

Loading...
View Options

usr.bin/tftp/tftp.c

Loading...