tftpd: Don't forget to close stderr on startup.
ClosedPublic
Actions

Authored by des on Mar 7 2023, 11:04 PM.

Tags

None

Referenced Files

	F138575098: D38968.id118622.diff
	Wed, Dec 3, 6:50 AM

	Unknown Object (File)
	Mon, Dec 1, 7:56 AM

	Unknown Object (File)
	Thu, Nov 6, 6:42 AM

	Unknown Object (File)
	Tue, Nov 4, 12:42 PM

	Unknown Object (File)
	Tue, Nov 4, 12:36 PM

	Unknown Object (File)
	Tue, Nov 4, 12:33 PM

	Unknown Object (File)
	Tue, Nov 4, 12:30 PM

	Unknown Object (File)
	Tue, Nov 4, 4:12 AM

View All 86 Files

Subscribers

None

Details

Reviewers

imp
jhb
markj

Group Reviewers

Klara

Commits

rG77e83935b7ef: tftpd: Don't forget to close stderr on startup.

Summary

Just like stdin and stdout, stderr is a copy of the listen socket inherited from inetd. We need to close it so inetd can process further requests, be restarted, etc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 7 2023, 11:04 PM

des created this revision.

Harbormaster completed remote builds in B50215: Diff 118504.Mar 7 2023, 11:04 PM

des added a parent revision: D38967: tftpd: Don't consume arbitrary requests when failing to fork..Mar 7 2023, 11:04 PM

des added a child revision: D38969: tftp: Add tests..Mar 7 2023, 11:10 PM

markj accepted this revision as: markj.Mar 8 2023, 2:51 PM

This revision is now accepted and ready to land.Mar 8 2023, 2:51 PM

Closed by commit rG77e83935b7ef: tftpd: Don't forget to close stderr on startup. (authored by des). · Explain WhyMar 10 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG77e83935b7ef: tftpd: Don't forget to close stderr on startup..

Revision Contents
Changeset List

Path

Size

libexec/

tftpd/

tftpd.c

5 lines

Diff 118622

View Options

tftpd: Don't forget to close stderr on startup.ClosedPublicActions