Page MenuHomeFreeBSD

tftpd: Make the -d option behave as documented.
ClosedPublic

Authored by des on Mar 7 2023, 11:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 15 2024, 7:24 AM
Unknown Object (File)
Mar 15 2024, 7:24 AM
Unknown Object (File)
Mar 11 2024, 12:32 PM
Unknown Object (File)
Mar 8 2024, 12:47 AM
Unknown Object (File)
Jan 3 2024, 11:38 PM
Unknown Object (File)
Jan 3 2024, 11:11 PM
Unknown Object (File)
Dec 23 2023, 9:36 AM
Unknown Object (File)
Jul 12 2023, 7:08 AM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 7 2023, 11:03 PM
des created this revision.
markj added a subscriber: markj.
markj added inline comments.
libexec/tftpd/tftpd.c
157

According to the documentation, these += and |= should be simple assignments. Maybe the documentation should be updated instead.

This revision is now accepted and ready to land.Mar 8 2023, 3:05 PM
libexec/tftpd/tftpd.c
157

I don't agree with that interpretation, at best I'd say it's vague on that point. This is the behavior that makes sense to me and debug_finds() gives me a headache so I'd rather leave well enough alone.

des marked an inline comment as done.Mar 8 2023, 6:04 PM
This revision was automatically updated to reflect the committed changes.