Page MenuHomeFreeBSD

tcp: retire net.inet.tcp.tcp_require_unique_port
ClosedPublic

Authored by glebius on Feb 2 2023, 8:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 12:24 AM
Unknown Object (File)
Dec 20 2023, 12:16 PM
Unknown Object (File)
Dec 20 2023, 7:21 AM
Unknown Object (File)
Nov 22 2023, 4:02 PM
Unknown Object (File)
Nov 18 2023, 9:48 PM
Unknown Object (File)
Nov 18 2023, 4:49 PM
Unknown Object (File)
Nov 18 2023, 10:45 AM
Unknown Object (File)
Nov 18 2023, 10:27 AM

Details

Summary

It was a safe belt just in case if the new port allocation
behaviour introduced in 25102351509 would cause a problem.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcp.4 references this sysctl, so needs to be updated as well.

rscheff added a subscriber: rscheff.

lgtm

Also can not really think of any sane reason why you'd require unique ephemeral outgoing ports (outside of the local host). Quite the opposite, that restricts the total number of outgoing connections globally and not on a per-destination basis. Finally, this sysctl apparently was never mentioned anywhere (searchable) to be a workaround for any observed or perceived issue - while the original intent of the referenced patch is apparently working as expected.

This revision is now accepted and ready to land.Feb 3 2023, 6:32 PM