Page MenuHomeFreeBSD
Differential D38266

kboot: Don't need an arch pointer to get segments
ClosedPublic
Actions

Authored by imp on Jan 29 2023, 3:16 PM.
Tags
None
Referenced Files
F92438243: D38266.id116024.diff
Sat, Aug 31, 9:49 AM
Unknown Object (File)
Fri, Aug 30, 7:50 PM
Unknown Object (File)
Fri, Aug 30, 8:48 AM
Unknown Object (File)
Tue, Aug 27, 3:29 PM
Unknown Object (File)
Mon, Aug 26, 10:24 AM
Unknown Object (File)
Sun, Aug 25, 3:37 PM
Unknown Object (File)
Fri, Aug 23, 12:24 PM
Unknown Object (File)
Wed, Aug 21, 4:35 PM
View All 95 Files
Subscribers
andrew
dab
emaste

Details

Reviewers
kevans
tsoome
manu
andrew
Commits
rG2b5179105359: kboot: Don't need an arch pointer to get segments
Summary

There's no need for an arch pointer to get segments. We can call the
rouinte directly since we don't need this code to be called from
different context where a pointer is needed.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49457
Build 46347: arc lint + arc unit

Event Timeline

imp created this revision.Jan 29 2023, 3:16 PM
Herald added a reviewer: manu. · View Herald TranscriptJan 29 2023, 3:16 PM
Herald added subscribers: dab, emaste, andrew. · View Herald Transcript
imp requested review of this revision.Jan 29 2023, 3:16 PM
Harbormaster completed remote builds in B49308: Diff 116024.Jan 29 2023, 3:16 PM
imp added a parent revision: D38265: kboot: For hostfs, return better errors from read, where possible..Jan 29 2023, 3:16 PM
imp added a child revision: D38267: kboot: Parse memory usage.
imp updated this revision to Diff 116263.Feb 1 2023, 11:25 PM

rebase / refactor / redo

Harbormaster completed remote builds in B49457: Diff 116263.Feb 1 2023, 11:25 PM
kevans accepted this revision.Feb 2 2023, 3:59 AM

rouinte -> routine in the commit message

This revision is now accepted and ready to land.Feb 2 2023, 3:59 AM
andrew accepted this revision.Feb 2 2023, 2:56 PM
Closed by commit rG2b5179105359: kboot: Don't need an arch pointer to get segments (authored by imp). · Explain WhyFeb 3 2023, 3:52 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG2b5179105359: kboot: Don't need an arch pointer to get segments.

Revision Contents
Changeset List

PathSize
stand/
common/
3 lines
kboot/
arch/
aarch64/
4 lines
amd64/
4 lines
powerpc64/
5 lines
3 lines
4 lines

Diff 116263

View Options

stand/common/bootstrap.h

Loading...
View Options

stand/kboot/arch/aarch64/exec.c

Loading...
View Options

stand/kboot/arch/amd64/elf64_freebsd.c

Loading...
View Options

stand/kboot/arch/powerpc64/ppc64_elf_freebsd.c

Loading...
View Options

stand/kboot/kboot.h

Loading...
View Options

stand/kboot/main.c

Loading...