Page MenuHomeFreeBSD

vmm: add VM_DESTROY ioctl call
Needs ReviewPublic

Authored by gusev.vitaliy_gmail.com on Apr 18 2022, 10:04 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Nov 29, 5:56 AM
Unknown Object (File)
Aug 31 2023, 10:02 PM
Unknown Object (File)
Aug 14 2023, 3:05 PM
Unknown Object (File)
Aug 14 2023, 2:17 AM
Unknown Object (File)
Jul 24 2023, 2:55 PM
Unknown Object (File)
Jul 10 2023, 12:25 AM
Unknown Object (File)
Jun 25 2023, 5:30 AM
Unknown Object (File)
Jun 25 2023, 5:29 AM

Details

Reviewers
None
Group Reviewers
bhyve
Summary

If bhyve compiled with capsicum support, vm_destroy() fails because sysctl calls are not allowed.

This is counterpart of https://reviews.freebsd.org/D31325 can probably can be used as replacement.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Mm, this conflicts with a change I have to make destroy synchronous due to a race with destroy not finishing before bhyve restarts in a loop. I think instead you might want some sort of model where you can set a flag when creating a VM (or perhaps via an ioctl) that causes the VM to be destroyed on last close.

The conflicting change I haven't yet uploaded for review but you can see it here: https://github.com/bsdjhb/freebsd/commit/213d5795a8a1e1835bf936d1c820ffd272e68b11

In D34954#793575, @jhb wrote:

Mm, this conflicts with a change I have to make destroy synchronous due to a race with destroy not finishing before bhyve restarts in a loop. I think instead you might want some sort of model where you can set a flag when creating a VM (or perhaps via an ioctl) that causes the VM to be destroyed on last close.

The conflicting change I haven't yet uploaded for review but you can see it here: https://github.com/bsdjhb/freebsd/commit/213d5795a8a1e1835bf936d1c820ffd272e68b11

I will check it out and update review. Thanks.