Differential D34868

nvme: Rename min_page_size to page_size and save mps
ClosedPublic
Actions

Authored by imp on Apr 10 2022, 5:11 PM.

Tags

None

Referenced Files

	F137832925: D34868.id.diff
	Wed, Nov 26, 6:11 AM

	F137822610: D34868.id105066.diff
	Wed, Nov 26, 3:46 AM

	Unknown Object (File)
	Sun, Nov 23, 7:54 PM

	Unknown Object (File)
	Sun, Nov 23, 4:50 PM

	Unknown Object (File)
	Sun, Nov 23, 5:42 AM

	Unknown Object (File)
	Sat, Nov 22, 6:41 PM

	Unknown Object (File)
	Sat, Nov 22, 12:05 PM

	Unknown Object (File)
	Sat, Nov 22, 10:20 AM

View All 79 Files

Subscribers

Details

Reviewers

mav
chuck
gallatin
chs
andrew
jimharris
rpokala

Commits

rG55412ef90ad1: nvme: Rename min_page_size to page_size and save mps

Summary

The Memory Page Size sets the basic unit of operation for the drive. We
currently set this to the drive's minimum page size, but we could set it
to any page size the drive supports in the future. Replace min_page_size
(it's now unused for that purpose) with page_size to reflect this and
cache the MPS we want to use. Use NVME_MPS_SHIFT to compute page_size.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Apr 10 2022, 5:11 PM

Herald added a subscriber: dab. · View Herald TranscriptApr 10 2022, 5:11 PM

imp requested review of this revision.Apr 10 2022, 5:11 PM

Harbormaster completed remote builds in B45109: Diff 104844.Apr 10 2022, 5:11 PM

imp added a parent revision: D34867: nvme: Base maximum data transfer size directly on MPSMIN in cap_hi.Apr 10 2022, 5:11 PM

imp added a child revision: D34869: nvme: Use saved mps when initializing drive.

chuck accepted this revision.Apr 14 2022, 3:18 PM

This revision is now accepted and ready to land.Apr 14 2022, 3:18 PM

Closed by commit rG55412ef90ad1: nvme: Rename min_page_size to page_size and save mps (authored by imp). · Explain WhyApr 15 2022, 8:48 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG55412ef90ad1: nvme: Rename min_page_size to page_size and save mps.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

5 lines

5 lines

Diff 105066

sys/dev/nvme/nvme_ctrlr.c

Loading...

sys/dev/nvme/nvme_private.h

Loading...