Page MenuHomeFreeBSD
Differential D34302

Add NT_ARM_ADDR_MASK
ClosedPublic
Actions

Authored by andrew on Feb 16 2022, 3:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 22, 3:08 AM
Unknown Object (File)
Sun, May 19, 11:22 AM
Unknown Object (File)
Sat, May 18, 10:37 AM
Unknown Object (File)
Fri, May 17, 6:29 PM
Unknown Object (File)
Apr 20 2024, 10:02 AM
Unknown Object (File)
Mar 7 2024, 8:00 PM
Unknown Object (File)
Feb 19 2024, 7:14 AM
Unknown Object (File)
Feb 13 2024, 12:13 AM
View All 27 Files
Subscribers
emaste
imp
val_packett.cool

Details

Reviewers
jhb
kib
manu
Group Reviewers
arm64
Commits
rG6713be315900: Add NT_ARM_ADDR_MASK
Summary

This can be used by debuggers to find which bits in a virtual address
should be masked off to get a canonical address. This is currently used
by the Pointer Authentication Code support to get its mask. It could also
be used if we support Top Byte Ignore for the same purpose.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Feb 16 2022, 3:47 PM
Herald added a reviewer: manu. · View Herald TranscriptFeb 16 2022, 3:47 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Feb 16 2022, 3:47 PM
Harbormaster completed remote builds in B44480: Diff 102842.Feb 16 2022, 3:47 PM
emaste added inline comments.Feb 16 2022, 3:52 PM
sys/sys/elf_common.h
828

fwiw I in Linux I see #define NT_ARM_PAC_MASK 0x406

andrew added inline comments.Feb 16 2022, 3:59 PM
sys/sys/elf_common.h
828

They both provide a mask, with the addition of possible a TBI mask on hardware without PAC in the future

kib accepted this revision.Feb 16 2022, 4:12 PM
This revision is now accepted and ready to land.Feb 16 2022, 4:12 PM
val_packett.cool added a subscriber: val_packett.cool.Feb 16 2022, 5:04 PM

It could also be used if we support Top Byte Ignore for the same purpose

Nice. I have experimented with TBI a few years ago — D20835. HWASAN was pretty easy to get working.

Closed by commit rG6713be315900: Add NT_ARM_ADDR_MASK (authored by andrew). · Explain WhyFeb 22 2022, 5:27 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG6713be315900: Add NT_ARM_ADDR_MASK.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
42 lines
8 lines
include/
3 lines
5 lines
3 lines
sys/
1 line
tests/
sys/
kern/
13 lines

Diff 103113

View Options

sys/arm64/arm64/elf_machdep.c

Loading...
View Options

sys/arm64/arm64/ptrauth.c

Loading...
View Options

sys/arm64/include/cpu.h

Loading...
View Options

sys/arm64/include/reg.h

Loading...
View Options

sys/arm64/include/vmparam.h

Loading...
View Options

sys/sys/elf_common.h

Loading...
View Options

tests/sys/kern/ptrace_test.c

Loading...