Page MenuHomeFreeBSD

Tidying up all the conditionals, when a spurious RTO is unwound
ClosedPublic

Authored by rscheff on Jan 27 2022, 3:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 7:09 PM
Unknown Object (File)
Sat, Sep 20, 6:18 PM
Unknown Object (File)
Sep 13 2025, 2:24 PM
Unknown Object (File)
Sep 11 2025, 1:04 PM
Unknown Object (File)
Aug 23 2025, 7:41 AM
Unknown Object (File)
Aug 19 2025, 3:09 AM
Unknown Object (File)
Aug 17 2025, 3:04 AM
Unknown Object (File)
Jul 30 2025, 1:05 AM

Details

Summary

This is a split-off from D33979, where only an acute issue is addressed.

The below points were noted incidentially while addressing that TF_PREVVALID
must not, just by itself, be used as sole condition for restoring old TCP state.

  • Use the semantically correct TSTMP_xx macro when comparing timestamps. (No functional change)
  • check for bad retransmits only when TSopt is present in ACK (don't assume there will be a valid TSopt in the TCP options struct)
  • exclude tsecr == 0, since that most likely indicates an invalid ts echo return (tsecr) value.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable