pfsync: fix incorrect enabling of defer mode
ClosedPublic
Actions

Authored by kp on Dec 3 2021, 9:49 AM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rGc36006be5424: pfsync: fix incorrect enabling of defer mode
rG3836400a785f: pfsync: fix incorrect enabling of defer mode
rG73fd0eaf5930: pfsync: fix incorrect enabling of defer mode

Summary

When we exposed the PFSYNCF_OK flag to userspace in 5f5bf88949d we
unintentionally caused defer mode to always be enabled.
The ioctl check only looked for nonzero, not for the PFSYNCF_DEFER flag.

Fix this check and ensure ifconfig sets the flag.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Dec 3 2021, 9:49 AM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptDec 3 2021, 9:49 AM

kp requested review of this revision.Dec 3 2021, 9:49 AM

Harbormaster completed remote builds in B43119: Diff 99391.Dec 3 2021, 9:49 AM

kp added a parent revision: D33243: pfsync: locking fixes.Dec 3 2021, 9:49 AM

kp added a child revision: D33245: pf tests: more thorough pfsync defer test.

glebius accepted this revision.Dec 3 2021, 4:52 PM

This revision is now accepted and ready to land.Dec 3 2021, 4:52 PM

Closed by commit rG73fd0eaf5930: pfsync: fix incorrect enabling of defer mode (authored by kp). · Explain WhyDec 6 2021, 12:26 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG73fd0eaf5930: pfsync: fix incorrect enabling of defer mode.

kp added a commit: rG3836400a785f: pfsync: fix incorrect enabling of defer mode.Dec 13 2021, 1:51 PM

kp added a commit: rGc36006be5424: pfsync: fix incorrect enabling of defer mode.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

ifpfsync.c

2 lines

sys/

netpfil/

pf/

if_pfsync.c

2 lines

Diff 99547

View Options

sbin/ifconfig/ifpfsync.c