Diffusion FreeBSD src repository 41c4f1987243

pfsync: locking fixes
41c4f1987243
Actions

Description

pfsync: locking fixes

Ensure we unlock the pfsync lock in pfsync_defer()
We must hold the bucket lock when calling pfsync_push()
The pfsync_defer_tmo() callout locks the bucket lock, not the pfsync lock

Reviewed by: glebius
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential Revision: https://reviews.freebsd.org/D33243

Details

Provenance

kp	Authored on Dec 2 2021, 4:42 PM

Reviewer

glebius

Differential Revision

D33243: pfsync: locking fixes

Parents

rG93a3fa41dcff: pfsync: fix defer timeout

Branches

Unknown

Tags

Unknown

Event Timeline

kp committed rG41c4f1987243: pfsync: locking fixes (authored by kp).Dec 6 2021, 12:25 PM

kp added an edge: D33243: pfsync: locking fixes.

kp mentioned this in rG87246654e350: pfsync: locking fixes.Dec 13 2021, 1:51 PM

kp mentioned this in rG7164b77ce2f3: pfsync: locking fixes.

Changes (1)

Path

Size

sys/

netpfil/

pf/

if_pfsync.c

rG41c4f1987243

View Options

sys/netpfil/pf/if_pfsync.c