Page MenuHomeFreeBSD
Differential D33244

pfsync: fix incorrect enabling of defer mode
ClosedPublic
Actions

Authored by kp on Dec 3 2021, 9:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 26, 4:54 AM
Unknown Object (File)
Thu, Oct 23, 11:36 AM
Unknown Object (File)
Mon, Oct 13, 10:01 PM
Unknown Object (File)
Mon, Oct 13, 10:01 PM
Unknown Object (File)
Mon, Oct 13, 8:23 AM
Unknown Object (File)
Mon, Oct 13, 8:23 AM
Unknown Object (File)
Sep 24 2025, 4:00 PM
Unknown Object (File)
Sep 19 2025, 10:50 AM
View All Files
Subscribers
farrokhi
glebius
imp
melifaro

Details

Reviewers
glebius
Group Reviewers
network
pfsense
Commits
rGc36006be5424: pfsync: fix incorrect enabling of defer mode
rG3836400a785f: pfsync: fix incorrect enabling of defer mode
rG73fd0eaf5930: pfsync: fix incorrect enabling of defer mode
Summary

When we exposed the PFSYNCF_OK flag to userspace in 5f5bf88949d we
unintentionally caused defer mode to always be enabled.
The ioctl check only looked for nonzero, not for the PFSYNCF_DEFER flag.

Fix this check and ensure ifconfig sets the flag.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43119
Build 40007: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
2 lines
sys/
netpfil/
pf/
2 lines

Diff 99391

View Options

sbin/ifconfig/ifpfsync.c

Loading...
View Options

sys/netpfil/pf/if_pfsync.c

Loading...