pf: Introduce ridentifier

[kp]

Summary

Allow users to set a number on rules which will be exposed as part of
the pflog header.
The intent behind this is to allow users to correlate rules across
updates (remember that pf rules continue to exist and match existing
states, even if they're removed from the active ruleset) and pflog.

Obtained from: pfSense
MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

[bcr]

Man page part of the change looks good. It needs a .Dd date bump when the commit happens.
Thanks for keeping up the good work on pf!

[eri]

sbin/pfctl/parse.y

267

Is there no better place for such info?
It sounds like forced through as is

[kp]

sbin/pfctl/parse.y

267

I’m not sure I understand your objection.

[eri]

sbin/pfctl/parse.y

267

I am pointing out that antispoof structure does not seem to have a relationship with a rule identifier.
Is there no better place to stick this new info/tag?

[kp]

sbin/pfctl/parse.y

267

That's there because you can also set ridentifier on antispoof rules. See line 1332 (in the new version).

[kp]

Ensure all antispoof rules get the ridentifier