Page MenuHomeFreeBSD
Differential D31059

Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 5:39 PM.
Tags
None
Referenced Files
F132429755: D31059.id94712.diff
Thu, Oct 16, 9:09 PM
F132429753: D31059.id.diff
Thu, Oct 16, 9:09 PM
F132429748: D31059.id91812.diff
Thu, Oct 16, 9:09 PM
F132389035: D31059.diff
Thu, Oct 16, 12:04 PM
Unknown Object (File)
Tue, Oct 14, 1:35 AM
Unknown Object (File)
Thu, Oct 9, 7:20 PM
Unknown Object (File)
Wed, Oct 8, 9:18 AM
Unknown Object (File)
Sat, Oct 4, 6:19 AM
View All 73 Files
Subscribers
bdrewery
imp

Details

Reviewers
dim
emaste
Commits
rGe7e22476d1d7: Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested
Summary

When building -DWITH_LLVM_BINUTILS -DWITHOUT_CLANG, this avoids
building a few hundred C++ source files that should not be needed
by default.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Jul 5 2021, 5:39 PM
Herald added subscribers: imp, bdrewery. · View Herald TranscriptJul 5 2021, 5:39 PM
arichardson requested review of this revision.Jul 5 2021, 5:39 PM
Harbormaster completed remote builds in B40314: Diff 91812.Jul 5 2021, 5:39 PM
emaste accepted this revision.Jul 16 2021, 2:39 AM

LGTM, but give @dim a day or so to weigh in.

This revision is now accepted and ready to land.Jul 16 2021, 2:39 AM
arichardson added a comment.Jul 19 2021, 2:02 PM
In D31059#702267, @emaste wrote:

LGTM, but give @dim a day or so to weigh in.

I guess we could also condition this on MK_CLANG|| MK_LLD but I'm not sure src.opts.mk is flexible enough.

Closed by commit rGe7e22476d1d7: Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested (authored by arichardson). · Explain WhySep 6 2021, 9:25 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGe7e22476d1d7: Don't default MK_LLVM_TARGET_ALL to yes unless MK_CLANG is requested.

Revision Contents
Changeset List

PathSize
share/
mk/
2 lines

Diff 94712

View Options

share/mk/src.opts.mk

Loading...