kern: fail getgroup and setgroup with negative int
ClosedPublic
Actions

Authored by imp on Jun 2 2021, 6:14 PM.

Details

Reviewers

brooks
markj

Commits

rGe991afea1e79: kern: fail getgroup and setgroup with negative int
rG4bc2174a1b48: kern: fail getgroup and setgroup with negative int

Summary

Found using
https://github.com/NetBSD/src/blob/trunk/tests/lib/libc/sys/t_getgroups.c

getgroups/setgroups want an int and therefore casting it to u_int
resulted in getgroups(-1, ...) not returning -1 / errno = EINVAL.

imp@ updated syscall.master, without which this change would be a nop.

PR: 189941
Tested by: imp@

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jun 2 2021, 6:14 PM

Herald added a reviewer: brooks. · View Herald TranscriptJun 2 2021, 6:14 PM

imp requested review of this revision.Jun 2 2021, 6:14 PM

Harbormaster completed remote builds in B39670: Diff 90336.Jun 2 2021, 6:14 PM

Not in this review: fixing t_getgroups.c and the regenerated system calls headers.

imp added a reviewer: markj.Jun 2 2021, 6:15 PM

markj accepted this revision.Jun 2 2021, 6:19 PM

markj added inline comments.

sys/kern/kern_prot.c
299	I would squash these into one line.
803	Same here.

This revision is now accepted and ready to land.Jun 2 2021, 6:19 PM

Closed by commit rG4bc2174a1b48: kern: fail getgroup and setgroup with negative int (authored by gh_moritzbuhl.de, committed by imp). · Explain WhyJun 2 2021, 7:25 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4bc2174a1b48: kern: fail getgroup and setgroup with negative int.

imp added a commit: rGe991afea1e79: kern: fail getgroup and setgroup with negative int.Jul 7 2021, 8:10 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_prot.c

12 lines

syscalls.master

4 lines

Diff 90338

View Options

sys/kern/kern_prot.c