Page MenuHomeFreeBSD

kern: fail getgroup and setgroup with negative int
ClosedPublic

Authored by imp on Jun 2 2021, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 7:23 AM
Unknown Object (File)
Tue, Oct 7, 10:06 PM
Unknown Object (File)
Tue, Sep 30, 6:34 PM
Unknown Object (File)
Fri, Sep 26, 2:46 AM
Unknown Object (File)
Thu, Sep 25, 8:01 AM
Unknown Object (File)
Sep 12 2025, 5:14 AM
Unknown Object (File)
Sep 10 2025, 4:52 PM
Unknown Object (File)
Sep 6 2025, 8:04 AM
Subscribers
None

Details

Summary

Found using
https://github.com/NetBSD/src/blob/trunk/tests/lib/libc/sys/t_getgroups.c

getgroups/setgroups want an int and therefore casting it to u_int
resulted in getgroups(-1, ...) not returning -1 / errno = EINVAL.

imp@ updated syscall.master, without which this change would be a nop.

PR: 189941
Tested by: imp@

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jun 2 2021, 6:14 PM

Not in this review: fixing t_getgroups.c and the regenerated system calls headers.

markj added inline comments.
sys/kern/kern_prot.c
299

I would squash these into one line.

803

Same here.

This revision is now accepted and ready to land.Jun 2 2021, 6:19 PM
This revision was automatically updated to reflect the committed changes.