Page MenuHomeFreeBSD

kern: fail getgroup and setgroup with negative int
ClosedPublic

Authored by imp on Jun 2 2021, 6:14 PM.

Details

Summary

Found using
https://github.com/NetBSD/src/blob/trunk/tests/lib/libc/sys/t_getgroups.c

getgroups/setgroups want an int and therefore casting it to u_int
resulted in getgroups(-1, ...) not returning -1 / errno = EINVAL.

imp@ updated syscall.master, without which this change would be a nop.

PR: 189941
Tested by: imp@

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Jun 2 2021, 6:14 PM

Not in this review: fixing t_getgroups.c and the regenerated system calls headers.

markj added inline comments.
sys/kern/kern_prot.c
299

I would squash these into one line.

803

Same here.

This revision is now accepted and ready to land.Jun 2 2021, 6:19 PM
This revision was automatically updated to reflect the committed changes.