Differential D30242

pf: Add DIOCGETSTATENV
ClosedPublic
Actions

Authored by kp on May 13 2021, 11:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 10, 11:37 AM

	Unknown Object (File)
	Sun, Nov 9, 10:25 PM

	Unknown Object (File)
	Thu, Oct 30, 11:49 AM

	Unknown Object (File)
	Mon, Oct 27, 1:26 PM

	Unknown Object (File)
	Wed, Oct 22, 4:15 AM

	Unknown Object (File)
	Oct 12 2025, 2:33 PM

	Unknown Object (File)
	Oct 4 2025, 9:06 AM

	Unknown Object (File)
	Oct 3 2025, 6:55 AM

Subscribers

Details

Reviewers

None

Group Reviewers

network
manpages

Commits

rG70762ee0f20c: pf: Add DIOCGETSTATENV
rGbc6cf5a56207: pf: Add DIOCGETSTATENV
rG1732afaa0dae: pf: Add DIOCGETSTATENV

Summary

Add DIOCGETSTATENV, an nvlist-based alternative to DIOCGETSTATE.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 13 2021, 11:48 AM

Herald added a reviewer: manpages. · View Herald TranscriptMay 13 2021, 11:48 AM

Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald Transcript

kp requested review of this revision.May 13 2021, 11:48 AM

kp added a child revision: D30243: pf: Add DIOCGETSTATESNV.

Harbormaster completed remote builds in B39161: Diff 89121.May 13 2021, 11:49 AM

eri added a subscriber: eri.May 13 2021, 3:15 PM

eri added inline comments.

sys/netpfil/pf/pf_ioctl.c
2478	Minor: Why not just put all of these NV code in its own file. pf_ioctl.c is quite large and would love to have more structure in the code and compartmentalisation while you doing this work.

kp added inline comments.May 13 2021, 3:32 PM

sys/netpfil/pf/pf_ioctl.c
2478	That's a reasonable suggestion, but something I'd do in a separate commit. There are a bunch of these already (as well as kernel to public struct conversions for the old style ioctls) that need to be moved then.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2021, 11:55 AM

Closed by commit rG1732afaa0dae: pf: Add DIOCGETSTATENV (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG1732afaa0dae: pf: Add DIOCGETSTATENV.

kp added a commit: rGbc6cf5a56207: pf: Add DIOCGETSTATENV.May 27 2021, 10:20 AM

kp added a commit: rG70762ee0f20c: pf: Add DIOCGETSTATENV.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

4 lines

sys/

net/

1 line

netpfil/

pf/

226 lines

Diff 89521

share/man/man4/pf.4

Loading...

sys/net/pfvar.h

Loading...

sys/netpfil/pf/pf_ioctl.c

Loading...