Page MenuHomeFreeBSD

pf: Add DIOCGETSTATENV
ClosedPublic

Authored by kp on May 13 2021, 11:48 AM.

Details

Summary

Add DIOCGETSTATENV, an nvlist-based alternative to DIOCGETSTATE.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.May 13 2021, 11:48 AM
kp added a child revision: D30243: pf: Add DIOCGETSTATESNV.
eri added inline comments.
sys/netpfil/pf/pf_ioctl.c
2477

Minor: Why not just put all of these NV code in its own file.
pf_ioctl.c is quite large and would love to have more structure in the code and compartmentalisation while you doing this work.

sys/netpfil/pf/pf_ioctl.c
2477

That's a reasonable suggestion, but something I'd do in a separate commit. There are a bunch of these already (as well as kernel to public struct conversions for the old style ioctls) that need to be moved then.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2021, 11:55 AM
Closed by commit rG1732afaa0dae: pf: Add DIOCGETSTATENV (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.