Differential D30242

pf: Add DIOCGETSTATENV
ClosedPublic
Actions

Authored by kp on May 13 2021, 11:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 4, 1:33 PM

	Unknown Object (File)
	Jan 16 2024, 1:13 AM

	Unknown Object (File)
	Jan 8 2024, 12:39 PM

	Unknown Object (File)
	Dec 23 2023, 12:36 AM

	Unknown Object (File)
	Dec 20 2023, 9:58 AM

	Unknown Object (File)
	Nov 1 2023, 7:15 AM

	Unknown Object (File)
	Sep 26 2023, 1:23 AM

	Unknown Object (File)
	Sep 10 2023, 4:24 AM

View All 30 Files

Subscribers

Details

Reviewers

None

Group Reviewers

network
manpages

Commits

rG70762ee0f20c: pf: Add DIOCGETSTATENV
rGbc6cf5a56207: pf: Add DIOCGETSTATENV
rG1732afaa0dae: pf: Add DIOCGETSTATENV

Summary

Add DIOCGETSTATENV, an nvlist-based alternative to DIOCGETSTATE.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39161
Build 36050: arc lint + arc unit

Event Timeline

kp created this revision.May 13 2021, 11:48 AM

Herald added a reviewer: manpages. · View Herald TranscriptMay 13 2021, 11:48 AM

Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald Transcript

kp requested review of this revision.May 13 2021, 11:48 AM

kp added a child revision: D30243: pf: Add DIOCGETSTATESNV.

Harbormaster completed remote builds in B39161: Diff 89121.May 13 2021, 11:49 AM

eri added a subscriber: eri.May 13 2021, 3:15 PM

eri added inline comments.

sys/netpfil/pf/pf_ioctl.c
2478	Minor: Why not just put all of these NV code in its own file. pf_ioctl.c is quite large and would love to have more structure in the code and compartmentalisation while you doing this work.

kp added inline comments.May 13 2021, 3:32 PM

sys/netpfil/pf/pf_ioctl.c
2478	That's a reasonable suggestion, but something I'd do in a separate commit. There are a bunch of these already (as well as kernel to public struct conversions for the old style ioctls) that need to be moved then.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2021, 11:55 AM

Closed by commit rG1732afaa0dae: pf: Add DIOCGETSTATENV (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG1732afaa0dae: pf: Add DIOCGETSTATENV.

kp added a commit: rGbc6cf5a56207: pf: Add DIOCGETSTATENV.May 27 2021, 10:20 AM

kp added a commit: rG70762ee0f20c: pf: Add DIOCGETSTATENV.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

4 lines

sys/

net/

1 line

netpfil/

pf/

226 lines

Diff 89121

share/man/man4/pf.4

Loading...

sys/net/pfvar.h

Loading...

sys/netpfil/pf/pf_ioctl.c

Loading...