Page MenuHomeFreeBSD

imgact_elf: Ensure that the return value in parse_notes is initialized
ClosedPublic

Authored by markj on Apr 25 2021, 11:50 PM.

Details

Summary

parse_notes relies on the caller-supplied callback to initialize "res".
Two callbacks are used in practice, brandnote_cb and note_fctl_cb, and
the latter fails to initialize res. Try to fix it.

Reported by: KMSAN

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I.e. the only effect of this was that the inner loop from check_note potentially did not stopped after fctl note was handled, but continued till the end of the phdrs.

This revision is now accepted and ready to land.Apr 26 2021, 12:03 AM
In D29986#672701, @kib wrote:

I.e. the only effect of this was that the inner loop from check_note potentially did not stopped after fctl note was handled, but continued till the end of the phdrs.

I think so, yes. I will note this in the commit message.