Page MenuHomeFreeBSD

Remove PCPU_INC
ClosedPublic

Authored by jah on Wed, Mar 17, 1:25 AM.

Details

Summary

e4b8deb22227 removed the last in-tree uses of PCPU_INC(). Its
potential benefit is also practically nonexistent. Non-x86
platforms already implement it as PCPU_ADD(..., 1), and according
to [0] there are no recent x86 processors for which the 'inc'
instruction provides a performance benefit over the equivalent
memory-operand form of the 'add' instruction. The only remaining
benefit of 'inc' is smaller instruction size, which in this case
is inconsequential given the limited number of per-CPU data consumers.

[0]: https://www.agner.org/optimize/instruction_tables.pdf

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jah requested review of this revision.Wed, Mar 17, 1:25 AM
This revision is now accepted and ready to land.Wed, Mar 17, 8:35 PM
This revision was automatically updated to reflect the committed changes.