Calculate prr_out correctly everywhere
ClosedPublic
Actions

Authored by rscheff on Mar 1 2021, 2:55 PM.

Details

Reviewers

kbowling
tuexen

Group Reviewers

transport

Commits

rG05e742af6f54: calculate prr_out correctly when pipe < ssthresh
rG0b0f8b359d0b: calculate prr_out correctly when pipe < ssthresh

Summary

missed the update to calculate prr_out properly
in the case when pipe < ssthresh.

prr_out should account for all packets sent during the
recovery episode. As an approximation (valid under
heavy loss), the original patch only uses
sackhint.sack_bytes_rexmit. This misses all packets
sent beyond recovery Point (snd_recover).

For the pipe > ssthresh case, this was fixed in D28941

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Mar 1 2021, 2:55 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptMar 1 2021, 2:55 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B37478: Diff 84905.Mar 1 2021, 2:55 PM

rscheff requested review of this revision.Mar 1 2021, 2:55 PM

tuexen accepted this revision.Mar 1 2021, 3:15 PM

This revision is now accepted and ready to land.Mar 1 2021, 3:15 PM

Closed by commit rG0b0f8b359d0b: calculate prr_out correctly when pipe < ssthresh (authored by rscheff). · Explain WhyMar 1 2021, 3:53 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG0b0f8b359d0b: calculate prr_out correctly when pipe < ssthresh.

rscheff added a commit: rG05e742af6f54: calculate prr_out correctly when pipe < ssthresh.Mar 4 2021, 8:28 AM

rscheff mentioned this in rGb8ffda0a37e1: tcp: various improvements and fixes to PRR.Mar 4 2021, 12:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

12 lines

Diff 84907

View Options

Calculate prr_out correctly everywhereClosedPublicActions