Include new data sent in PRR calculation
ClosedPublic
Actions

Authored by rscheff on Feb 26 2021, 5:09 PM.

Details

Reviewers

kbowling
tuexen

Group Reviewers

transport

Commits

rG9596751563dc: Include new data sent in PRR calculation
rG9e83a6a556ed: Include new data sent in PRR calculation

Summary

prr_out when pipe > ssthresh has to include
all sent data, including any new segments sent
beyond SACK retransmissions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rscheff created this revision.Feb 26 2021, 5:09 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptFeb 26 2021, 5:09 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

Harbormaster completed remote builds in B37410: Diff 84752.Feb 26 2021, 5:09 PM

rscheff requested review of this revision.Feb 26 2021, 5:09 PM

I have this running on my server and it LGTM

This revision is now accepted and ready to land.Feb 26 2021, 7:51 PM

Closed by commit rG9e83a6a556ed: Include new data sent in PRR calculation (authored by rscheff). · Explain WhyFeb 26 2021, 10:01 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rG9e83a6a556ed: Include new data sent in PRR calculation.

rscheff added a commit: rG9596751563dc: Include new data sent in PRR calculation.Mar 1 2021, 7:48 AM

rscheff mentioned this in D28998: Calculate prr_out correctly everywhere.Mar 1 2021, 2:55 PM

rscheff mentioned this in rGb8ffda0a37e1: tcp: various improvements and fixes to PRR.Mar 4 2021, 12:01 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_input.c

6 lines

Diff 84766

View Options

Include new data sent in PRR calculationClosedPublicActions