Page MenuHomeFreeBSD
Differential D28706

iflib: add new field: isc_dma_width
ClosedPublic
Actions

Authored by ar_semihalf.com on Feb 16 2021, 4:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 11:14 PM
Unknown Object (File)
Sun, Sep 6, 5:24 AM
Unknown Object (File)
Sun, Sep 6, 2:39 AM
Unknown Object (File)
Sat, Sep 5, 10:56 PM
Unknown Object (File)
Sat, Sep 5, 9:57 PM
Unknown Object (File)
Sat, Sep 5, 11:52 AM
Unknown Object (File)
Sat, Sep 5, 11:20 AM
Unknown Object (File)
Sat, Sep 5, 4:17 AM
View All Files
Subscribers
ae
erj
melifaro
iflib

Details

Reviewers
mmacy
gallatin
mw
shurd
Group Reviewers
iflib
Commits
rG6dd69f0064f1: iflib: introduce isc_dma_width
Summary

Some DMA controllers are unable to address the full host memory space
and are instead limited to a subset of address range (e.g. 48-bit).

Allow the driver to specify the maximum allowed DMA addressing width
(in bits) for the NIC hardware, by introducing a new field in
if_softc_ctx.

If said field is omitted (set to 0), the lowaddr of DMA window bounds
defaults to BUS_SPACE_MAXADDR.

Submitted by: Artur Rojek <ar@semihalf.com>
Obtained from: Semihalf
Sponsored by: Amazon, Inc.

Test Plan

In order to test, set scctx->isc_dma_width to a non-zero value, e.g. scctx->isc_dma_width = 48.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ar_semihalf.com created this revision.Feb 16 2021, 4:38 PM
Herald added a reviewer: shurd. · View Herald TranscriptFeb 16 2021, 4:38 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: melifaro, ae. · View Herald Transcript
ar_semihalf.com requested review of this revision.Feb 16 2021, 4:38 PM
gallatin accepted this revision.Feb 16 2021, 5:02 PM

I'm shocked that this feature was not present before.

This revision is now accepted and ready to land.Feb 16 2021, 5:02 PM
erj added a subscriber: erj.Feb 17 2021, 7:07 PM
erj added inline comments.
sys/net/iflib.h
239

You should validate this value -- what if someone puts in something ridiculous by accident?

ar_semihalf.com updated this revision to Diff 84394.Feb 21 2021, 1:32 PM

Changes:

  • provide a sanity check for isc_dma_width,
  • introduce a DMA_WIDTH_TO_BUS_LOWADDR macro to correctly handle edge cases where isc_dma_width equals either 0 or the number of bits in BUS_SPACE_MAXADDR
This revision now requires review to proceed.Feb 21 2021, 1:32 PM
gallatin accepted this revision.Feb 22 2021, 1:23 AM
This revision is now accepted and ready to land.Feb 22 2021, 1:23 AM
Closed by commit rG6dd69f0064f1: iflib: introduce isc_dma_width (authored by mw). · Explain WhyFeb 24 2021, 11:27 PM
This revision was automatically updated to reflect the committed changes.
mw added a commit: rG6dd69f0064f1: iflib: introduce isc_dma_width.

Revision Contents
Changeset List

PathSize
sys/
net/
2 lines
23 lines

Diff 84632

View Options

sys/net/iflib.h

Loading...
View Options

sys/net/iflib.c

Loading...