Update tests(7) as it was imported to base in r359260
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| share/man/man7/tests.7 | ||
|---|---|---|
| 106 ↗ | (On Diff #73271) | Shouldn't it be kyua(1)? |
| share/man/man7/tests.7 | ||
|---|---|---|
| 106 ↗ | (On Diff #73271) | Yeah, was thinking kyua.conf(5). |
| share/man/man7/tests.7 | ||
|---|---|---|
| 109 ↗ | (On Diff #73272) | Usually we use the Fx macro like this: .Fx 13.0 |
| 210 ↗ | (On Diff #73272) | I'd just replace the argument to -width with "/etc/kyua/kyua.conf". |
| 106 ↗ | (On Diff #73271) | BTW, do we even need to mention that it is installed here? That's probably what our users assume anyway when a tool is mentioned in a manual from the base system. |
| share/man/man7/tests.7 | ||
|---|---|---|
| 109 ↗ | (On Diff #73272) | Got it, it was also following "Installing the test suite" section, I will change both of them. |
| 210 ↗ | (On Diff #73272) | I found this results one space difference: .Bl -tag -compact -width etcXkyuaXkyuaXconfXX
/etc/kyua/kyua.conf System-wide configuration file for kyua(1).
^^^
.Bl -tag -compact -width "/etc/kyua/kyua.conf"
/etc/kyua/kyua.conf System-wide configuration file for kyua(1).
^^What's the convention in our manual? |
| 106 ↗ | (On Diff #73271) | I'm neutral about this. I added this to follow the "Installing the test suite" section. Maybe we can move both of them to HISTORY section? |
| share/man/man7/tests.7 | ||
|---|---|---|
| 210 ↗ | (On Diff #73272) | This is expected. Usually we set -width to literal a fixed string indent, which gives some reasonable default (it is interpreted by mandoc in a special way), or we pass the longest tag in the list as an argument to -width (like in this case). The second option always results in 2 spaces as you discovered. If neither of those two approaches gives a list that is nice looking, then we adjust the set -width to whatever increases the readability. |
| 106 ↗ | (On Diff #73271) | This part is one of the reasons I didn't write the patch myself ;) I wasn't sure if we want to keep this info or not. I'd say we can just remove it completely. Or move it to a history section, but that would not be a blocker for me. |
Comment Actions
LGTM! Thank you!
| share/man/man7/tests.7 | ||
|---|---|---|
| 225 ↗ | (On Diff #73325) |
How about: The .Fx Test Suite first appeared in .Fx 10.1 and became part of the base system in .Fx 11.0 . .Pp The test driver, .Xr kyua 1 , first appeared in the base system in .Fx 13.0 , previously being available only in .Xr ports 7 . |
| share/man/man7/tests.7 | ||
|---|---|---|
| 240 ↗ | (On Diff #73325) | Maybe s/by default/as part of the base system/? |
Comment Actions
I appreciate this update.
One thing that might be worth mentioning is that kyua(1) is still available from ports(7), as well as in the base system.
| share/man/man7/tests.7 | ||
|---|---|---|
| 240 ↗ | (On Diff #73325) | Agreed. |