Differential D14941

Move most of the contents of opt_compat.h to opt_global.h.
ClosedPublic
Actions

Authored by brooks on Apr 3 2018, 12:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 16, 2:13 AM

	Unknown Object (File)
	Thu, Dec 12, 11:22 AM

	Unknown Object (File)
	Wed, Dec 11, 9:11 AM

	Unknown Object (File)
	Fri, Dec 6, 12:33 PM

	Unknown Object (File)
	Fri, Dec 6, 12:33 PM

	Unknown Object (File)
	Fri, Dec 6, 12:33 PM

	Unknown Object (File)
	Fri, Dec 6, 12:32 PM

	Unknown Object (File)
	Wed, Dec 4, 12:25 PM

View All 91 Files

Subscribers

Details

Reviewers

emaste
cem
kib
jhb
slm
jtl

Group Reviewers

Commits

rS332122: Move most of the contents of opt_compat.h to opt_global.h.

Summary

opt_compat.h is mentioned in nearly 180 files. In-progress network
driver compabibility improvements may add over 100 more so this is
closer to "just about everywhere" than "only some files" per the
guidance in sys/conf/options.

Keep COMPAT_LINUX32 in opt_compat.h as it is confined to a subset of sys/compat/linux/*.c.

Move COMPAT_LINUXKPI to opt_dontuse.h as it is only used to control the set of compiled files.

Test Plan

builds for amd64, needs a universe run

Some risk of suprising changes exists due to failure to include
opt_compat.h correctly before.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16007
Build 15988: arc lint + arc unit

Event Timeline

brooks created this revision.Apr 3 2018, 12:45 AM

Herald added a reviewer: slm. · View Herald TranscriptApr 3 2018, 12:45 AM

Herald added a reviewer: transport. · View Herald Transcript

Herald added subscribers: ae, vangyzen, jhibbits, andrew. · View Herald Transcript

Harbormaster completed remote builds in B15951: Diff 41010.Apr 3 2018, 12:45 AM

cem accepted this revision.Apr 3 2018, 1:20 AM

kib added inline comments.Apr 3 2018, 9:44 AM

sys/conf/options
94	Why did you moved COMPAT_LINUXKPI ? I do not think that this option is ever tested by #ifdef.
sys/conf/options.amd64
20	COMPAT_LINUX32 is localized in the linuxolator files and certainly does not make much sense in global exposition.

Move COMPAT_LINUXKPI to opt_dontuse.h as it's never tested by #ifdef.
Move COMPAT_LINUX32 back to opt_compat.h.

Harbormaster completed remote builds in B15956: Diff 41022.Apr 3 2018, 3:50 PM

brooks retitled this revision from Move the contents of opt_compat.h to opt_global.h. to Move most of the contents of opt_compat.h to opt_global.h..Apr 3 2018, 3:55 PM

brooks edited the summary of this revision. (Show Details)

kib accepted this revision.Apr 3 2018, 4:09 PM

jhb accepted this revision.Apr 3 2018, 6:04 PM

The changes to sys/netinet are trivial.

This revision is now accepted and ready to land.Apr 5 2018, 10:23 PM

Herald added a reviewer: transport. · View Herald TranscriptApr 5 2018, 10:23 PM

This revision now requires review to proceed.Apr 5 2018, 10:23 PM

Remove a file added by accident.
Restore opt_compat.h for linux modules.

Harbormaster completed remote builds in B16007: Diff 41162.Apr 5 2018, 11:14 PM

I'll OK the sys/netinet/tcp_subr.c change on behalf of transport. :-)

This revision is now accepted and ready to land.Apr 6 2018, 12:08 AM

Closed in rS332122.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

2 lines

1 line

1 line

1 line

ptrace_machdep.c

2 lines

1 line

ia32/

2 lines

2 lines

2 lines

ia32_sigtramp.S

2 lines

1 line

linux/

2 lines

2 lines

linux32/

linux32_dummy.c

2 lines

linux32_machdep.c

2 lines

linux32_sysent.c

1 line

linux32_sysvec.c

1 line

syscalls.master

1 line

arm/

arm/

1 line

2 lines

arm64/

arm64/

1 line

cam/

scsi/

2 lines

2 lines

compat/

freebsd32/

freebsd32_ioctl.c

2 lines

freebsd32_misc.c

1 line

freebsd32_sysent.c

2 lines

ia32/

ia32_genassym.c

2 lines

2 lines

linux/

2 lines

conf/

20 lines

2 lines

2 lines

2 lines

options.powerpc

2 lines

dev/

aac/

1 line

aacraid/

1 line

acpica/

1 line

atkbdc/

1 line

cy/

2 lines

drm2/

1 line

2 lines

i915/

2 lines

radeon/

2 lines

filemon/

2 lines

filemon_wrapper.c

2 lines

kbdmux/

1 line

md/

1 line

mfi/

1 line

mpr/

2 lines

mps/

2 lines

mrsas/

1 line

null/

2 lines

pci/

1 line

rp/

2 lines

sio/

1 line

syscons/

1 line

1 line

uart/

1 line

usb/

input/

1 line

vkbd/

1 line

vt/

2 lines

fs/

cuse/

2 lines

devfs/

2 lines

procfs/

procfs_dbregs.c

2 lines

procfs_fpregs.c

2 lines

2 lines

2 lines

2 lines

geom/

2 lines

i386/

i386/

1 line

1 line

1 line

2 lines

linux/

2 lines

kern/

1 line

2 lines

1 line

1 line

1 line

1 line

1 line

1 line

2 lines

1 line

1 line

kern_resource.c

2 lines

kern_sendfile.c

2 lines

kern_sharedpage.c

1 line

1 line

1 line

1 line

1 line

1 line

2 lines

makesyscalls.sh

3 lines

subr_dummy_vdso_tc.c

2 lines

1 line

sys_getrandom.c

2 lines

2 lines

2 lines

1 line

1 line

1 line

1 line

1 line

2 lines

1 line

1 line

1 line

uipc_syscalls.c

1 line

2 lines

1 line

1 line

1 line

mips/

include/

4 lines

4 lines

4 lines

4 lines

mips/

freebsd32_machdep.c

2 lines

2 lines

1 line

1 line

1 line

modules/

aac/

2 lines

aacraid/

2 lines

cam/

1 line

cryptodev/

2 lines

cuse/

2 lines

drm2/

drm2/

2 lines

i915kms/

1 line

radeonkms/

1 line

dtrace/

dtrace/

2 lines

dtraceall/

9 lines

1 line

fasttrap/

2 lines

filemon/

2 lines

hyperv/

vmbus/

2 lines

if_tap/

7 lines

isp/

2 lines

kbdmux/

5 lines

linux/

2 lines

linux64/

2 lines

linux_common/

2 lines

mfi/

2 lines

mpr/

2 lines

mps/

2 lines

mqueue/

2 lines

procfs/

13 lines

rp/

7 lines

sem/

2 lines

sgx/

2 lines

sio/

7 lines

sysvipc/

sysvmsg/

2 lines

sysvsem/

2 lines

sysvshm/

2 lines

usb/

ukbd/

2 lines

vkbd/

5 lines

net/

1 line

1 line

1 line

1 line

netinet/

1 line

1 line

1 line

sctp_syscalls.c

1 line

1 line

netinet6/

1 line

1 line

opencrypto/

2 lines

powerpc/

aim/

1 line

1 line

booke/

booke_machdep.c

1 line

include/

4 lines

powerpc/

1 line

1 line

ptrace_machdep.c

2 lines

2 lines

sparc64/

sparc64/

1 line

1 line

vm/

1 line

2 lines

1 line

2 lines

x86/

x86/

1 line

1 line

Diff 41162

sys/amd64/amd64/db_trace.c

Loading...

sys/amd64/amd64/exception.S

Loading...

sys/amd64/amd64/genassym.c

Loading...

sys/amd64/amd64/machdep.c

Loading...

sys/amd64/amd64/ptrace_machdep.c

Loading...

sys/amd64/amd64/vm_machdep.c

Loading...

sys/amd64/ia32/ia32_misc.c

Loading...

sys/amd64/ia32/ia32_reg.c

Loading...

sys/amd64/ia32/ia32_signal.c

Loading...

sys/amd64/ia32/ia32_sigtramp.S

Loading...

sys/amd64/ia32/ia32_syscall.c

Loading...

sys/amd64/linux/linux_dummy.c

Loading...

sys/amd64/linux/linux_sysvec.c

Loading...

sys/amd64/linux32/linux32_dummy.c

Loading...

sys/amd64/linux32/linux32_machdep.c

Loading...

sys/amd64/linux32/linux32_sysent.c

Loading...

sys/amd64/linux32/linux32_sysvec.c

Loading...

sys/amd64/linux32/syscalls.master

Loading...

sys/arm/arm/machdep.c

Loading...

sys/arm/arm/vm_machdep.c

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/cam/scsi/scsi_enc.c

Loading...

sys/cam/scsi/scsi_pass.c

Loading...

sys/compat/freebsd32/freebsd32_ioctl.c

Loading...

sys/compat/freebsd32/freebsd32_misc.c

Loading...

sys/compat/freebsd32/freebsd32_sysent.c

Loading...

sys/compat/ia32/ia32_genassym.c

Loading...

sys/compat/ia32/ia32_sysvec.c

Loading...

sys/compat/linux/linux_util.c

Loading...

sys/conf/options

Loading...

sys/conf/options.amd64

Loading...

sys/conf/options.arm64

Loading...

sys/conf/options.mips

Loading...

sys/conf/options.powerpc

Loading...

sys/dev/aac/aac.c

Loading...

sys/dev/aacraid/aacraid.c

Loading...

sys/dev/acpica/acpi_hpet.c

Loading...

sys/dev/atkbdc/atkbd.c

Loading...

sys/dev/cy/cy.c

Loading...

sys/dev/drm2/drmP.h

Loading...

sys/dev/drm2/drm_ioc32.c

Loading...

sys/dev/drm2/i915/i915_ioc32.c

Loading...

sys/dev/drm2/radeon/radeon_ioc32.c

Loading...

sys/dev/filemon/filemon.c

Loading...

sys/dev/filemon/filemon_wrapper.c

Loading...

sys/dev/kbdmux/kbdmux.c

Loading...

sys/dev/md/md.c

Loading...

sys/dev/mfi/mfi.c

Loading...

sys/dev/mpr/mpr_user.c

Loading...

sys/dev/mps/mps_user.c

Loading...

sys/dev/mrsas/mrsas_linux.c

Loading...

sys/dev/null/null.c

Loading...

sys/dev/pci/pci_user.c

Loading...

sys/dev/rp/rp.c

Loading...

sys/dev/sio/sio.c

Loading...

sys/dev/syscons/scvidctl.c

Loading...

sys/dev/syscons/syscons.c

Loading...

sys/dev/uart/uart_kbd_sun.c

Loading...

sys/dev/usb/input/ukbd.c

Loading...

sys/dev/vkbd/vkbd.c

Loading...

sys/dev/vt/vt_core.c

Loading...

sys/fs/cuse/cuse.c

Loading...

sys/fs/devfs/devfs_devs.c

Loading...

sys/fs/procfs/procfs_dbregs.c

Loading...

sys/fs/procfs/procfs_fpregs.c

Loading...

sys/fs/procfs/procfs_ioctl.c

Loading...

sys/fs/procfs/procfs_map.c

Loading...

sys/fs/procfs/procfs_regs.c

Loading...

sys/geom/geom_dev.c

Loading...

sys/i386/i386/genassym.c

Loading...

sys/i386/i386/locore.s

Loading...

sys/i386/i386/machdep.c

Loading...

sys/i386/i386/sigtramp.s

Loading...

sys/i386/linux/linux_dummy.c

Loading...

sys/kern/imgact_elf.c

Loading...

sys/kern/init_sysent.c

Loading...

sys/kern/kern_descrip.c

Loading...

sys/kern/kern_event.c

Loading...

sys/kern/kern_exec.c

Loading...

sys/kern/kern_exit.c

Loading...

sys/kern/kern_jail.c

Loading...

sys/kern/kern_mib.c

Loading...

sys/kern/kern_module.c

Loading...

sys/kern/kern_proc.c

Loading...

sys/kern/kern_prot.c

Loading...

sys/kern/kern_resource.c

Loading...

sys/kern/kern_sendfile.c

Loading...

sys/kern/kern_sharedpage.c

Loading...

sys/kern/kern_sig.c

Loading...

sys/kern/kern_sysctl.c

Loading...

sys/kern/kern_tc.c

Loading...

sys/kern/kern_thr.c

Loading...

sys/kern/kern_umtx.c

Loading...

sys/kern/kern_xxx.c

Loading...

sys/kern/makesyscalls.sh

Loading...

sys/kern/subr_dummy_vdso_tc.c

Loading...

sys/kern/sys_generic.c

Loading...

sys/kern/sys_getrandom.c

Loading...

sys/kern/sys_pipe.c

Loading...

sys/kern/sys_process.c

Loading...

sys/kern/sysv_ipc.c

Loading...

sys/kern/sysv_msg.c

Loading...

sys/kern/sysv_sem.c

Loading...

sys/kern/sysv_shm.c

Loading...

sys/kern/tty.c

Loading...

sys/kern/tty_compat.c

Loading...

sys/kern/uipc_mqueue.c

Loading...

sys/kern/uipc_sem.c

Loading...

sys/kern/uipc_socket.c

Loading...

sys/kern/uipc_syscalls.c

Loading...

sys/kern/vfs_aio.c

Loading...

sys/kern/vfs_bio.c

Loading...

sys/kern/vfs_subr.c

Loading...

sys/kern/vfs_syscalls.c

Loading...

sys/mips/include/reg.h

Loading...

sys/mips/include/sigframe.h

Loading...

sys/mips/include/tls.h

Loading...

sys/mips/include/ucontext.h

Loading...

sys/mips/mips/freebsd32_machdep.c

Loading...

sys/mips/mips/pm_machdep.c

Loading...

sys/mips/mips/swtch.S

Loading...

sys/mips/mips/trap.c

Loading...

sys/mips/mips/vm_machdep.c

Loading...

sys/modules/aac/Makefile

Loading...

sys/modules/aacraid/Makefile

Loading...

sys/modules/cam/Makefile

Loading...

sys/modules/cryptodev/Makefile

Loading...

sys/modules/cuse/Makefile

Loading...

sys/modules/drm2/drm2/Makefile

Loading...

sys/modules/drm2/i915kms/Makefile

Loading...

sys/modules/drm2/radeonkms/Makefile

Loading...

sys/modules/dtrace/dtrace/Makefile

Loading...

sys/modules/dtrace/dtraceall/Makefile

Loading...

sys/modules/dtrace/dtraceall/dtraceall.c

Loading...

sys/modules/dtrace/fasttrap/Makefile

Loading...

sys/modules/filemon/Makefile

Loading...

sys/modules/hyperv/vmbus/Makefile

Loading...

sys/modules/if_tap/Makefile

Loading...

sys/modules/isp/Makefile

Loading...

sys/modules/kbdmux/Makefile

Loading...

sys/modules/linux/Makefile

Loading...

sys/modules/linux64/Makefile

Loading...

sys/modules/linux_common/Makefile

Loading...

sys/modules/mfi/Makefile

Loading...

sys/modules/mpr/Makefile

Loading...

sys/modules/mps/Makefile

Loading...

sys/modules/mqueue/Makefile

Loading...

sys/modules/procfs/Makefile

Loading...

sys/modules/rp/Makefile

Loading...

sys/modules/sem/Makefile

Loading...

sys/modules/sgx/Makefile

Loading...

sys/modules/sio/Makefile

Loading...

sys/modules/sysvipc/sysvmsg/Makefile

Loading...

sys/modules/sysvipc/sysvsem/Makefile

Loading...

sys/modules/sysvipc/sysvshm/Makefile

Loading...

sys/modules/usb/ukbd/Makefile

Loading...

sys/modules/vkbd/Makefile

Loading...

sys/net/bpf.c

Loading...

sys/net/if.c

Loading...

sys/net/if_tap.c

Loading...

sys/net/rtsock.c

Loading...

sys/netinet/in_jail.c

Loading...

sys/netinet/in_prot.c

Loading...

sys/netinet/sctp_os_bsd.h

Loading...

sys/netinet/sctp_syscalls.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet6/in6.c

Loading...

sys/netinet6/in6_jail.c

Loading...

sys/opencrypto/cryptodev.c

Loading...

sys/powerpc/aim/aim_machdep.c

Loading...

sys/powerpc/aim/mmu_oea64.c

Loading...

sys/powerpc/booke/booke_machdep.c

Loading...

sys/powerpc/include/reg.h

Loading...

sys/powerpc/powerpc/exec_machdep.c

Loading...

sys/powerpc/powerpc/machdep.c

Loading...

sys/powerpc/powerpc/ptrace_machdep.c

Loading...

sys/powerpc/powerpc/sys_machdep.c

Loading...

sys/sparc64/sparc64/exception.S

Loading...

sys/sparc64/sparc64/machdep.c

Loading...

sys/vm/swap_pager.c

Loading...

sys/vm/vm_meter.c

Loading...

sys/vm/vm_mmap.c

Loading...

sys/vm/vm_unix.c

Loading...

sys/x86/x86/cpu_machdep.c

Loading...

sys/x86/x86/tsc.c

Loading...