Today
LGTM.
All SPI_LYNXPOINT IDs are included in Linux PXA2 driver. See cat drivers/spi/spi-pxa2xx-pci.c | grep '^#.*PCI_DEVICE_ID_INTEL_' output
All SPI_SUNRISEPOINT IDs are included in Linux LPSS driver. See cat drivers/mfd/intel-lpss-pci.c | grep PCI_VDEVICE | grep _spi_ output
@wulf are these IDs (and the others in the stack) ok to you?
adress comments. clean copy/pasted code while prototyping.
I'm not sure if the rename is the right direction; this claims the mei attachment exclusively so maybe just call it that the limited scope is in the man page. If someone wants to wire up extended functionality in the future this is a good base to do so?
This is close, a couple inline nits still to address. I think the sysctls should be live queries, not just display attach time cached values. I'm not sure if the rename is the right direction; this claims the mei attachment exclusively so maybe just call it that the limited scope is in the man page. If someone wants to wire up extended functionality in the future this is a good base to do so?
Yesterday
until D59011, every SPI was double checked on hardware.
Renamed the driver. Since this is a probe only driver, it need it own name.
The mei driver will confuse both devs and other driver that expect the mei
name to be the full implmentation. The i915 driver talk to the ME to get HDCP support.
Tue, Aug 18
guard with bootverbose
Previously tested in every generation till Raptor Lake.
For reference, here's bug report I posted some time ago which made me deep-dive into this problem. It seems, as reduced ACPI hardware laptops (with Power buttons served by GPIO pin) become more frequent, we will have to solve this GPIO interrupts issue either way.
Last time I checked, porting x86 to intrng did not look trivial, at least for me.
Maybe it would not be too hard for someone with more experience in both.
