Yesterday
This /looks/ fine to me, but there's too much commenting for what's really self evident stuff.
Mon, Nov 2
Sun, Nov 1
Sat, Oct 31
@wulf any comments re: i2c'ness?
Thu, Oct 29
Wed, Oct 21
Mon, Oct 19
rebase
address comments
This is reasonable to me 👍. Waiting for feedback from the ACPI folks before providing a ship-it.
This seems good to me -- I'd like for someone knowledgeable in ACPI to weigh in though before I go spelunking into the ACPI code in order to give a ship-it.
Sun, Oct 18
reworked
Switched to a named constant, BCL_FIRST_LEVEL, alongside the existing
BCL_FULLPOWER/BCL_ECONOMY just above it. 3 is not an array size:
it returns the full-power level at [0], the economy level at [1], and the
selectable levels from [2]
The disabled by default was because i want to land it, ask current@ and other testers to enable it.
If there are no report of boards that misfire randomly , then followup with a default enabled before 16 release.
I second what @ngie said -- seems like default should be enabled (POLA and all)
...
This is a great technical description of the problem, but what's the punchline for the relevant end-user and/or average end-user: what does this change fix?
vid_enum_outputs() only registers a child whose _ADR appears in the
graphics controller's _DOD. _DOD is filled in from the graphics driver's
ACPI opregion on some platforms, so with no such driver attached it can
describe no device at all while the panel still implements _BCL, _BCM and
_BQC. The match then fails for every child and the machine is left with
no brightness control.
