Paths

Table of Contentst

Differential D58996

intelspi: sort PCI ID table by device ID
ClosedPublic
Actions

Authored by seuros on Wed, Aug 19, 7:51 PM.

Tags

Referenced Files

	F169254146: D58996.diff
	Tue, Sep 1, 1:52 AM

	F169234156: D58996.id184686.diff
	Tue, Sep 1, 12:01 AM

	F169212668: D58996.id184378.diff
	Mon, Aug 31, 9:09 PM

	Unknown Object (File)
	Mon, Aug 31, 4:38 AM

	Unknown Object (File)
	Sun, Aug 30, 10:00 PM

	Unknown Object (File)
	Sun, Aug 30, 11:32 AM

	Unknown Object (File)
	Sun, Aug 30, 12:17 AM

	Unknown Object (File)
	Sat, Aug 29, 11:02 PM

View All 36 Files

Subscribers

Details

Reviewers

adrian
wulf

Commits

rG728775442c62: intelspi: sort PCI ID table by device ID

Summary

Sort the existing LPSS peripheral SPI controller PCI ID table by
numeric device ID so new entries have an unambiguous insertion point.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

seuros created this revision.Wed, Aug 19, 7:51 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 7:51 PM

seuros requested review of this revision.Wed, Aug 19, 7:51 PM

Harbormaster completed remote builds in B75748: Diff 184378.Wed, Aug 19, 7:51 PM

seuros added a child revision: D58997: intelspi: add Broxton SPI controller IDs.Wed, Aug 19, 7:53 PM

seuros retitled this revision from intel/spi: sort PCI ID table by device ID to intelspi: sort PCI ID table by device ID.Thu, Aug 20, 12:07 PM

@wulf are these IDs (and the others in the stack) ok to you?

LGTM.
All SPI_LYNXPOINT IDs are included in Linux PXA2 driver. See cat drivers/spi/spi-pxa2xx-pci.c | grep '^#.*PCI_DEVICE_ID_INTEL_' output
All SPI_SUNRISEPOINT IDs are included in Linux LPSS driver. See cat drivers/mfd/intel-lpss-pci.c | grep PCI_VDEVICE | grep _spi_ output

This revision is now accepted and ready to land.Thu, Aug 20, 4:35 PM

Closed by commit rG728775442c62: intelspi: sort PCI ID table by device ID (authored by seuros, committed by adrian). · Explain WhyFri, Aug 21, 5:44 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG728775442c62: intelspi: sort PCI ID table by device ID.

Revision Contents
Changeset List

Path

Size

sys/

dev/

intel/

6 lines

Diff 184686

sys/dev/intel/spi_pci.c

Loading...