Page MenuHomeFreeBSD

zlei (Zhenlei Huang)
User

Projects

User Details

User Since
Apr 1 2021, 3:21 AM (236 w, 3 d)

Recent Activity

Today

zlei added inline comments to D53022: if_vxlan: fix byteorder of source port.
Sun, Oct 12, 1:18 PM

Fri, Oct 10

zlei accepted D53022: if_vxlan: fix byteorder of source port.

Looks good to me.

Fri, Oct 10, 3:24 PM
zlei added a comment to D53022: if_vxlan: fix byteorder of source port.

Looks good to me.

Fri, Oct 10, 3:24 PM

Sat, Oct 4

zlei committed rG8583840cfb92: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
Sat, Oct 4, 4:47 PM
zlei committed rGb4a079dd78a6: witness: White space cleanup and some style(9) tweeks (authored by zlei).
witness: White space cleanup and some style(9) tweeks
Sat, Oct 4, 4:47 PM
zlei committed rGd334e045a471: ifconfig: Fix the display of the IFCAP_MEXTPG capability (authored by zlei).
ifconfig: Fix the display of the IFCAP_MEXTPG capability
Sat, Oct 4, 4:47 PM
zlei committed rGa08e8da2745d: ifconfig: Display the IFCAP_HWSTATS capability (authored by zlei).
ifconfig: Display the IFCAP_HWSTATS capability
Sat, Oct 4, 4:47 PM
zlei committed rG22f26eb3b897: ifconfig: Garbage collect unused parameter swabips (authored by zlei).
ifconfig: Garbage collect unused parameter swabips
Sat, Oct 4, 4:47 PM
zlei committed rGce95ba8ae530: tcp: Add CTLFLAG_VNET flag to some sysctls (authored by zlei).
tcp: Add CTLFLAG_VNET flag to some sysctls
Sat, Oct 4, 4:47 PM
zlei committed rG4b92e54c9b5a: tcp: Fix expiring and purging hostcache entries of vnet jails (authored by zlei).
tcp: Fix expiring and purging hostcache entries of vnet jails
Sat, Oct 4, 4:47 PM
zlei committed rGd59a8f27fc07: tslog: Move sysinit_tslog_shim() into kern_tslog.c (authored by zlei).
tslog: Move sysinit_tslog_shim() into kern_tslog.c
Sat, Oct 4, 4:47 PM
zlei committed rG1d101415d7ec: qlnxe: Report speeds in decimal format (authored by zlei).
qlnxe: Report speeds in decimal format
Sat, Oct 4, 4:46 PM
zlei committed rGf30da24e9d6a: qlnxe: Support SIOCGIFXMEDIA ioctl (authored by zlei).
qlnxe: Support SIOCGIFXMEDIA ioctl
Sat, Oct 4, 4:46 PM
zlei committed rG49fbc8dcf77d: qlnxe: Unconditionally enable extended media types (authored by zlei).
qlnxe: Unconditionally enable extended media types
Sat, Oct 4, 4:46 PM
zlei committed rGad08006c7fd5: qlnxe: Fix advertising the IFCAP_LINKSTATE capability (authored by zlei).
qlnxe: Fix advertising the IFCAP_LINKSTATE capability
Sat, Oct 4, 4:46 PM
zlei committed rG4dc6c65704de: init_main: Fix logging the subsystem of pre-loaded kernel modules (authored by zlei).
init_main: Fix logging the subsystem of pre-loaded kernel modules
Sat, Oct 4, 4:46 PM
zlei committed rG1a9f9b4e38c3: ipfw: Teach ipfw that EtherIP is an upper layer protocol (authored by zlei).
ipfw: Teach ipfw that EtherIP is an upper layer protocol
Sat, Oct 4, 4:46 PM
zlei committed rG7cbb184bbfa3: gif.4: Mention that gif(4) can tunnel Ethernet traffic (authored by zlei).
gif.4: Mention that gif(4) can tunnel Ethernet traffic
Sat, Oct 4, 4:45 PM
zlei committed rG6e605ed6df40: EtherIP: Fix passing the address family from if_bridge(4) to gif(4) (authored by zlei).
EtherIP: Fix passing the address family from if_bridge(4) to gif(4)
Sat, Oct 4, 4:45 PM
zlei committed rGa3fbecac6879: tests: gif(4): Add regression tests for setup with EtherIP (authored by zlei).
tests: gif(4): Add regression tests for setup with EtherIP
Sat, Oct 4, 4:45 PM
zlei committed rG767db004475a: tests: gif(4): Add tests to cover all IPv[46] in IPv[46] setups (authored by zlei).
tests: gif(4): Add tests to cover all IPv[46] in IPv[46] setups
Sat, Oct 4, 4:45 PM
zlei added a comment to D52852: vxlan: support moving to a different vnet.

I've ever considered this approach, but this adds too many headaches. Well I'd propose to use vlxan(4) + bridge(4) + epair(4) if the underlay network is in different VNET.

Sat, Oct 4, 3:29 AM

Fri, Oct 3

zlei accepted D52731: sys/netinet6: Use atomic(9) for dad_failures counter.

Looks good to me.

Fri, Oct 3, 12:54 AM

Wed, Oct 1

zlei committed rG7838ad85fb1a: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
Wed, Oct 1, 2:17 AM
zlei committed rG3dc9f96a489c: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
Wed, Oct 1, 2:15 AM

Mon, Sep 29

zlei accepted D52731: sys/netinet6: Use atomic(9) for dad_failures counter.

This generally looks good to me.

Mon, Sep 29, 8:04 AM

Sat, Sep 27

zlei added a reverting change for rG23ac9029f96b: Update iflib to support more NIC designs: rG04741ceafa2c: iflib: Set the get counter routine prior to attaching the interface.
Sat, Sep 27, 3:20 PM
zlei committed rG9ed73bd78c78: Migrate from printb to print_bits for locally defined bit fields. (authored by gordon).
Migrate from printb to print_bits for locally defined bit fields.
Sat, Sep 27, 3:16 PM
zlei committed rGac91312f28a9: Move print_bits to ifconfig.c and make available to other src files. (authored by gordon).
Move print_bits to ifconfig.c and make available to other src files.
Sat, Sep 27, 3:16 PM
zlei committed rGccbc722a1945: tcp: Add CTLFLAG_VNET flag to some sysctls (authored by zlei).
tcp: Add CTLFLAG_VNET flag to some sysctls
Sat, Sep 27, 3:15 PM
zlei committed rG79d114544fab: tcp: Fix expiring and purging hostcache entries of vnet jails (authored by zlei).
tcp: Fix expiring and purging hostcache entries of vnet jails
Sat, Sep 27, 3:15 PM
zlei committed rG1bd02c42131a: ifconfig: Display the IFCAP_HWSTATS capability without netlink (authored by zlei).
ifconfig: Display the IFCAP_HWSTATS capability without netlink
Sat, Sep 27, 3:15 PM
zlei committed rG6a2eca1b38d7: ifconfig: Fix the display of the IFCAP_MEXTPG capability without netlink (authored by zlei).
ifconfig: Fix the display of the IFCAP_MEXTPG capability without netlink
Sat, Sep 27, 3:15 PM
zlei committed rG8049f85bdd8b: vtnet: Do "hardware" accounting for the total number of received octets (authored by joyul_juniper.net).
vtnet: Do "hardware" accounting for the total number of received octets
Sat, Sep 27, 3:15 PM
zlei committed rG7d680875473d: vtnet: Prefer "hardware" accounting for the multicast and total number of… (authored by joyul_juniper.net).
vtnet: Prefer "hardware" accounting for the multicast and total number of…
Sat, Sep 27, 3:15 PM
zlei committed rG112d1a5f5df0: tslog: Move sysinit_tslog_shim() into kern_tslog.c (authored by zlei).
tslog: Move sysinit_tslog_shim() into kern_tslog.c
Sat, Sep 27, 3:15 PM
zlei committed rG94d3be2b547c: qlnxe: Report speeds in decimal format (authored by zlei).
qlnxe: Report speeds in decimal format
Sat, Sep 27, 3:15 PM
zlei committed rGac4b48b6ad34: qlnxe: Support SIOCGIFXMEDIA ioctl (authored by zlei).
qlnxe: Support SIOCGIFXMEDIA ioctl
Sat, Sep 27, 3:15 PM
zlei committed rG2cb20b25a573: qlnxe: Unconditionally enable extended media types (authored by zlei).
qlnxe: Unconditionally enable extended media types
Sat, Sep 27, 3:15 PM
zlei committed rG17226a28bbd5: rmlock: Sprinkle const qualifiers where appropriate (authored by zlei).
rmlock: Sprinkle const qualifiers where appropriate
Sat, Sep 27, 3:15 PM
zlei committed rG79720e10b208: rwlock: Sprinkle const qualifiers where appropriate (authored by zlei).
rwlock: Sprinkle const qualifiers where appropriate
Sat, Sep 27, 3:15 PM
zlei committed rGc2f1bb9a8c02: kenv: Sprinkle const qualifiers where appropriate (authored by zlei).
kenv: Sprinkle const qualifiers where appropriate
Sat, Sep 27, 3:15 PM
zlei committed rG89c3be21d65b: mtx: Sprinkle const qualifiers where appropriate (authored by zlei).
mtx: Sprinkle const qualifiers where appropriate
Sat, Sep 27, 3:15 PM
zlei committed rGdc32441e3825: ifnet: Defer detaching address family dependent data (authored by zlei).
ifnet: Defer detaching address family dependent data
Sat, Sep 27, 3:15 PM
zlei committed rGe05d4c4c08b2: ethernet: Prefer memcmp() over bcmp() (authored by zlei).
ethernet: Prefer memcmp() over bcmp()
Sat, Sep 27, 3:15 PM
zlei committed rG3038122a7642: init_main: Remove the placeholder SYSINIT (authored by zlei).
init_main: Remove the placeholder SYSINIT
Sat, Sep 27, 3:15 PM
zlei committed rGb2293f7f60c2: init_main: Fix logging the subsystem of pre-loaded kernel modules (authored by zlei).
init_main: Fix logging the subsystem of pre-loaded kernel modules
Sat, Sep 27, 3:15 PM
zlei committed rG04741ceafa2c: iflib: Set the get counter routine prior to attaching the interface (authored by zlei).
iflib: Set the get counter routine prior to attaching the interface
Sat, Sep 27, 3:15 PM
zlei committed rG8d6bc14c5474: iflib: Make iflib_register() return void (authored by zlei).
iflib: Make iflib_register() return void
Sat, Sep 27, 3:15 PM
zlei committed rGb4c6c3db0379: ipfw: Teach ipfw that EtherIP is an upper layer protocol (authored by zlei).
ipfw: Teach ipfw that EtherIP is an upper layer protocol
Sat, Sep 27, 3:15 PM
zlei committed rG52dbbe3f37ff: bridge: Fix adding gif(4) interface assigned with IP addresses as bridge memeber (authored by zlei).
bridge: Fix adding gif(4) interface assigned with IP addresses as bridge memeber
Sat, Sep 27, 3:14 PM
zlei committed rG5c6fae9d27da: tests: bridge: Add regression test for gif(4) interface as bridge member (authored by zlei).
tests: bridge: Add regression test for gif(4) interface as bridge member
Sat, Sep 27, 3:14 PM
zlei committed rGaeb8f341ad20: EtherIP: Fix passing the address family from if_bridge(4) to gif(4) (authored by zlei).
EtherIP: Fix passing the address family from if_bridge(4) to gif(4)
Sat, Sep 27, 3:14 PM
zlei committed rG1b42526ce9f4: gif.4: Mention that gif(4) can tunnel Ethernet traffic (authored by zlei).
gif.4: Mention that gif(4) can tunnel Ethernet traffic
Sat, Sep 27, 3:14 PM
zlei committed rGe5f01421ddbf: tests: gif(4): Add regression tests for setup with EtherIP (authored by zlei).
tests: gif(4): Add regression tests for setup with EtherIP
Sat, Sep 27, 3:14 PM
zlei committed rG032918dfd155: tcp: Add CTLFLAG_VNET flag to some sysctls (authored by zlei).
tcp: Add CTLFLAG_VNET flag to some sysctls
Sat, Sep 27, 2:02 PM
zlei committed rGfa30199a3dbf: tcp: Fix expiring and purging hostcache entries of vnet jails (authored by zlei).
tcp: Fix expiring and purging hostcache entries of vnet jails
Sat, Sep 27, 2:02 PM

Thu, Sep 25

zlei updated subscribers of D52731: sys/netinet6: Use atomic(9) for dad_failures counter.
Thu, Sep 25, 2:57 PM

Wed, Sep 24

zlei committed rG6bcce275a5a9: ifconfig: Display the IFCAP_HWSTATS capability without netlink (authored by zlei).
ifconfig: Display the IFCAP_HWSTATS capability without netlink
Wed, Sep 24, 1:32 PM
zlei committed rG5f472754ba6f: ifconfig: Fix the display of the IFCAP_MEXTPG capability without netlink (authored by zlei).
ifconfig: Fix the display of the IFCAP_MEXTPG capability without netlink
Wed, Sep 24, 1:31 PM
zlei closed D52693: tcp: Add CTLFLAG_VNET flag to some sysctls.
Wed, Sep 24, 1:40 AM
zlei closed D52692: tcp: Fix expiring and purging hostcache entries of vnet jails.
Wed, Sep 24, 1:40 AM
zlei committed rGb1f96169cfb5: tcp: Add CTLFLAG_VNET flag to some sysctls (authored by zlei).
tcp: Add CTLFLAG_VNET flag to some sysctls
Wed, Sep 24, 1:40 AM
zlei committed rG33ceb31e256e: tcp: Fix expiring and purging hostcache entries of vnet jails (authored by zlei).
tcp: Fix expiring and purging hostcache entries of vnet jails
Wed, Sep 24, 1:40 AM

Tue, Sep 23

zlei updated the summary of D52693: tcp: Add CTLFLAG_VNET flag to some sysctls.
Tue, Sep 23, 3:40 PM
zlei updated the summary of D52693: tcp: Add CTLFLAG_VNET flag to some sysctls.
Tue, Sep 23, 3:34 PM
zlei requested review of D52693: tcp: Add CTLFLAG_VNET flag to some sysctls.
Tue, Sep 23, 3:31 PM
zlei requested review of D52692: tcp: Fix expiring and purging hostcache entries of vnet jails.
Tue, Sep 23, 3:29 PM
zlei committed rGb1c96e54b906: ipfw: Teach ipfw that EtherIP is an upper layer protocol (authored by zlei).
ipfw: Teach ipfw that EtherIP is an upper layer protocol
Tue, Sep 23, 1:09 PM

Mon, Sep 22

zlei added a reverting change for rG0c1684dd456e: ifconfig: Display the IFCAP_NV capability without netlink: rG0143af8499ca: Revert "ifconfig: Display the IFCAP_NV capability without netlink".
Mon, Sep 22, 4:58 AM
zlei committed rG0143af8499ca: Revert "ifconfig: Display the IFCAP_NV capability without netlink" (authored by zlei).
Revert "ifconfig: Display the IFCAP_NV capability without netlink"
Mon, Sep 22, 4:58 AM

Sun, Sep 21

zlei added a comment to D52594: if_gif: Use the MTU on the gif interface for the outgoing packets.

I'm going to firstly integrate part of this change, to be precisely, the if_bridge's MTU change behavior of adding if_gif(4) as a member interface.

Sun, Sep 21, 5:07 PM
zlei committed rG0c1684dd456e: ifconfig: Display the IFCAP_NV capability without netlink (authored by zlei).
ifconfig: Display the IFCAP_NV capability without netlink
Sun, Sep 21, 4:51 PM
zlei committed rG595acb29a35f: ifconfig: Display the IFCAP_HWSTATS capability without netlink (authored by zlei).
ifconfig: Display the IFCAP_HWSTATS capability without netlink
Sun, Sep 21, 4:51 PM
zlei added a comment to D52629: libc: Import OpenBSD's inet_net_{ntop,pton}.

This change touches inet_net_ntop_ipv4(). I think this deserves careful review.

Sun, Sep 21, 3:26 PM

Fri, Sep 19

zlei added a comment to D52594: if_gif: Use the MTU on the gif interface for the outgoing packets.

This worked very well for me, both for EtherIP (Ethernet-ovet-IPv6) and IPIP (v6-over-v6).

Fri, Sep 19, 7:27 PM
zlei committed rG5017fdb72881: ifconfig: Fix the display of the IFCAP_MEXTPG capability without netlink (authored by zlei).
ifconfig: Fix the display of the IFCAP_MEXTPG capability without netlink
Fri, Sep 19, 7:20 PM
zlei committed rG7efef20a8da3: sx: Sprinkle const qualifiers where appropriate (authored by zlei).
sx: Sprinkle const qualifiers where appropriate
Fri, Sep 19, 2:05 AM
zlei committed rG6626e0af0bba: rwlock: Sprinkle const qualifiers where appropriate (authored by zlei).
rwlock: Sprinkle const qualifiers where appropriate
Fri, Sep 19, 2:05 AM
zlei committed rG662d5359dde5: rmlock: Sprinkle const qualifiers where appropriate (authored by zlei).
rmlock: Sprinkle const qualifiers where appropriate
Fri, Sep 19, 2:05 AM
zlei committed rG2ab1b6b2d3ac: mtx: Sprinkle const qualifiers where appropriate (authored by zlei).
mtx: Sprinkle const qualifiers where appropriate
Fri, Sep 19, 2:05 AM
zlei committed rGa876cfb54cb7: kenv: Sprinkle const qualifiers where appropriate (authored by zlei).
kenv: Sprinkle const qualifiers where appropriate
Fri, Sep 19, 2:04 AM

Thu, Sep 18

zlei committed rG6fb046515ea6: qlnxe: Report speeds in decimal format (authored by zlei).
qlnxe: Report speeds in decimal format
Thu, Sep 18, 4:19 PM
zlei committed rGbd721f6e8040: tslog: Move sysinit_tslog_shim() into kern_tslog.c (authored by zlei).
tslog: Move sysinit_tslog_shim() into kern_tslog.c
Thu, Sep 18, 4:19 PM
zlei committed rG817bc7009270: qlnxe: Support SIOCGIFXMEDIA ioctl (authored by zlei).
qlnxe: Support SIOCGIFXMEDIA ioctl
Thu, Sep 18, 4:19 PM
zlei committed rG5aa49c98edfc: qlnxe: Unconditionally enable extended media types (authored by zlei).
qlnxe: Unconditionally enable extended media types
Thu, Sep 18, 4:19 PM
zlei added inline comments to D52601: sys/bus.h: Indent tweeks.
Thu, Sep 18, 10:02 AM
zlei requested review of D52601: sys/bus.h: Indent tweeks.
Thu, Sep 18, 9:57 AM

Wed, Sep 17

zlei committed rG2d85bc89294b: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
Wed, Sep 17, 4:50 PM
zlei closed D52496: witness: Record the first acquired file and line for recursable locks.
Wed, Sep 17, 4:50 PM

Tue, Sep 16

zlei updated the diff for D52496: witness: Record the first acquired file and line for recursable locks.

Refactored a little to avoid duplicating, as suggested by Mark.

Tue, Sep 16, 6:07 PM
zlei closed D52566: ipfw: Teach ipfw that EtherIP is an upper layer protocol.
Tue, Sep 16, 4:02 PM
zlei committed rG0418e6690e91: ipfw: Teach ipfw that EtherIP is an upper layer protocol (authored by zlei).
ipfw: Teach ipfw that EtherIP is an upper layer protocol
Tue, Sep 16, 4:02 PM
zlei updated the summary of D52566: ipfw: Teach ipfw that EtherIP is an upper layer protocol.
Tue, Sep 16, 2:41 AM
zlei requested review of D52566: ipfw: Teach ipfw that EtherIP is an upper layer protocol.
Tue, Sep 16, 2:40 AM

Sat, Sep 13

zlei accepted D52501: ifconfig: Enter jail as soon as possible.

Looks good to me.

Sat, Sep 13, 1:25 AM

Sep 12 2025

zlei updated the test plan for D52496: witness: Record the first acquired file and line for recursable locks.
Sep 12 2025, 8:56 AM
zlei added a comment to D52496: witness: Record the first acquired file and line for recursable locks.

In the mailing list, @bz suggested to list the chain of the recursive lock. I think that is useful but requires some extra effort. I'm still working on it, will publish when ready.

Sep 12 2025, 8:11 AM
zlei requested review of D52496: witness: Record the first acquired file and line for recursable locks.
Sep 12 2025, 8:10 AM
zlei committed rG64dca4eb4db8: git-blame-ignore-revs: sys/bus.h style(9) fixes (authored by zlei).
git-blame-ignore-revs: sys/bus.h style(9) fixes
Sep 12 2025, 4:57 AM