User Details
User Details
- User Since
- Apr 1 2021, 3:21 AM (242 w, 1 d)
Sun, Nov 16
Sun, Nov 16
zlei committed rGa537694b49f7: sys/net/sff8436.h: Fix the register address of link length of copper or active… (authored by Kirill Kochnev <sabashlive@gmail.com>).
sys/net/sff8436.h: Fix the register address of link length of copper or active…
Fri, Nov 14
Fri, Nov 14
zlei added a comment to D53739: Update ip_ecn to use C standard types.
I have no objections to do this. Well new code should prefer the standard types, but the existing code can be left as is.
Mon, Nov 3
Mon, Nov 3
Tue, Oct 28
Tue, Oct 28
zlei added inline comments to D53387: if_media.h: Add 400GBase-SR8 and 400GBase-CR8.
Sun, Oct 26
Sun, Oct 26
zlei added inline comments to D53344: net: Validate interface group names in ioctl handlers.
zlei added inline comments to D53344: net: Validate interface group names in ioctl handlers.
Sat, Oct 25
Sat, Oct 25
Fri, Oct 24
Fri, Oct 24
Looks good to me.
So typically a queue is bound to one core, then we have better cache localization for the same flow ? That sounds a good idea.
Looks good to me.
I spent some time to learn the FreeBSD's RSS design. I do not have hardware to test, but the change looks good to me.
Oct 22 2025
Oct 22 2025
Oct 20 2025
Oct 20 2025
zlei added inline comments to D53160: kthread: Add a wrapper macro KPROC_START.
zlei updated the diff for D53160: kthread: Add a wrapper macro KPROC_START.
pgpkeys: Extend my key's expiration dates
zlei added inline comments to D53158: linux: Make the macro LINUX_IOCTL_SET public.
zlei committed rG0a2fb63b4954: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
zlei committed rGd12ce84b0d33: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
zlei committed rGcb0116af7ac7: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
zlei committed rGff29e5bc53e6: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
zlei committed rGdb1844a0e1bc: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
zlei committed rG8350f46d9808: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
linux: Make the macro LINUX_IOCTL_SET public
Oct 18 2025
Oct 18 2025
zlei added inline comments to D53173: imgact: Mark brandinfo and note structures as const.
zlei committed rG301e6c47127d: imgact: Mark brandinfo and note structures as const (authored by zlei).
imgact: Mark brandinfo and note structures as const
zlei added inline comments to D53158: linux: Make the macro LINUX_IOCTL_SET public.
Oct 17 2025
Oct 17 2025
zlei added a comment to D53173: imgact: Mark brandinfo and note structures as const.
This is for other architectures, i386, arm, powerpc and riscv.
zlei requested review of D53173: imgact: Mark brandinfo and note structures as const.
zlei added inline comments to D53062: imgact: Mark brandinfo and note structures as const.
zlei added inline comments to D53051: Teach bridge interfaces to work with async DHCP (devd config).
zlei added a comment to D53101: lio: use newly exposed RSS hash key API rather than ad-hoc hashing.
zlei added a comment to D53101: lio: use newly exposed RSS hash key API rather than ad-hoc hashing.
I'm not getting this change. The kernel build option RSS is not enabled by default. Is this change want to enable a variant RSS when RSS is not enabled in the kernel ?
zlei added inline comments to D53160: kthread: Add a wrapper macro KPROC_START.
zlei requested review of D53160: kthread: Add a wrapper macro KPROC_START.
zlei requested review of D53158: linux: Make the macro LINUX_IOCTL_SET public.
Oct 13 2025
Oct 13 2025
zlei committed rGc8e077e57b25: x86/xen: Use proper prototype for SYSINIT functions (authored by zlei).
x86/xen: Use proper prototype for SYSINIT functions
tsc: Use proper prototype for SYSINIT functions
zlei committed rG9caa16bd0287: powerpc: Use proper prototype for SYSINIT functions (authored by zlei).
powerpc: Use proper prototype for SYSINIT functions
i386: Use proper prototype for SYSINIT functions
zlei committed rG5d5ba0c0fa9e: arm64 coresight: Use proper prototype for SYSINIT functions (authored by zlei).
arm64 coresight: Use proper prototype for SYSINIT functions
arm: Use proper prototype for SYSINIT functions
sys/sysent.h: Remove an unneeded type cast
MAC: Use proper prototype for SYSINIT functions
vm: Use proper prototype for SYSINIT functions
zlei committed rG32c1e940e07c: audit: Use proper prototype for SYSINIT functions (authored by zlei).
audit: Use proper prototype for SYSINIT functions
pf: Use proper prototype for SYSINIT functions
nfs: Use proper prototype for SYSINIT functions
ipfw: Use proper prototype for SYSINIT functions
zlei committed rG360bb45690d9: netipsec: Use proper prototype for SYSINIT functions (authored by zlei).
netipsec: Use proper prototype for SYSINIT functions
zlei committed rGd4a80fa271b1: netinet6: Use proper prototype for SYSINIT functions (authored by zlei).
netinet6: Use proper prototype for SYSINIT functions
zlei committed rG6613b6ad1ecc: netinet: Use proper prototype for SYSINIT functions (authored by zlei).
netinet: Use proper prototype for SYSINIT functions
zlei committed rG7449e59110b8: net80211: Use proper prototype for SYSINIT functions (authored by zlei).
net80211: Use proper prototype for SYSINIT functions
net: Use proper prototype for SYSINIT functions
zlei committed rG850a88e8db76: libkern: Use proper prototype for SYSINIT functions (authored by zlei).
libkern: Use proper prototype for SYSINIT functions
jail: Use proper prototype for SYSINIT functions
kern_sharedpage.c: Remove an unneeded type cast
xen: Use proper prototype for SYSINIT functions
kern: Use proper prototype for SYSINIT functions
p9fs: Use proper prototype for SYSINIT functions
xdma: Use proper prototype for SYSINIT functions
nvme: Use proper prototype for SYSINIT functions
zlei committed rG05c313cd2cbc: iommu_gas: Use proper prototype for SYSINIT functions (authored by zlei).
iommu_gas: Use proper prototype for SYSINIT functions
zlei committed rGd82653aee7e3: dev/fdt: Use proper prototype for SYSINIT functions (authored by zlei).
dev/fdt: Use proper prototype for SYSINIT functions
zlei committed rG41c0b64f021e: opensolaris: Use proper prototype for SYSINIT functions (authored by zlei).
opensolaris: Use proper prototype for SYSINIT functions
scsi: Use proper prototype for SYSINIT functions
Oct 12 2025
Oct 12 2025
zlei added inline comments to D53022: if_vxlan: fix byteorder of source port.
Oct 10 2025
Oct 10 2025
zlei added a comment to D53022: if_vxlan: fix byteorder of source port.
Looks good to me.
Oct 4 2025
Oct 4 2025
zlei committed rG8583840cfb92: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
zlei committed rGb4a079dd78a6: witness: White space cleanup and some style(9) tweeks (authored by zlei).
witness: White space cleanup and some style(9) tweeks
zlei committed rGd334e045a471: ifconfig: Fix the display of the IFCAP_MEXTPG capability (authored by zlei).
ifconfig: Fix the display of the IFCAP_MEXTPG capability
ifconfig: Display the IFCAP_HWSTATS capability
zlei committed rG22f26eb3b897: ifconfig: Garbage collect unused parameter swabips (authored by zlei).
ifconfig: Garbage collect unused parameter swabips
tcp: Add CTLFLAG_VNET flag to some sysctls
zlei committed rG4b92e54c9b5a: tcp: Fix expiring and purging hostcache entries of vnet jails (authored by zlei).
tcp: Fix expiring and purging hostcache entries of vnet jails
zlei committed rGd59a8f27fc07: tslog: Move sysinit_tslog_shim() into kern_tslog.c (authored by zlei).
tslog: Move sysinit_tslog_shim() into kern_tslog.c
qlnxe: Report speeds in decimal format
qlnxe: Support SIOCGIFXMEDIA ioctl
zlei committed rG49fbc8dcf77d: qlnxe: Unconditionally enable extended media types (authored by zlei).
qlnxe: Unconditionally enable extended media types
zlei committed rGad08006c7fd5: qlnxe: Fix advertising the IFCAP_LINKSTATE capability (authored by zlei).
qlnxe: Fix advertising the IFCAP_LINKSTATE capability
zlei committed rG4dc6c65704de: init_main: Fix logging the subsystem of pre-loaded kernel modules (authored by zlei).
init_main: Fix logging the subsystem of pre-loaded kernel modules
zlei committed rG1a9f9b4e38c3: ipfw: Teach ipfw that EtherIP is an upper layer protocol (authored by zlei).
ipfw: Teach ipfw that EtherIP is an upper layer protocol
zlei committed rG7cbb184bbfa3: gif.4: Mention that gif(4) can tunnel Ethernet traffic (authored by zlei).
gif.4: Mention that gif(4) can tunnel Ethernet traffic
zlei committed rG6e605ed6df40: EtherIP: Fix passing the address family from if_bridge(4) to gif(4) (authored by zlei).
EtherIP: Fix passing the address family from if_bridge(4) to gif(4)
zlei committed rGa3fbecac6879: tests: gif(4): Add regression tests for setup with EtherIP (authored by zlei).
tests: gif(4): Add regression tests for setup with EtherIP
zlei committed rG767db004475a: tests: gif(4): Add tests to cover all IPv[46] in IPv[46] setups (authored by zlei).
tests: gif(4): Add tests to cover all IPv[46] in IPv[46] setups
zlei added a comment to D52852: vxlan: support moving to a different vnet.
I've ever considered this approach, but this adds too many headaches. Well I'd propose to use vlxan(4) + bridge(4) + epair(4) if the underlay network is in different VNET.
Oct 3 2025
Oct 3 2025
Looks good to me.
Oct 1 2025
Oct 1 2025
zlei committed rG7838ad85fb1a: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
zlei committed rG3dc9f96a489c: witness: Record the first acquired file and line for recursable locks (authored by zlei).
witness: Record the first acquired file and line for recursable locks
Sep 29 2025
Sep 29 2025
This generally looks good to me.
Sep 27 2025
Sep 27 2025
zlei committed rG9ed73bd78c78: Migrate from printb to print_bits for locally defined bit fields. (authored by gordon).
Migrate from printb to print_bits for locally defined bit fields.
zlei committed rGac91312f28a9: Move print_bits to ifconfig.c and make available to other src files. (authored by gordon).
Move print_bits to ifconfig.c and make available to other src files.
tcp: Add CTLFLAG_VNET flag to some sysctls