Page MenuHomeFreeBSD
People zlei

zlei (Zhenlei Huang)
User

Projects

User Details

User Since
Apr 1 2021, 3:21 AM (255 w, 2 d)

Recent Activity
View All

Yesterday

zlei added a comment to D55398: if_gre: make access to softc's data safe in network epoch.

Ahh, I think I see what's happening. While some time ago I was trying to diagnose PR 275474, I observed UAF and got messed up in mind.

Fri, Feb 20, 6:59 PM

Thu, Feb 19

zlei accepted D55367: icmp6: Remove csum_flags on mbuf reused for ICMP message.

Looks good to me.

Thu, Feb 19, 2:09 PM

Mon, Feb 16

zlei committed rGfe1299f16c55: lagg: Avoid dropping locks when starting the interface (authored by zlei).
lagg: Avoid dropping locks when starting the interface
Mon, Feb 16, 10:01 AM
zlei committed rG6ceb731a9897: lagg: Make lagg_link_active() static (authored by zlei).
lagg: Make lagg_link_active() static
Mon, Feb 16, 10:01 AM

Fri, Feb 13

zlei accepted D55236: ip_mroute: Make the routing socket private.

Looks good!

Fri, Feb 13, 11:28 AM

Thu, Feb 12

zlei accepted D55259: ngctl: Fix buffer overflow in config command.

Solid fix !

Thu, Feb 12, 3:24 PM

Wed, Feb 11

zlei committed rGc182cf646a4f: lagg: Avoid dropping locks when starting the interface (authored by zlei).
lagg: Avoid dropping locks when starting the interface
Wed, Feb 11, 6:17 PM
zlei closed D55198: lagg: Avoid dropping locks when starting the interface.
Wed, Feb 11, 6:17 PM
zlei added a comment to D55198: lagg: Avoid dropping locks when starting the interface.
In D55198#1262845, @markj wrote:

The init routine of a lagg(4) interface will not change during the whole lifecycle. So we can call lagg_init() directly instead of through the function pointer.

I just want to note that this logic does not generalize everywhere. e.g., netmap will sneakily override the I/O routines in an ifnet in some cases. It does not touch if_init, so this particular case is ok.

Wed, Feb 11, 5:41 PM
zlei added a reverting change for rG8a847947153e: sys/modules: fix standalone build for multiple modules: rGe1a051fd53a0: qlnxev: Remove now unneeded include for opt_inet.h.
Wed, Feb 11, 1:50 PM
zlei committed rG87942d7f8fc5: qlnxe: Overhaul setting the multicast MAC filters (authored by zlei).
qlnxe: Overhaul setting the multicast MAC filters
Wed, Feb 11, 1:50 PM
zlei committed rGddfe98e8ccb1: qlnxe: Allow tapping the TX packets (authored by zlei).
qlnxe: Allow tapping the TX packets
Wed, Feb 11, 1:50 PM
zlei committed rG00ab0df79364: qlnxe: Refactor setting the promiscuous and allmulti mode (authored by zlei).
qlnxe: Refactor setting the promiscuous and allmulti mode
Wed, Feb 11, 1:49 PM
zlei committed rGe1a051fd53a0: qlnxev: Remove now unneeded include for opt_inet.h (authored by zlei).
qlnxev: Remove now unneeded include for opt_inet.h
Wed, Feb 11, 1:49 PM
zlei committed rG20ffe22fcfe1: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl (authored by zlei).
qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Wed, Feb 11, 1:49 PM
zlei committed rGee6495580925: qlnxe: Avoid reinitializing the interface when it is already initialized (authored by zlei).
qlnxe: Avoid reinitializing the interface when it is already initialized
Wed, Feb 11, 1:49 PM
zlei committed rG6e5b12acb66a: qlnxe: Prevent potential concurrency between ioctls (authored by zlei).
qlnxe: Prevent potential concurrency between ioctls
Wed, Feb 11, 1:49 PM
zlei committed rG93719f8c8348: qlnxe: Fix setting the unicast MAC filter of RX path (authored by zlei).
qlnxe: Fix setting the unicast MAC filter of RX path
Wed, Feb 11, 1:49 PM
zlei added a reverting change for D52062: sys/modules: fix standalone build for multiple build: rGe1a051fd53a0: qlnxev: Remove now unneeded include for opt_inet.h.
Wed, Feb 11, 1:49 PM
zlei committed rG7d7cee09b9a4: qlnxe: Remove a pointless copy back from the link-layer address (authored by zlei).
qlnxe: Remove a pointless copy back from the link-layer address
Wed, Feb 11, 1:49 PM
zlei committed rGea1143bddbc3: qlnxe: Avoid memcpy with same source and destination (authored by zlei).
qlnxe: Avoid memcpy with same source and destination
Wed, Feb 11, 1:49 PM
zlei added a reverting change for rG8a847947153e: sys/modules: fix standalone build for multiple modules: rG926e44b49834: qlnxev: Remove now unneeded include for opt_inet.h.
Wed, Feb 11, 10:04 AM
zlei committed rG0233e3f8953b: lagg: Remove the member pr_num from struct lagg_proto (authored by zlei).
lagg: Remove the member pr_num from struct lagg_proto
Wed, Feb 11, 10:04 AM
zlei committed rG0cfc1145cdfc: qlnxe: Overhaul setting the multicast MAC filters (authored by zlei).
qlnxe: Overhaul setting the multicast MAC filters
Wed, Feb 11, 10:04 AM
zlei committed rG18c70c737cb3: lagg: Make the none protocol a first-class citizen (authored by zlei).
lagg: Make the none protocol a first-class citizen
Wed, Feb 11, 10:04 AM
zlei committed rG425b9cec0b8c: qlnxe: Allow tapping the TX packets (authored by zlei).
qlnxe: Allow tapping the TX packets
Wed, Feb 11, 10:04 AM
zlei committed rGb8d2c1c36746: qlnxe: Refactor setting the promiscuous and allmulti mode (authored by zlei).
qlnxe: Refactor setting the promiscuous and allmulti mode
Wed, Feb 11, 10:04 AM
zlei committed rG926e44b49834: qlnxev: Remove now unneeded include for opt_inet.h (authored by zlei).
qlnxev: Remove now unneeded include for opt_inet.h
Wed, Feb 11, 10:04 AM
zlei committed rG0f383f74b739: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl (authored by zlei).
qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Wed, Feb 11, 10:03 AM
zlei committed rG8731ff4871d5: qlnxe: Avoid reinitializing the interface when it is already initialized (authored by zlei).
qlnxe: Avoid reinitializing the interface when it is already initialized
Wed, Feb 11, 10:03 AM
zlei committed rG285b25c080fa: qlnxe: Prevent potential concurrency between ioctls (authored by zlei).
qlnxe: Prevent potential concurrency between ioctls
Wed, Feb 11, 10:03 AM
zlei committed rG6d138e958ffb: qlnxe: Fix setting the unicast MAC filter of RX path (authored by zlei).
qlnxe: Fix setting the unicast MAC filter of RX path
Wed, Feb 11, 10:03 AM
zlei committed rG646218959504: qlnxe: Avoid memcpy with same source and destination (authored by zlei).
qlnxe: Avoid memcpy with same source and destination
Wed, Feb 11, 10:03 AM
zlei added a reverting change for D52062: sys/modules: fix standalone build for multiple build: rG926e44b49834: qlnxev: Remove now unneeded include for opt_inet.h.
Wed, Feb 11, 10:03 AM
zlei committed rG23ffd1650cc4: qlnxe: Remove a pointless copy back from the link-layer address (authored by zlei).
qlnxe: Remove a pointless copy back from the link-layer address
Wed, Feb 11, 10:03 AM
zlei added inline comments to D55236: ip_mroute: Make the routing socket private.
Wed, Feb 11, 2:33 AM
zlei updated subscribers of D55203: svc_vc.c: Add support for an xp_extpg boolean.
Wed, Feb 11, 1:58 AM
zlei accepted D54972: atf_python/vnet: Make it possible to set the FIB of vnet interfaces.

Looks good to me.

Wed, Feb 11, 1:22 AM

Tue, Feb 10

zlei added inline comments to D54972: atf_python/vnet: Make it possible to set the FIB of vnet interfaces.
Tue, Feb 10, 6:12 PM
zlei added inline comments to D54972: atf_python/vnet: Make it possible to set the FIB of vnet interfaces.
Tue, Feb 10, 5:41 PM
zlei added a comment to D55203: svc_vc.c: Add support for an xp_extpg boolean.
Tue, Feb 10, 10:11 AM

Mon, Feb 9

zlei requested review of D55198: lagg: Avoid dropping locks when starting the interface.
Mon, Feb 9, 6:34 PM
zlei accepted D55138: Switch net.inet6.ip6.use_stableaddr to on by default.
Mon, Feb 9, 6:32 PM
zlei committed rG30988d0a7bd7: lagg: Make lagg_link_active() static (authored by zlei).
lagg: Make lagg_link_active() static
Mon, Feb 9, 5:50 PM

Sun, Feb 8

zlei added inline comments to D55138: Switch net.inet6.ip6.use_stableaddr to on by default.
Sun, Feb 8, 5:19 AM
zlei accepted D55171: net: Remove the IFF_RENAMING flag.

Looks good to me.

Sun, Feb 8, 5:00 AM

Sat, Feb 7

zlei added a comment to D54443: if_gre: Add netlink support with tests.

Except for the tests, do you have real usage of the netlink protocol ? The commit message does not mention it. So it is better to explain, otherwise would confuse people.

Sat, Feb 7, 4:03 PM

Fri, Feb 6

zlei accepted D55138: Switch net.inet6.ip6.use_stableaddr to on by default.

This is a behavior change. Please also add a meta Relnotes: yes to the commit message.

Fri, Feb 6, 7:34 PM
zlei closed D54892: qlnxe: Overhaul setting the multicast MAC filters.
Fri, Feb 6, 6:05 PM
zlei closed D54891: qlnxe: Allow tapping the tx packets.
Fri, Feb 6, 6:01 PM
zlei closed D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.
Fri, Feb 6, 6:01 PM
zlei closed D54885: qlnxe: Fix setting unicast MAC filter of rx path.
Fri, Feb 6, 6:01 PM
zlei added a reverting change for rG8a847947153e: sys/modules: fix standalone build for multiple modules: rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h.
Fri, Feb 6, 6:01 PM
zlei closed D54883: qlnxe: Remove a pointless copy back from the link-layer address.
Fri, Feb 6, 6:00 PM
zlei committed rG70256d2b86d9: qlnxe: Overhaul setting the multicast MAC filters (authored by zlei).
qlnxe: Overhaul setting the multicast MAC filters
Fri, Feb 6, 6:00 PM
zlei committed rG45b1718fadae: qlnxe: Refactor setting the promiscuous and allmulti mode (authored by zlei).
qlnxe: Refactor setting the promiscuous and allmulti mode
Fri, Feb 6, 6:00 PM
zlei committed rG968647502ec2: qlnxe: Allow tapping the TX packets (authored by zlei).
qlnxe: Allow tapping the TX packets
Fri, Feb 6, 6:00 PM
zlei committed rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h (authored by zlei).
qlnxev: Remove now unneeded include for opt_inet.h
Fri, Feb 6, 6:00 PM
zlei committed rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl (authored by zlei).
qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Fri, Feb 6, 6:00 PM
zlei closed D54889: qlnxev: Remove now unneeded include for opt_inet.h.
Fri, Feb 6, 6:00 PM
zlei committed rGc10e6bc0f007: qlnxe: Avoid reinitializing the interface when it is already initialized (authored by zlei).
qlnxe: Avoid reinitializing the interface when it is already initialized
Fri, Feb 6, 6:00 PM
zlei closed D54890: qlnxe: Refactor setting the promiscuous and allmulti mode.
Fri, Feb 6, 6:00 PM
zlei committed rG0df8a998a9fe: qlnxe: Prevent potential concurrency between ioctls (authored by zlei).
qlnxe: Prevent potential concurrency between ioctls
Fri, Feb 6, 6:00 PM
zlei committed rGf250852c9a0c: qlnxe: Fix setting the unicast MAC filter of RX path (authored by zlei).
qlnxe: Fix setting the unicast MAC filter of RX path
Fri, Feb 6, 6:00 PM
zlei added a reverting change for D52062: sys/modules: fix standalone build for multiple build: rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h.
Fri, Feb 6, 6:00 PM
zlei closed D54888: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.
Fri, Feb 6, 6:00 PM
zlei committed rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination (authored by zlei).
qlnxe: Avoid memcpy with same source and destination
Fri, Feb 6, 6:00 PM
zlei closed D54886: qlnxe: Prevent potential concurrency between ioctls.
Fri, Feb 6, 6:00 PM
zlei committed rG4ac3081b2828: qlnxe: Remove a pointless copy back from the link-layer address (authored by zlei).
qlnxe: Remove a pointless copy back from the link-layer address
Fri, Feb 6, 6:00 PM
zlei closed D54884: qlnxe: Avoid memcpy with same source and destination.
Fri, Feb 6, 6:00 PM
zlei added a comment to D54892: qlnxe: Overhaul setting the multicast MAC filters.
In D54892#1260605, @kbowling wrote:

Seems fine, assuming you have check the hw filter table size(s)

Fri, Feb 6, 9:54 AM
zlei added a comment to D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.
In D54887#1260593, @kbowling wrote:

Light ack as the two init functions seem fine but I have not looked through the entirety to see if there was some reason for stopping the MAC (rdma?) and you should probably look at all the leafs of qlnx_load especially filter setup.

Fri, Feb 6, 9:27 AM
zlei added inline comments to D54884: qlnxe: Avoid memcpy with same source and destination.
Fri, Feb 6, 7:28 AM
zlei committed rG5ba503fc2cab: lagg: Remove the member pr_num from struct lagg_proto (authored by zlei).
lagg: Remove the member pr_num from struct lagg_proto
Fri, Feb 6, 3:39 AM
zlei committed rGa622030b4bae: lagg: Make the none protocol a first-class citizen (authored by zlei).
lagg: Make the none protocol a first-class citizen
Fri, Feb 6, 3:39 AM
zlei closed D55124: lagg: Remove the member pr_num from struct lagg_proto.
Fri, Feb 6, 3:39 AM
zlei closed D55123: lagg: Makes the none protocol a first-class citizen.
Fri, Feb 6, 3:39 AM

Thu, Feb 5

zlei committed rG0e82cd099e2a: ifconfig: fix removing IPv6 addresses (authored by kp).
ifconfig: fix removing IPv6 addresses
Thu, Feb 5, 6:13 PM
zlei committed rG52ebb8a7d4f8: ifconfig: fix 'ifconfig -l link' (authored by glebius).
ifconfig: fix 'ifconfig -l link'
Thu, Feb 5, 6:13 PM
zlei committed rG151dcad51394: ifconfig: fix 'ifconfig -l ether' (authored by glebius).
ifconfig: fix 'ifconfig -l ether'
Thu, Feb 5, 6:13 PM
zlei committed rG7bdf066ad212: ifconfig: fix logical error in interface matching for '-l ether' (authored by glebius).
ifconfig: fix logical error in interface matching for '-l ether'
Thu, Feb 5, 6:13 PM
zlei updated the diff for D55124: lagg: Remove the member pr_num from struct lagg_proto.

Rebased on to latest D55123 (Added a missing comma).

Thu, Feb 5, 4:51 PM
zlei updated the diff for D55123: lagg: Makes the none protocol a first-class citizen.

Fix compiling. Added a missing comma.

Thu, Feb 5, 4:49 PM
zlei committed rGb562bbc06adf: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Thu, Feb 5, 5:31 AM
zlei requested review of D55124: lagg: Remove the member pr_num from struct lagg_proto.
Thu, Feb 5, 5:22 AM
zlei requested review of D55123: lagg: Makes the none protocol a first-class citizen.
Thu, Feb 5, 5:21 AM
zlei committed rG3cfe90545f01: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Thu, Feb 5, 5:16 AM
zlei committed rG8880678b7a47: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Thu, Feb 5, 5:14 AM

Wed, Feb 4

zlei accepted D55099: ifconfig: fix gre(4) status.

Looks good to me.

Wed, Feb 4, 2:48 PM

Tue, Feb 3

zlei added a comment to D55064: bpf: don't clear pointer from descriptor to the tap on descriptor close.

Is bpf_chkdir() dereferencing a NULL d->bd_bif in net epoch ?

Tue, Feb 3, 3:15 AM

Mon, Feb 2

zlei committed rG04911babef1b: netgraph: teach ngctl to attach and run itself in a jail (authored by jamie).
netgraph: teach ngctl to attach and run itself in a jail
Mon, Feb 2, 5:26 PM
zlei committed rG7621b6eded12: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG44dfede815d8: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG9280324325f3: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG352c1e0f172a: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rGd6bc614eac5a: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rGe36e17552cdf: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG5004b384a657: linux: Make the macro LINUX_IOCTL_SET public (authored by zlei).
linux: Make the macro LINUX_IOCTL_SET public
Mon, Feb 2, 5:25 PM
zlei closed D54973: e1000: Fix setting the promiscuous mode.
Mon, Feb 2, 12:30 PM
zlei committed rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Mon, Feb 2, 12:29 PM