Page MenuHomeFreeBSD
People zlei

zlei (Zhenlei Huang)
User

Projects

User Details

User Since
Apr 1 2021, 3:21 AM (253 w, 5 d)

Recent Activity
View All

Yesterday

zlei requested review of D55198: lagg: Avoid dropping locks when starting the interface.
Mon, Feb 9, 6:34 PM
zlei accepted D55138: Switch net.inet6.ip6.use_stableaddr to on by default.
Mon, Feb 9, 6:32 PM
zlei committed rG30988d0a7bd7: lagg: Make lagg_link_active() static (authored by zlei).
lagg: Make lagg_link_active() static
Mon, Feb 9, 5:50 PM

Sun, Feb 8

zlei added inline comments to D55138: Switch net.inet6.ip6.use_stableaddr to on by default.
Sun, Feb 8, 5:19 AM
zlei accepted D55171: net: Remove the IFF_RENAMING flag.

Looks good to me.

Sun, Feb 8, 5:00 AM

Sat, Feb 7

zlei added a comment to D54443: if_gre: Add netlink support with tests.

Except for the tests, do you have real usage of the netlink protocol ? The commit message does not mention it. So it is better to explain, otherwise would confuse people.

Sat, Feb 7, 4:03 PM

Fri, Feb 6

zlei accepted D55138: Switch net.inet6.ip6.use_stableaddr to on by default.

This is a behavior change. Please also add a meta Relnotes: yes to the commit message.

Fri, Feb 6, 7:34 PM
zlei closed D54892: qlnxe: Overhaul setting the multicast MAC filters.
Fri, Feb 6, 6:05 PM
zlei closed D54891: qlnxe: Allow tapping the tx packets.
Fri, Feb 6, 6:01 PM
zlei closed D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.
Fri, Feb 6, 6:01 PM
zlei closed D54885: qlnxe: Fix setting unicast MAC filter of rx path.
Fri, Feb 6, 6:01 PM
zlei added a reverting change for rG8a847947153e: sys/modules: fix standalone build for multiple modules: rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h.
Fri, Feb 6, 6:01 PM
zlei closed D54883: qlnxe: Remove a pointless copy back from the link-layer address.
Fri, Feb 6, 6:00 PM
zlei committed rG70256d2b86d9: qlnxe: Overhaul setting the multicast MAC filters (authored by zlei).
qlnxe: Overhaul setting the multicast MAC filters
Fri, Feb 6, 6:00 PM
zlei committed rG45b1718fadae: qlnxe: Refactor setting the promiscuous and allmulti mode (authored by zlei).
qlnxe: Refactor setting the promiscuous and allmulti mode
Fri, Feb 6, 6:00 PM
zlei committed rG968647502ec2: qlnxe: Allow tapping the TX packets (authored by zlei).
qlnxe: Allow tapping the TX packets
Fri, Feb 6, 6:00 PM
zlei committed rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h (authored by zlei).
qlnxev: Remove now unneeded include for opt_inet.h
Fri, Feb 6, 6:00 PM
zlei committed rG4012b63889e4: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl (authored by zlei).
qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl
Fri, Feb 6, 6:00 PM
zlei closed D54889: qlnxev: Remove now unneeded include for opt_inet.h.
Fri, Feb 6, 6:00 PM
zlei committed rGc10e6bc0f007: qlnxe: Avoid reinitializing the interface when it is already initialized (authored by zlei).
qlnxe: Avoid reinitializing the interface when it is already initialized
Fri, Feb 6, 6:00 PM
zlei closed D54890: qlnxe: Refactor setting the promiscuous and allmulti mode.
Fri, Feb 6, 6:00 PM
zlei committed rG0df8a998a9fe: qlnxe: Prevent potential concurrency between ioctls (authored by zlei).
qlnxe: Prevent potential concurrency between ioctls
Fri, Feb 6, 6:00 PM
zlei committed rGf250852c9a0c: qlnxe: Fix setting the unicast MAC filter of RX path (authored by zlei).
qlnxe: Fix setting the unicast MAC filter of RX path
Fri, Feb 6, 6:00 PM
zlei added a reverting change for D52062: sys/modules: fix standalone build for multiple build: rGec7950fe4234: qlnxev: Remove now unneeded include for opt_inet.h.
Fri, Feb 6, 6:00 PM
zlei closed D54888: qlnxe: Let ether_ioctl() handle SIOCSIFADDR ioctl.
Fri, Feb 6, 6:00 PM
zlei committed rG3aeeedc7e0dc: qlnxe: Avoid memcpy with same source and destination (authored by zlei).
qlnxe: Avoid memcpy with same source and destination
Fri, Feb 6, 6:00 PM
zlei closed D54886: qlnxe: Prevent potential concurrency between ioctls.
Fri, Feb 6, 6:00 PM
zlei committed rG4ac3081b2828: qlnxe: Remove a pointless copy back from the link-layer address (authored by zlei).
qlnxe: Remove a pointless copy back from the link-layer address
Fri, Feb 6, 6:00 PM
zlei closed D54884: qlnxe: Avoid memcpy with same source and destination.
Fri, Feb 6, 6:00 PM
zlei added a comment to D54892: qlnxe: Overhaul setting the multicast MAC filters.
In D54892#1260605, @kbowling wrote:

Seems fine, assuming you have check the hw filter table size(s)

Fri, Feb 6, 9:54 AM
zlei added a comment to D54887: qlnxe: Avoid reinitializing the interface when it is already initialized.
In D54887#1260593, @kbowling wrote:

Light ack as the two init functions seem fine but I have not looked through the entirety to see if there was some reason for stopping the MAC (rdma?) and you should probably look at all the leafs of qlnx_load especially filter setup.

Fri, Feb 6, 9:27 AM
zlei added inline comments to D54884: qlnxe: Avoid memcpy with same source and destination.
Fri, Feb 6, 7:28 AM
zlei committed rG5ba503fc2cab: lagg: Remove the member pr_num from struct lagg_proto (authored by zlei).
lagg: Remove the member pr_num from struct lagg_proto
Fri, Feb 6, 3:39 AM
zlei committed rGa622030b4bae: lagg: Make the none protocol a first-class citizen (authored by zlei).
lagg: Make the none protocol a first-class citizen
Fri, Feb 6, 3:39 AM
zlei closed D55124: lagg: Remove the member pr_num from struct lagg_proto.
Fri, Feb 6, 3:39 AM
zlei closed D55123: lagg: Makes the none protocol a first-class citizen.
Fri, Feb 6, 3:39 AM

Thu, Feb 5

zlei committed rG0e82cd099e2a: ifconfig: fix removing IPv6 addresses (authored by kp).
ifconfig: fix removing IPv6 addresses
Thu, Feb 5, 6:13 PM
zlei committed rG52ebb8a7d4f8: ifconfig: fix 'ifconfig -l link' (authored by glebius).
ifconfig: fix 'ifconfig -l link'
Thu, Feb 5, 6:13 PM
zlei committed rG151dcad51394: ifconfig: fix 'ifconfig -l ether' (authored by glebius).
ifconfig: fix 'ifconfig -l ether'
Thu, Feb 5, 6:13 PM
zlei committed rG7bdf066ad212: ifconfig: fix logical error in interface matching for '-l ether' (authored by glebius).
ifconfig: fix logical error in interface matching for '-l ether'
Thu, Feb 5, 6:13 PM
zlei updated the diff for D55124: lagg: Remove the member pr_num from struct lagg_proto.

Rebased on to latest D55123 (Added a missing comma).

Thu, Feb 5, 4:51 PM
zlei updated the diff for D55123: lagg: Makes the none protocol a first-class citizen.

Fix compiling. Added a missing comma.

Thu, Feb 5, 4:49 PM
zlei committed rGb562bbc06adf: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Thu, Feb 5, 5:31 AM
zlei requested review of D55124: lagg: Remove the member pr_num from struct lagg_proto.
Thu, Feb 5, 5:22 AM
zlei requested review of D55123: lagg: Makes the none protocol a first-class citizen.
Thu, Feb 5, 5:21 AM
zlei committed rG3cfe90545f01: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Thu, Feb 5, 5:16 AM
zlei committed rG8880678b7a47: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Thu, Feb 5, 5:14 AM

Wed, Feb 4

zlei accepted D55099: ifconfig: fix gre(4) status.

Looks good to me.

Wed, Feb 4, 2:48 PM

Tue, Feb 3

zlei added a comment to D55064: bpf: don't clear pointer from descriptor to the tap on descriptor close.

Is bpf_chkdir() dereferencing a NULL d->bd_bif in net epoch ?

Tue, Feb 3, 3:15 AM

Mon, Feb 2

zlei committed rG04911babef1b: netgraph: teach ngctl to attach and run itself in a jail (authored by jamie).
netgraph: teach ngctl to attach and run itself in a jail
Mon, Feb 2, 5:26 PM
zlei committed rG7621b6eded12: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG44dfede815d8: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG9280324325f3: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG352c1e0f172a: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rGd6bc614eac5a: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rGe36e17552cdf: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler (authored by zlei).
sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
Mon, Feb 2, 5:25 PM
zlei committed rG5004b384a657: linux: Make the macro LINUX_IOCTL_SET public (authored by zlei).
linux: Make the macro LINUX_IOCTL_SET public
Mon, Feb 2, 5:25 PM
zlei closed D54973: e1000: Fix setting the promiscuous mode.
Mon, Feb 2, 12:30 PM
zlei committed rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode (authored by zlei).
e1000: Fix setting the promiscuous mode
Mon, Feb 2, 12:29 PM
zlei accepted D55014: EVENTHANDLER.9: EVENTHANDLER_REGISTER never fails.
In D55014#1257473, @ziaee wrote:

Since ecdf4409f910

Please use a Fixes: trailer for that, it keeps them together for this type of situation is a standardized way. I also have a vague recollection someone built some tooling around it.

Mon, Feb 2, 11:44 AM

Sun, Feb 1

zlei added a comment to D54443: if_gre: Add netlink support with tests.

There're three tasks in this change,

Sun, Feb 1, 11:41 AM

Sat, Jan 31

zlei committed rGab6366972662: sys/net/sff8436.h: Fix the register address of link length of copper or active… (authored by Kirill Kochnev <sabashlive@gmail.com>).
sys/net/sff8436.h: Fix the register address of link length of copper or active…
Sat, Jan 31, 6:44 PM
zlei committed rGf119719571b8: lio: Avoid out-of-bounds read or write MAC address (authored by zlei).
lio: Avoid out-of-bounds read or write MAC address
Sat, Jan 31, 6:44 PM
zlei committed rG37de97853422: qlnxe: Avoid out-of-bounds reading the multicast ethernet address (authored by zlei).
qlnxe: Avoid out-of-bounds reading the multicast ethernet address
Sat, Jan 31, 6:44 PM
zlei committed rG58cf2a284053: sys/net/sff8436.h: Fix the register address of link length of copper or active… (authored by Kirill Kochnev <sabashlive@gmail.com>).
sys/net/sff8436.h: Fix the register address of link length of copper or active…
Sat, Jan 31, 6:31 PM
zlei committed rGa1828b1226fe: qlnxe: Avoid out-of-bounds reading the multicast ethernet address (authored by zlei).
qlnxe: Avoid out-of-bounds reading the multicast ethernet address
Sat, Jan 31, 6:31 PM
zlei committed rGc4e33387d079: locking.9: Tweak the table column width to fit 80 characters (authored by zlei).
locking.9: Tweak the table column width to fit 80 characters
Sat, Jan 31, 6:31 PM
zlei committed rGe8de565f6bb8: lio: Avoid out-of-bounds read or write MAC address (authored by zlei).
lio: Avoid out-of-bounds read or write MAC address
Sat, Jan 31, 6:31 PM
zlei committed rGd88ccbddc7c7: x86/xen: Use proper prototype for SYSINIT functions (authored by zlei).
x86/xen: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rGdb22431755f7: tsc: Use proper prototype for SYSINIT functions (authored by zlei).
tsc: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rGdb80c0726789: powerpc: Use proper prototype for SYSINIT functions (authored by zlei).
powerpc: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rG8b07da3ba41d: i386: Use proper prototype for SYSINIT functions (authored by zlei).
i386: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rG13a9caf59ac3: arm64 coresight: Use proper prototype for SYSINIT functions (authored by zlei).
arm64 coresight: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rG9ddec7bde2b1: arm: Use proper prototype for SYSINIT functions (authored by zlei).
arm: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rG2a87a2c911e1: vm: Use proper prototype for SYSINIT functions (authored by zlei).
vm: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:31 PM
zlei committed rG8f6cd5b69a10: sys/sysent.h: Remove an unneeded type cast (authored by zlei).
sys/sysent.h: Remove an unneeded type cast
Sat, Jan 31, 6:31 PM
zlei committed rGbddd70611a0f: MAC: Use proper prototype for SYSINIT functions (authored by zlei).
MAC: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG139a9451b910: audit: Use proper prototype for SYSINIT functions (authored by zlei).
audit: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG01af376bd00c: nfs: Use proper prototype for SYSINIT functions (authored by zlei).
nfs: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rGa60c8710de4f: pf: Use proper prototype for SYSINIT functions (authored by zlei).
pf: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG846393be8cf8: ipfw: Use proper prototype for SYSINIT functions (authored by zlei).
ipfw: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rGdb75edf2b61e: netipsec: Use proper prototype for SYSINIT functions (authored by zlei).
netipsec: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG0871d691e389: netinet6: Use proper prototype for SYSINIT functions (authored by zlei).
netinet6: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG72bf99e08bea: netinet: Use proper prototype for SYSINIT functions (authored by zlei).
netinet: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rGa7334aec0762: net80211: Use proper prototype for SYSINIT functions (authored by zlei).
net80211: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rGea3567e3bf79: net: Use proper prototype for SYSINIT functions (authored by zlei).
net: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG5d1cf19810bb: libkern: Use proper prototype for SYSINIT functions (authored by zlei).
libkern: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:30 PM
zlei committed rG5f6c2ab28f6c: jail: Use proper prototype for SYSINIT functions (authored by zlei).
jail: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rGcc6e89374552: kern_sharedpage.c: Remove an unneeded type cast (authored by zlei).
kern_sharedpage.c: Remove an unneeded type cast
Sat, Jan 31, 6:29 PM
zlei committed rGbec38564142e: kern: Use proper prototype for SYSINIT functions (authored by zlei).
kern: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rG70150f0cb7b2: p9fs: Use proper prototype for SYSINIT functions (authored by zlei).
p9fs: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rG65b07ecacc58: xen: Use proper prototype for SYSINIT functions (authored by zlei).
xen: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rGf67ece8b30cf: xdma: Use proper prototype for SYSINIT functions (authored by zlei).
xdma: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rG3b697f765d11: nvme: Use proper prototype for SYSINIT functions (authored by zlei).
nvme: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rG8c800d39080a: iommu_gas: Use proper prototype for SYSINIT functions (authored by zlei).
iommu_gas: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:29 PM
zlei committed rGe40461251825: dev/fdt: Use proper prototype for SYSINIT functions (authored by zlei).
dev/fdt: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:28 PM
zlei committed rG93da73e85a71: opensolaris: Use proper prototype for SYSINIT functions (authored by zlei).
opensolaris: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:28 PM
zlei committed rGa0d353904a7e: scsi: Use proper prototype for SYSINIT functions (authored by zlei).
scsi: Use proper prototype for SYSINIT functions
Sat, Jan 31, 6:28 PM
zlei committed rG2b01cc154472: qlnxe: Avoid out-of-bounds reading the multicast ethernet address (authored by zlei).
qlnxe: Avoid out-of-bounds reading the multicast ethernet address
Sat, Jan 31, 5:10 PM
zlei committed rG087e77b52399: linux: Make the macro LINUX_IOCTL_SET public (authored by zlei).
linux: Make the macro LINUX_IOCTL_SET public
Sat, Jan 31, 5:10 PM