In D49201#1124014, @jilles wrote:

Hmm, so we are moving more in the direction of bash. Traditionally, this resulted in some objections on the mailing lists but perhaps opinions have changed.

In D49201#1122784, @jilles wrote:

This adds a non-POSIX feature (although it is pretty common); is the goal to make sh a mostly feature-complete alternative to bash?

I'm in favor of this change, but the previous version is OK too.

Give up on the idea of providing both humanized and dehumanized numbers.

Try to address comments from jhb.

In D48329#1103367, @emaste wrote:

It seems reasonable to me to switch to (rather than add) the humanized form for -h which is what's already done for the files in the list. "xMB in y blocks" also gives me the impression that we're presenting two different quantities (e.g. that 1M could be in some arbitrary number of blocks) - it would probably make more sense to show it as "total %s (%lu blocks)" if keeping both.

In D48329#1103326, @olce wrote:

Just as a data point, GNU ls doesn't print the number of blocks with -h. Which doesn't mean it is bad to print it, especially given that scripts should not use -h. No personal preference here.

In D48329#1103323, @emaste wrote:

I agree with @phk that this was probably an oversight. I'm not sure I'd include blocks under -h -- why not just total 268503 without -h and total 131M with -h?

When I imported mmencode, its usage was already established to be mmencode [-u] [-q] [-b] [-p] [-o outputfile] [file name] and has been for probably decades.
I have no opinion on what it should be, just giving historical context here.

I haven't tested this, but it LGTM in principle.

This is for compatibility with GNU ls, where this is an equally long option.
We already distribute a system where ls is an alias.

Scripts shouldn't be using -h.

In D46321#1056465, @emaste wrote:

In D46321#1056451, @pstef wrote:

https://reviews.freebsd.org/P645 is a diff that teaches libedit how to parse it, by the way.

That change LGTM if you want to commit it.

I believe the problem was introduced in 5fe973734866 or ef0d94a3d34c where ^[[A is introduced. I think libedit doesn't have the code to parse that properly. Fortunately it can be replaced with \e.

I'd say that we shouldn't make any recommendations on how to use parts of a language in our manual. We should instead focus on facts, list them all and describe as they are. If there is some kind of interaction between parts of the language that is possibly counter-intuitive then we can and probably should indicate directly or indirectly that something requires consideration, but at the same time we should keep the manual free of judgement.

@jhb do you think the following is related?

Already committed.

FWIW, Chromium also complains about the lack of kcmp.

I'm not sure about how useful this is to me. I use ifconfig to take a glance at all interfaces and if I want to learn more specifically about the state of the wg interface, I just run wg. I know it's obvious, I just mean that I never missed this information when looking at ifconfig output. On the other hand, with this patch, the output is longer and somewhat less readable.

Thanks for the information and apologies for the mess.
For me the case where the filesystem name was wrong and mount complained about file not existing was more common and more annoying since it was easy to see that the designated mount point clearly existed.

What are the user-facing errors in various cases after this?

I'm not sure but it seems that on the changed lines you replaced space indentation with tabs.

As of stable/14 this no longer compiles for me due to

/usr/src/lib/libcmb/cmb.c:854:6: error: invalid argument type 'void' to unary expression
        if (!BN_zero(count))
            ^~~~~~~~~~~~~~~
/usr/src/lib/libcmb/cmb.c:1032:7: error: invalid argument type 'void' to unary expression
                if (!BN_zero(seq))
                    ^~~~~~~~~~~~~
2 errors generated.

1. -D doesn't imply -d anymore. I found that to be unnecessarily limiting, now users can decide on the visual format.
2. The usage output and the manual page are updated.

Add -D both.

Follow advice from Jamie and use -D up and -D down.

Address comments from Jilles.