Page MenuHomeFreeBSD

mhorne063_gmail.com (Mitchell Horne)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 15 2018, 5:18 PM (52 w, 6 d)

Recent Activity

Fri, Jan 18

mhorne063_gmail.com updated the diff for D18851: Optimize RISC-V copyin(9)/copyout(9) routines.

You can add your copyright to this file if you feel so inclined.

Fri, Jan 18, 8:44 PM
mhorne063_gmail.com updated the diff for D18850: Extract common code in copyin/copyout to local routine.

Convert copycommon to a macro.

Fri, Jan 18, 7:39 PM
mhorne063_gmail.com updated the diff for D18851: Optimize RISC-V copyin(9)/copyout(9) routines.

Adjust XLEN constant names and values.

Fri, Jan 18, 7:37 PM

Thu, Jan 17

mhorne063_gmail.com added a comment to D18850: Extract common code in copyin/copyout to local routine.

Elsewhere something similar is done with a macro, but I don't see much of a benefit either way.

Once these changes are in I think we'll want to modify copy{in,instr,out}() to save a copy of the frame pointer. In this case, we'd also have to modify copycommon() to do the same, so the use of a subroutine would be adding an extra pair of stack operations plus the unconditional jump. This makes me slightly inclined towards using a macro, but I'm not sure if anyone else finds it convincing. :)

Thu, Jan 17, 5:30 PM
mhorne063_gmail.com added inline comments to D18851: Optimize RISC-V copyin(9)/copyout(9) routines.
Thu, Jan 17, 4:51 PM

Tue, Jan 15

mhorne063_gmail.com added a child revision for D18850: Extract common code in copyin/copyout to local routine: D18851: Optimize RISC-V copyin(9)/copyout(9) routines.
Tue, Jan 15, 11:45 PM
mhorne063_gmail.com added a parent revision for D18851: Optimize RISC-V copyin(9)/copyout(9) routines: D18850: Extract common code in copyin/copyout to local routine.
Tue, Jan 15, 11:45 PM
mhorne063_gmail.com created D18851: Optimize RISC-V copyin(9)/copyout(9) routines.
Tue, Jan 15, 11:44 PM
mhorne063_gmail.com created D18850: Extract common code in copyin/copyout to local routine.
Tue, Jan 15, 11:42 PM

Mon, Jan 7

mhorne063_gmail.com added inline comments to D14599: Implement kernel code coverage (kcov).
Mon, Jan 7, 5:19 PM

Thu, Jan 3

mhorne063_gmail.com added a comment to D14599: Implement kernel code coverage (kcov).

Thank you for picking this up, I've finally had the chance to look through this whole thing. A couple of small nitpicks but otherwise looks good to me.

Thu, Jan 3, 12:02 AM

Dec 18 2018

mhorne063_gmail.com updated the diff for D18594: Replace uses of sbadaddr with stval.
Dec 18 2018, 5:34 PM
mhorne063_gmail.com updated the diff for D18595: Add definition for cpu_halt().
Dec 18 2018, 5:33 PM
mhorne063_gmail.com added inline comments to D18594: Replace uses of sbadaddr with stval.
Dec 18 2018, 5:31 PM
mhorne063_gmail.com updated the summary of D18595: Add definition for cpu_halt().
Dec 18 2018, 7:55 AM
mhorne063_gmail.com created D18595: Add definition for cpu_halt().
Dec 18 2018, 7:29 AM
mhorne063_gmail.com added inline comments to D18594: Replace uses of sbadaddr with stval.
Dec 18 2018, 7:17 AM
mhorne063_gmail.com updated the summary of D18594: Replace uses of sbadaddr with stval.
Dec 18 2018, 7:15 AM
mhorne063_gmail.com updated the summary of D18594: Replace uses of sbadaddr with stval.
Dec 18 2018, 7:15 AM
mhorne063_gmail.com created D18594: Replace uses of sbadaddr with stval.
Dec 18 2018, 7:12 AM

Nov 26 2018

mhorne063_gmail.com updated the diff for D18321: RISC-V: Add definition for pmap_get_tables().
Nov 26 2018, 4:12 PM

Nov 25 2018

mhorne063_gmail.com updated the diff for D18321: RISC-V: Add definition for pmap_get_tables().
Nov 25 2018, 9:26 PM
mhorne063_gmail.com added inline comments to D18321: RISC-V: Add definition for pmap_get_tables().
Nov 25 2018, 12:43 AM

Nov 24 2018

mhorne063_gmail.com added reviewers for D18321: RISC-V: Add definition for pmap_get_tables(): markj, jhb, br.
Nov 24 2018, 12:36 AM
mhorne063_gmail.com added reviewers for D18320: RISC-V: add minidump support: markj, jhb.
Nov 24 2018, 12:35 AM
mhorne063_gmail.com updated the summary of D18321: RISC-V: Add definition for pmap_get_tables().
Nov 24 2018, 12:34 AM
mhorne063_gmail.com added a child revision for D18321: RISC-V: Add definition for pmap_get_tables(): D18320: RISC-V: add minidump support.
Nov 24 2018, 12:33 AM
mhorne063_gmail.com created D18321: RISC-V: Add definition for pmap_get_tables().
Nov 24 2018, 12:33 AM
mhorne063_gmail.com added a comment to D18320: RISC-V: add minidump support.

Did some of this work before I realized the obvious blocker that we don't have kgdb for RISC-V yet. It dumps successfully but I can't inspect it yet until we have that. Regardless, I figured I'd put this up now to get some initial looks at the changes. I will look into adding the required bits to kgdb to get it working.

Nov 24 2018, 12:31 AM
mhorne063_gmail.com created D18320: RISC-V: add minidump support.
Nov 24 2018, 12:15 AM

Nov 13 2018

mhorne063_gmail.com updated the diff for D17953: RISC-V: Implement get_cyclecount(9).
Nov 13 2018, 3:42 AM
mhorne063_gmail.com updated the diff for D17952: RISC-V: Add macros for reading performance counter CSRs.
Nov 13 2018, 3:39 AM

Nov 12 2018

mhorne063_gmail.com added inline comments to D17952: RISC-V: Add macros for reading performance counter CSRs.
Nov 12 2018, 9:40 PM
mhorne063_gmail.com added inline comments to D17952: RISC-V: Add macros for reading performance counter CSRs.
Nov 12 2018, 6:07 PM

Nov 11 2018

mhorne063_gmail.com updated the summary of D17952: RISC-V: Add macros for reading performance counter CSRs.
Nov 11 2018, 10:35 PM
mhorne063_gmail.com added a comment to D17952: RISC-V: Add macros for reading performance counter CSRs.

Hi @markj @br, hope I can bother you to review a couple RISC-V patches. I know there's not a heavy amount of development here but you two appeared to be the most active committers.

Nov 11 2018, 10:30 PM
mhorne063_gmail.com added a child revision for D17952: RISC-V: Add macros for reading performance counter CSRs: D17953: RISC-V: Implement get_cyclecount(9).
Nov 11 2018, 10:24 PM
mhorne063_gmail.com added a parent revision for D17953: RISC-V: Implement get_cyclecount(9): D17952: RISC-V: Add macros for reading performance counter CSRs.
Nov 11 2018, 10:24 PM
mhorne063_gmail.com created D17953: RISC-V: Implement get_cyclecount(9).
Nov 11 2018, 10:24 PM
mhorne063_gmail.com created D17952: RISC-V: Add macros for reading performance counter CSRs.
Nov 11 2018, 10:21 PM

Oct 26 2018

mhorne063_gmail.com added a comment to D15061: Remove NFSv4 inheritance flags in setfacl recursive mode.

Ahh I see, I misunderstood the purpose of duplicating the ACL. Much better now.

Oct 26 2018, 9:39 PM

Oct 11 2018

mhorne063_gmail.com abandoned D14601: Add interrupts_enabled() to cpufunc.h.
Oct 11 2018, 5:36 AM
mhorne063_gmail.com updated the diff for D15061: Remove NFSv4 inheritance flags in setfacl recursive mode.

Cleaned this up a bit. The logic is the same but should be a bit more obvious now.

Oct 11 2018, 4:44 AM

Apr 27 2018

mhorne063_gmail.com updated the diff for D15061: Remove NFSv4 inheritance flags in setfacl recursive mode.

No code changes, just updated from changes made to D15060

Apr 27 2018, 3:25 PM
mhorne063_gmail.com updated the diff for D15060: Cleanup of setfacl.c.

Address review comments

Apr 27 2018, 2:34 PM

Apr 13 2018

mhorne063_gmail.com added a parent revision for D15061: Remove NFSv4 inheritance flags in setfacl recursive mode: D15060: Cleanup of setfacl.c.
Apr 13 2018, 6:47 PM
mhorne063_gmail.com added a child revision for D15060: Cleanup of setfacl.c: D15061: Remove NFSv4 inheritance flags in setfacl recursive mode.
Apr 13 2018, 6:47 PM
mhorne063_gmail.com created D15061: Remove NFSv4 inheritance flags in setfacl recursive mode.
Apr 13 2018, 6:41 PM
mhorne063_gmail.com created D15060: Cleanup of setfacl.c.
Apr 13 2018, 6:35 PM

Apr 10 2018

mhorne063_gmail.com updated the diff for D14934: Add recursive flags to setfacl(1).

Change to fix last review comments:

  • Use size_t instead of u_int
  • Provide proper path to set_acl_mask()
Apr 10 2018, 9:50 PM

Apr 9 2018

mhorne063_gmail.com added inline comments to D14934: Add recursive flags to setfacl(1).
Apr 9 2018, 8:17 PM
mhorne063_gmail.com updated the diff for D14934: Add recursive flags to setfacl(1).
Apr 9 2018, 8:14 PM

Apr 3 2018

mhorne063_gmail.com updated the diff for D14934: Add recursive flags to setfacl(1).

Fixed issue with reallocation size

Apr 3 2018, 7:01 PM

Apr 2 2018

mhorne063_gmail.com added inline comments to D14934: Add recursive flags to setfacl(1).
Apr 2 2018, 6:56 PM
mhorne063_gmail.com added a comment to D14934: Add recursive flags to setfacl(1).

fts_open() requires an array of strings as an argument, so I had to modify the way input is handled from stdin. It now adds the filename inputs to an array which reallocs when necessary -- an approach that doesn't seem particularly elegant to me, but I thought was preferable to calling fts_open() on each input file individually. If anyone wants to weigh in on this choice I'd gladly hear it.

Apr 2 2018, 4:56 PM
mhorne063_gmail.com created D14934: Add recursive flags to setfacl(1).
Apr 2 2018, 4:27 PM

Mar 26 2018

mhorne063_gmail.com updated the diff for D14601: Add interrupts_enabled() to cpufunc.h.

Moved function from machine/cpufunc.h to machine/cpu.h

Mar 26 2018, 7:11 PM

Mar 22 2018

mhorne063_gmail.com added a comment to D14601: Add interrupts_enabled() to cpufunc.h.

@kib Yes, you are correct about the purpose of this function. This particular technique came from the brief discussion about it between yourself and @emaste, however, the (perhaps naive) assumption that it would apply equally to all architectures was mine. The coverage function also checks td->intr_nesting_level which I presume is a more MI way of avoiding some of the code in unwanted contexts, but is less effective (on x86) than checking this interrupts_enabled() function.

Mar 22 2018, 5:01 PM

Mar 21 2018

mhorne063_gmail.com updated the diff for D14599: Implement kernel code coverage (kcov).

Remove kcov_read()
Remove KIONREAD ioctl and move that data to the first entry of the coverage buffer

Mar 21 2018, 8:20 PM
mhorne063_gmail.com updated the diff for D14601: Add interrupts_enabled() to cpufunc.h.
Mar 21 2018, 8:08 PM

Mar 15 2018

mhorne063_gmail.com added a comment to D14599: Implement kernel code coverage (kcov).

Test cases would be a good idea, certainly it is something I can add. That being said this interface is still experimental so I may make that a separate patch.

Mar 15 2018, 8:23 PM

Mar 14 2018

mhorne063_gmail.com updated the diff for D14599: Implement kernel code coverage (kcov).
  • Changed the stored PC type back to uintptr_t
Mar 14 2018, 9:39 PM

Mar 8 2018

mhorne063_gmail.com added a comment to D14599: Implement kernel code coverage (kcov).

The interfaces are similar but not identical - for example I chose to expose the number of buffer items as an ioctl rather than at the beginning of the buffer as they do in the Linux patch. Conveniently, it is not required that they match exactly as syzkaller has specific executor code per OS which we can adjust to fit this one.

Mar 8 2018, 5:51 PM

Mar 6 2018

mhorne063_gmail.com added a parent revision for D14599: Implement kernel code coverage (kcov): D14601: Add interrupts_enabled() to cpufunc.h.
Mar 6 2018, 9:01 PM
mhorne063_gmail.com added a child revision for D14601: Add interrupts_enabled() to cpufunc.h: D14599: Implement kernel code coverage (kcov).
Mar 6 2018, 9:01 PM
mhorne063_gmail.com created D14601: Add interrupts_enabled() to cpufunc.h.
Mar 6 2018, 9:00 PM
mhorne063_gmail.com created D14599: Implement kernel code coverage (kcov).
Mar 6 2018, 8:37 PM

Feb 8 2018

mhorne063_gmail.com added a reviewer for D14214: Add descriptions to undocumented sysctls (vfs): brd.
Feb 8 2018, 9:27 PM
mhorne063_gmail.com added a reviewer for D14259: Add descriptions to undocumented sysctls (debug): brd.
Feb 8 2018, 9:27 PM
mhorne063_gmail.com added a reviewer for D14258: Add descriptions to undocumented sysctls (dev): brd.
Feb 8 2018, 9:26 PM
mhorne063_gmail.com added a reviewer for D14229: Add descriptions to undocumented sysctls (machdep): brd.
Feb 8 2018, 9:26 PM
mhorne063_gmail.com added a reviewer for D14213: Add descriptions to undocumented sysctls (net): brd.
Feb 8 2018, 9:26 PM
mhorne063_gmail.com added a reviewer for D14212: Add descriptions to undocumented sysctls (hw, kern, vm): brd.
Feb 8 2018, 9:25 PM
mhorne063_gmail.com added inline comments to D14258: Add descriptions to undocumented sysctls (dev).
Feb 8 2018, 2:47 PM

Feb 7 2018

mhorne063_gmail.com created D14259: Add descriptions to undocumented sysctls (debug).
Feb 7 2018, 10:48 PM
mhorne063_gmail.com created D14258: Add descriptions to undocumented sysctls (dev).
Feb 7 2018, 10:45 PM

Feb 6 2018

mhorne063_gmail.com created D14229: Add descriptions to undocumented sysctls (machdep).
Feb 6 2018, 8:12 PM
mhorne063_gmail.com updated the summary of D14214: Add descriptions to undocumented sysctls (vfs).
Feb 6 2018, 7:40 PM
mhorne063_gmail.com updated the diff for D14214: Add descriptions to undocumented sysctls (vfs).

Updated some descriptions to match desired style.

Feb 6 2018, 7:32 PM
mhorne063_gmail.com added inline comments to D14212: Add descriptions to undocumented sysctls (hw, kern, vm).
Feb 6 2018, 7:09 PM
mhorne063_gmail.com updated the diff for D14212: Add descriptions to undocumented sysctls (hw, kern, vm).

Updated some descriptions to match the desired style

Feb 6 2018, 7:05 PM
mhorne063_gmail.com added a reviewer for D14213: Add descriptions to undocumented sysctls (net): rwatson.
Feb 6 2018, 6:49 PM
mhorne063_gmail.com added inline comments to D14213: Add descriptions to undocumented sysctls (net).
Feb 6 2018, 6:43 PM
mhorne063_gmail.com updated the diff for D14213: Add descriptions to undocumented sysctls (net).

Updated some of the descriptions to match the desired style.

Feb 6 2018, 6:39 PM

Feb 5 2018

mhorne063_gmail.com created D14214: Add descriptions to undocumented sysctls (vfs).
Feb 5 2018, 9:34 PM
mhorne063_gmail.com created D14213: Add descriptions to undocumented sysctls (net).
Feb 5 2018, 9:32 PM
mhorne063_gmail.com created D14212: Add descriptions to undocumented sysctls (hw, kern, vm).
Feb 5 2018, 9:29 PM

Jan 18 2018

mhorne063_gmail.com updated the diff for D13971: Enable PTI by default for Intel.

Move pti_get_default() to identcpu.c
Changed to enable for all except AMD

Jan 18 2018, 6:35 PM
mhorne063_gmail.com created D13971: Enable PTI by default for Intel.
Jan 18 2018, 4:43 PM

Jan 17 2018

mhorne063_gmail.com updated the summary of D13957: kldxref: change ef_get_offset() return to Elf_Off.
Jan 17 2018, 8:14 PM
mhorne063_gmail.com created D13957: kldxref: change ef_get_offset() return to Elf_Off.
Jan 17 2018, 8:10 PM
mhorne063_gmail.com updated the diff for D13943: Cleanup kldxref sources.

Changed pointer justification in the struct at the beginning of ef.c

Jan 17 2018, 7:50 PM
mhorne063_gmail.com updated the diff for D13943: Cleanup kldxref sources.

Use explicit conditions (error != 0).
Remove the change to ef_get_offset() return type for another patch.

Jan 17 2018, 5:59 PM

Jan 16 2018

mhorne063_gmail.com added inline comments to D13943: Cleanup kldxref sources.
Jan 16 2018, 10:47 PM
mhorne063_gmail.com created D13943: Cleanup kldxref sources.
Jan 16 2018, 10:36 PM
mhorne063_gmail.com added a comment to D13923: Fix kldxref failing for modules with a short mc_cval.

A lot of these comments address issues/inconsistencies already present in the source. I will create a subsequent cleanup patch to address these but follow what is there at the moment for this patch, since @emaste wants this merged to fix the lld build process.

Jan 16 2018, 4:48 PM
mhorne063_gmail.com updated the diff for D13923: Fix kldxref failing for modules with a short mc_cval.
Jan 16 2018, 4:48 PM
mhorne063_gmail.com updated the diff for D13923: Fix kldxref failing for modules with a short mc_cval.
Jan 16 2018, 3:21 PM
mhorne063_gmail.com added inline comments to D13923: Fix kldxref failing for modules with a short mc_cval.
Jan 16 2018, 3:19 PM

Jan 15 2018

mhorne063_gmail.com updated the diff for D13923: Fix kldxref failing for modules with a short mc_cval.

Upload diff correctly with tabs and full context

Jan 15 2018, 7:56 PM