Page MenuHomeFreeBSD
Differential D19272

Add missing types to sysctl(9) man page
ClosedPublic
Actions

Authored by 0mp on Feb 20 2019, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 12 2025, 7:14 AM
Unknown Object (File)
Dec 26 2024, 1:10 AM
Unknown Object (File)
Dec 16 2024, 12:18 AM
Unknown Object (File)
Dec 8 2024, 5:22 PM
Unknown Object (File)
Nov 19 2024, 2:10 AM
Unknown Object (File)
Nov 19 2024, 12:58 AM
Unknown Object (File)
Nov 18 2024, 11:30 PM
Unknown Object (File)
Nov 18 2024, 11:22 PM
View All 85 Files
Subscribers
bcr

Details

Reviewers
• hselasky
imp
glebius
bcr
mhorne063_gmail.com
Group Reviewers
manpages
Commits
rS344518: Add missing types to the sysctl(9) manual page
Summary

Several new sysctl types have been added in recent years that are not
mentioned in the main sysctl(9) man page. Update it to include these new
types among the macros/function prototypes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne063_gmail.com created this revision.Feb 20 2019, 8:46 PM
mhorne063_gmail.com updated this revision to Diff 54194.Feb 21 2019, 7:19 PM
mhorne063_gmail.com retitled this revision from Mention boolean type sysctls in sysctl(9) man page to Add missing types to sysctl(9) man page.
mhorne063_gmail.com edited the summary of this revision. (Show Details)
mhorne063_gmail.com added reviewers: imp, glebius.

Update the diff to include other missing sysctl types found in sysctl.h.

Some of these sysctls are already documented in other pages (e.g counter(9)
and ZONE(9)), but they should at least be mentioned here for completeness.

This patch now documents all of the following:
SYSCTL_BOOL/SYSCTL_ADD_BOOL
SYSCTL_COUNTER_U64/SYSCTL_ADD_COUNTER_U64
SYSCTL_COUNTER_U64_ARRAY/SYSCTL_ADD_COUNTER_U64_ARRAY
SYSCTL_SBINTIME_MSEC/SYSCTL_ADD_SBINTIME_MSEC
SYSCTL_SBINTIME_USEC/SYSCTL_ADD_SBINTIME_USEC
SYSCTL_UMA_CUR/SYSCTL_ADD_UMA_CUR
SYSCTL_UMA_MAX/SYSCTL_ADD_UMA_MAX

bcr accepted this revision.Feb 21 2019, 8:32 PM
bcr added a subscriber: bcr.

OK from manpages. Can't say much about the content itself, but syntax looks good.

This revision is now accepted and ready to land.Feb 21 2019, 8:32 PM
mhorne063_gmail.com added inline comments.Feb 21 2019, 8:45 PM
share/man/man9/sysctl.9
61 ↗(On Diff #54194)

I've elected to break the alphabetical order here to differentiate 'UMA' prefix from the unsigned 'U' prefix. If this is undesirable let me know and I can change it back.

• hselasky accepted this revision.Feb 22 2019, 9:26 AM

Looks good to me.

mhorne063_gmail.com added a comment.Feb 24 2019, 8:34 PM

Great. If there's no objections can I bug one of you to commit this?

0mp commandeered this revision.Feb 25 2019, 2:53 PM
0mp added a reviewer: mhorne063_gmail.com.
Closed by commit rS344518: Add missing types to the sysctl(9) manual page (authored by 0mp). · Explain WhyFeb 25 2019, 3:03 PM
This revision was automatically updated to reflect the committed changes.
0mp added a comment.Feb 25 2019, 3:04 PM
In D19272#413695, @mhorne063_gmail.com wrote:

Great. If there's no objections can I bug one of you to commit this?

Done! Nice work!

Revision Contents
Changeset List

PathSize
head/
share/
man/
man9/
119 lines

Diff 54358

View Options

head/share/man/man9/sysctl.9

Loading...