Page MenuHomeFreeBSD

Replace uses of sbadaddr with stval
ClosedPublic

Authored by mhorne063_gmail.com on Dec 18 2018, 7:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 3:49 AM
Unknown Object (File)
Thu, Sep 5, 3:13 PM
Unknown Object (File)
Mon, Sep 2, 7:28 PM
Unknown Object (File)
Mon, Sep 2, 3:15 AM
Unknown Object (File)
Tue, Aug 27, 10:02 PM
Unknown Object (File)
Sat, Aug 17, 4:54 PM
Unknown Object (File)
Aug 7 2024, 4:07 PM
Unknown Object (File)
Aug 3 2024, 9:18 PM
Subscribers

Details

Summary

As of privilege spec v1.10, sbadaddr has been subsumed by stval. Replace usages
of sbadaddr and rename the member of struct trapframe to reflect this.

The compiler would already substitute stval for sbadaddr, so there should be no actual
impact to the exception handler.

Test Plan

Built kernel and booted successfully in qemu.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne063_gmail.com edited the summary of this revision. (Show Details)
sys/riscv/riscv/trap.c
327 ↗(On Diff #52137)

Not sure this is the right phrasing. Maybe just "address"?

markj added inline comments.
sys/riscv/riscv/trap.c
327 ↗(On Diff #52137)

I think what's there is fine, or maybe "trap value". We don't know what stval is supposed to represent if the exception type is not recognized, so "address" seems presumptive to me.

328 ↗(On Diff #52137)

Fix indentation while here?

396 ↗(On Diff #52137)

Ditto.

This revision is now accepted and ready to land.Dec 18 2018, 5:11 PM
sys/riscv/riscv/trap.c
327 ↗(On Diff #52137)

Fair point. Trap value is probably the most straightforward then.

This revision now requires review to proceed.Dec 18 2018, 5:34 PM
This revision is now accepted and ready to land.Dec 18 2018, 5:44 PM
This revision was automatically updated to reflect the committed changes.