Page MenuHomeFreeBSD
Differential D18595

Add definition for cpu_halt()
ClosedPublic
Actions

Authored by mhorne063_gmail.com on Dec 18 2018, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 15, 1:33 AM
Unknown Object (File)
Wed, Oct 14, 11:11 PM
Unknown Object (File)
Wed, Oct 14, 6:51 PM
Unknown Object (File)
Wed, Oct 14, 4:23 PM
Unknown Object (File)
Mon, Oct 12, 2:18 PM
Unknown Object (File)
Sat, Oct 10, 9:38 PM
Unknown Object (File)
Sat, Oct 10, 4:12 PM
Unknown Object (File)
Tue, Oct 6, 3:00 AM
View All Files
Subscribers
br
imp
jhb

Details

Reviewers
markj
Commits
rS342221: Implement cpu_halt() for RISC-V.
Summary

Add the missing definition cpu_halt() on RISC-V.

Test Plan

Tested using the halt command from ddb.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne063_gmail.com created this revision.Dec 18 2018, 7:29 AM
mhorne063_gmail.com edited the summary of this revision. (Show Details)Dec 18 2018, 7:55 AM
mhorne063_gmail.com edited the test plan for this revision. (Show Details)
markj added inline comments.Dec 18 2018, 5:06 PM
sys/riscv/riscv/machdep.c
430 ↗(On Diff #52138)

Per style(9) this should be:

for (;;)
        __asm __volatile("wfi");
mhorne063_gmail.com updated this revision to Diff 52145.Dec 18 2018, 5:33 PM
mhorne063_gmail.com marked an inline comment as done.
markj accepted this revision.Dec 18 2018, 5:43 PM
This revision is now accepted and ready to land.Dec 18 2018, 5:43 PM
Closed by commit rS342221: Implement cpu_halt() for RISC-V. (authored by markj). · Explain WhyDec 19 2018, 5:45 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptDec 19 2018, 5:45 PM

Revision Contents
Changeset List

PathSize
head/
sys/
riscv/
riscv/
4 lines

Diff 52169

View Options

head/sys/riscv/riscv/machdep.c

Loading...