User Details
- User Since
- Sep 26 2014, 6:46 AM (540 w, 3 d)
May 14 2021
Dec 18 2020
Nice! Seems it may solve the problem like we have in dwmmc where some generic methods get overridden with device-specific actions.
Nov 4 2020
Nov 3 2020
- Address reviewer comments
Oct 30 2020
Add actual content here.
Oct 24 2020
Sep 1 2020
At the first glance I don't see anything weird wrt MMCCAM intergration; I agree that MMCCAM-related problems should be fixed in the follow-up commits and not here.
Regarding the partitions: it would be interesting to see the output of ls /dev/sdda* on MMCCAM kernel, probably the partitions got detected but not printed on boot.
Aug 4 2020
- Remove excessive printf
Jul 28 2020
The support for this has been merged in -HEAD through other commits.
Some last bits are coming in https://reviews.freebsd.org/D25843.
Jul 24 2020
Nov 28 2019
Updated to output an error message if various allocation functions failed. Also, revert to using alloc_ccb() from alloc_ccb_nowait() since it's pretty fine to wait in the contexts where start_discovery() is executed.
Nov 26 2019
Nov 1 2019
Oct 30 2019
May 28 2019
LGTM with a couple of tiny comments. Thanks!
Apr 10 2019
Addressed reviewer's comment about magic constant, added more comments.
- Move new fields to the end
Apr 7 2019
Updated to use MMC_DATA_BLOCK_SIZE.
- Implement CMD53 block mode support for SDHCI and AllWinner-based boards
- Use the new MMC_DATA_BLOCK_SIZE
- Put blank before colon when printing command args
Try again
Reupload the change.
Apr 5 2019
Updated; please take a look.
Killed CMD53-related changes, leaving only field changes.
Addressed comments
Apr 1 2019
Added (hopefully) missing files.
Generally LGTM with a few nits.
Mar 22 2019
- Use SDHCI_MAKE_BLKSZ() for calculating block size
- Initialize new fields of mmc_data properly
- Make block mode work
Mar 21 2019
Mar 20 2019
Address comments from bz@
Mar 19 2019
addressed reviewer comments
Sync Arcanist
- locking fix for D15955