Page MenuHomeFreeBSD
People jlduran

jlduran (Jose Luis Duran)
User

Projects

User Details

User Since
May 30 2017, 11:42 AM (440 w, 4 d)

Recent Activity
View All

Thu, Nov 6

jlduran resigned from D53605: lib/libbl[ao]cklist: Use LIB_PACKAGE.
In D53605#1223887, @ivy wrote:
In D53605#1223886, @jlduran wrote:

Perhaps the discussion can be if we want to make WITHOUT_BLOCKLIST the default? That would be understandable, since it has a low usage rate, I would approve that.

i would definitely be opposed to that; blocklistd is useful functionality and requiring people to rebuild the system from source to use it would be user-hostile. that's the opposite of what we're trying to achieve with pkgbase, which is that it should not be necessary to rebuild the system from source to add/remove optional components.

Thu, Nov 6, 4:41 PM
jlduran added a comment to D53605: lib/libbl[ao]cklist: Use LIB_PACKAGE.
In D53605#1223872, @ivy wrote:
In D53605#1223871, @jlduran wrote:

Just to make sure I'm on the same page, because to me having FreeBSD-blocklist-lib and FreeBSD-blocklist would be like having FreeBSD-ssh and FreeBSD-ssh-lib.

nothing links against the libraries in the ssh package (or at least i haven't found anything that does yet, while auditing this) so having a separate ssh-lib package would not be useful. the use-case here is someone wants to run sshd, or use the ssh client, but they don't use/want blocklistd - so why do they need to install the blocklistd daemon, the rc.d script, etc? having a blocklist-lib package means ssh can depend on blocklist-lib instead of blocklist[0], and only users who actually want to run blocklistd need to install the blocklist package.

[0] note that pkg adds this dependency automatically

I do not see a working FreeBSD-ssh package without FreeBSD-blocklist

sshd works fine without blocklistd running, doesn't it? i don't run blocklistd on any of my systems, since i don't accept ssh connections from the Internet. as long as libblocklist is present, sshd will work fine, and just silently fail to report failures to blocklistd, just like it would if blocklistd was installed but not running.

On the other hand, if we decide to split, where should we stop? Should FreeBSD-blocklist be split into FreeBSD-blocklist-client and FreeBSD-blocklist-daemon?

that would not be useful as it doesn't make sense to install blocklistd without the client utility to manage it. or IOW, everyone who wants "blocklist-daemon" would also want "blocklist-client".

Thu, Nov 6, 3:12 AM
jlduran added a comment to D53605: lib/libbl[ao]cklist: Use LIB_PACKAGE.

Just to make sure I'm on the same page, because to me having FreeBSD-blocklist-lib and FreeBSD-blocklist would be like having FreeBSD-ssh and FreeBSD-ssh-lib.
I do not see a working FreeBSD-ssh package without FreeBSD-blocklist, that is, I was going to ask you if we should add a deps block to ssh.ucl?
On the other hand, if we decide to split, where should we stop? Should FreeBSD-blocklist be split into FreeBSD-blocklist-client and FreeBSD-blocklist-daemon?
At this point I'm not opposed nor in favor, I just need to gather more information. Thank you for taking a look at this issue.

Thu, Nov 6, 2:26 AM

Wed, Nov 5

jlduran committed rGb781ee1e0b85: blacklist: Update the blacklistd-helper script (authored by jlduran).
blacklist: Update the blacklistd-helper script
Wed, Nov 5, 3:22 PM
jlduran committed rG6985b90cd0fc: blocklist: Update the blacklistd-helper script (authored by jlduran).
blocklist: Update the blacklistd-helper script
Wed, Nov 5, 3:21 PM

Sun, Nov 2

jlduran added a reviewer for D53239: nuageinit: Add guards against empty user data: markj.
Sun, Nov 2, 5:56 PM

Thu, Oct 30

jlduran added a reverting change for rG2347ca21d657: blocklist-helper: Silence a bogus pf warning: rGb7780e24533b: Revert "blocklist-helper: Silence a bogus pf warning".
Thu, Oct 30, 1:53 AM
jlduran committed rGb7780e24533b: Revert "blocklist-helper: Silence a bogus pf warning" (authored by jlduran).
Revert "blocklist-helper: Silence a bogus pf warning"
Thu, Oct 30, 1:53 AM
jlduran committed rG355ef0c36471: pfctl: Do not warn if there is no Ethernet anchor (authored by jlduran).
pfctl: Do not warn if there is no Ethernet anchor
Thu, Oct 30, 1:53 AM
jlduran committed rG1c8a554f757d: libpfctl: Fix displaying deeply nested anchors (authored by jlduran).
libpfctl: Fix displaying deeply nested anchors
Thu, Oct 30, 1:53 AM
jlduran committed rG7af5c1da2887: blocklist: Fix rcorder(8) (authored by jlduran).
blocklist: Fix rcorder(8)
Thu, Oct 30, 1:53 AM
jlduran committed rG528e1d14037a: blocklist: blacklist: Chase recent upstream changes (authored by jlduran).
blocklist: blacklist: Chase recent upstream changes
Thu, Oct 30, 1:53 AM
jlduran committed rGdfc4a7c10cf5: MFV: Import blocklist 2025-10-26 (ff13526) (authored by jlduran).
MFV: Import blocklist 2025-10-26 (ff13526)
Thu, Oct 30, 1:53 AM
jlduran committed rGcd284c1e17ea: blocklist: blacklist: Chase recent upstream changes (authored by jlduran).
blocklist: blacklist: Chase recent upstream changes
Thu, Oct 30, 1:52 AM
jlduran committed rGcbd8e3a0049a: MFV: Import blocklist 2025-10-25 (156df4f) (authored by jlduran).
MFV: Import blocklist 2025-10-25 (156df4f)
Thu, Oct 30, 1:52 AM

Tue, Oct 28

jlduran added a reverting change for rG2347ca21d657: blocklist-helper: Silence a bogus pf warning: rGe12ec5f4338c: Revert "blocklist-helper: Silence a bogus pf warning".
Tue, Oct 28, 11:54 AM
jlduran committed rGe12ec5f4338c: Revert "blocklist-helper: Silence a bogus pf warning" (authored by jlduran).
Revert "blocklist-helper: Silence a bogus pf warning"
Tue, Oct 28, 11:54 AM
jlduran added a reverting change for rG67ade69eb607: blocklistd-helper: Silence another bogus pf warning: rG6f0942bde7a0: Revert "blocklistd-helper: Silence another bogus pf warning".
Tue, Oct 28, 11:54 AM
jlduran committed rG6f0942bde7a0: Revert "blocklistd-helper: Silence another bogus pf warning" (authored by jlduran).
Revert "blocklistd-helper: Silence another bogus pf warning"
Tue, Oct 28, 11:54 AM
jlduran committed rG99560fe98c76: pfctl: Do not warn if there is no Ethernet anchor (authored by jlduran).
pfctl: Do not warn if there is no Ethernet anchor
Tue, Oct 28, 11:50 AM
jlduran committed rGa943a96a50ba: libpfctl: Fix displaying deeply nested anchors (authored by jlduran).
libpfctl: Fix displaying deeply nested anchors
Tue, Oct 28, 11:50 AM
jlduran closed D53358: libpfctl: Fix displaying deeply nested anchors.
Tue, Oct 28, 11:49 AM
jlduran closed D53360: pfctl: Do not warn if there is no Ethernet anchor.
Tue, Oct 28, 11:49 AM

Mon, Oct 27

jlduran updated the diff for D53358: libpfctl: Fix displaying deeply nested anchors.

Address suggestions:

Mon, Oct 27, 7:58 PM
jlduran retitled D53358: libpfctl: Fix displaying deeply nested anchors from pfctl: Fix displaying multiple nested anchors to libpfctl: Fix displaying deeply nested anchors.
Mon, Oct 27, 7:52 PM
jlduran closed D53364: blocklist: Fix rcorder(8).
Mon, Oct 27, 3:48 PM
jlduran committed rG79e374217d69: blocklist: Fix rcorder(8) (authored by jlduran).
blocklist: Fix rcorder(8)
Mon, Oct 27, 3:48 PM
jlduran added a comment to D53364: blocklist: Fix rcorder(8).
In D53364#1219018, @0mp wrote:

Note: we could perhaps think about adding a FIREWALL script to depend on instead, but for the time being this patch is fine. Thanks!

Mon, Oct 27, 3:44 PM
jlduran committed rGb502a451cbae: blocklist: blacklist: Chase recent upstream changes (authored by jlduran).
blocklist: blacklist: Chase recent upstream changes
Mon, Oct 27, 3:12 PM
jlduran committed rG93263ae5eab6: mtree: Remove stray wi directory (authored by jlduran).
mtree: Remove stray wi directory
Mon, Oct 27, 1:20 PM
jlduran committed rGf9020f19119e: mtree: Remove stray an (Aironet) directory (authored by jlduran).
mtree: Remove stray an (Aironet) directory
Mon, Oct 27, 1:20 PM
jlduran committed rG07889c649749: mtree: Remove stray wi directory (authored by jlduran).
mtree: Remove stray wi directory
Mon, Oct 27, 1:20 PM
jlduran committed rGc24434265c7c: mtree: Remove stray atm directory (authored by jlduran).
mtree: Remove stray atm directory
Mon, Oct 27, 1:20 PM
jlduran committed rGc75fa84200d2: bsdinstall: jail: Fix DISTMENU items (authored by jlduran).
bsdinstall: jail: Fix DISTMENU items
Mon, Oct 27, 1:20 PM
jlduran committed rG3281756a24e2: mtree: Remove stray an (Aironet) directory (authored by jlduran).
mtree: Remove stray an (Aironet) directory
Mon, Oct 27, 1:20 PM
jlduran committed rG0b45751456aa: mtree: Remove stray wi directory (authored by jlduran).
mtree: Remove stray wi directory
Mon, Oct 27, 1:20 PM
jlduran committed rG002ce2c9d081: mtree: Remove stray atm directory (authored by jlduran).
mtree: Remove stray atm directory
Mon, Oct 27, 1:19 PM
jlduran committed rG34ffc7073f17: MFV: Import blocklist 2025-10-26 (ff13526) (authored by jlduran).
MFV: Import blocklist 2025-10-26 (ff13526)
Mon, Oct 27, 1:00 PM
jlduran committed rGdf549a804256: Vendor import of blocklist 2025-10-26 (ff13526) (authored by jlduran).
Vendor import of blocklist 2025-10-26 (ff13526)
Mon, Oct 27, 12:46 PM

Sun, Oct 26

jlduran requested review of D53364: blocklist: Fix rcorder(8).
Sun, Oct 26, 4:30 PM
jlduran added a comment to D53360: pfctl: Do not warn if there is no Ethernet anchor.

This is the simplest fix I can think of to fix PR 280516.
Feel free to commandeer, this or the parent revision. My main objective is to ship blocklist without defects or misleading warnings.

Sun, Oct 26, 12:59 PM
jlduran requested review of D53360: pfctl: Do not warn if there is no Ethernet anchor.
Sun, Oct 26, 12:54 PM
jlduran updated the diff for D53358: libpfctl: Fix displaying deeply nested anchors.

Ignore stderr for now, it throws a bogus warning about an (ethernet) anchor not found (PR 280516).

Sun, Oct 26, 4:10 AM
jlduran updated the diff for D53358: libpfctl: Fix displaying deeply nested anchors.

Remove patch file for bugzila.

Sun, Oct 26, 2:36 AM
jlduran requested review of D53358: libpfctl: Fix displaying deeply nested anchors.
Sun, Oct 26, 2:30 AM

Sat, Oct 25

jlduran committed rG67ade69eb607: blocklistd-helper: Silence another bogus pf warning (authored by jlduran).
blocklistd-helper: Silence another bogus pf warning
Sat, Oct 25, 11:26 PM
jlduran committed rGeae98e28a0e1: blocklist: blacklist: Chase recent upstream changes (authored by jlduran).
blocklist: blacklist: Chase recent upstream changes
Sat, Oct 25, 9:57 PM
jlduran committed rGbcbe0a3c924e: MFV: Import blocklist 2025-10-25 (156df4f) (authored by jlduran).
MFV: Import blocklist 2025-10-25 (156df4f)
Sat, Oct 25, 9:20 PM
jlduran committed rG1ae0b2f3a242: Vendor import of blocklist 2025-10-25 (156df4f) (authored by jlduran).
Vendor import of blocklist 2025-10-25 (156df4f)
Sat, Oct 25, 8:41 PM

Fri, Oct 24

jlduran closed D53266: security/openssh-portable: Remove blocklist probe.
Fri, Oct 24, 2:24 PM
jlduran committed R11:7c9b7e8add8c: security/openssh-portable: Remove blocklist probe (authored by jlduran).
security/openssh-portable: Remove blocklist probe
Fri, Oct 24, 2:24 PM

Thu, Oct 23

jlduran added a comment to D53273: security/openssh-portable: Update line numbers.
In D53273#1216946, @bdrewery wrote:

Do you have a single patch I can test? Or a poudriere bulk secrurity/openssh-portable@all successful build?

Thu, Oct 23, 4:28 AM

Wed, Oct 22

jlduran committed rGf7ccf051016f: mtree: Remove stray an (Aironet) directory (authored by jlduran).
mtree: Remove stray an (Aironet) directory
Wed, Oct 22, 10:43 PM
jlduran committed rGf942a7465469: mtree: Remove stray wi directory (authored by jlduran).
mtree: Remove stray wi directory
Wed, Oct 22, 10:43 PM
jlduran closed D53265: mtree: Remove stray an (Aironet) directory.
Wed, Oct 22, 10:43 PM
jlduran closed D53264: mtree: Remove stray wi directory.
Wed, Oct 22, 10:43 PM
jlduran added a comment to D53273: security/openssh-portable: Update line numbers.
In D53273#1216946, @bdrewery wrote:

Do you have a single patch I can test? Or a poudriere bulk secrurity/openssh-portable@all successful build?

Wed, Oct 22, 10:39 PM
jlduran requested review of D53273: security/openssh-portable: Update line numbers.
Wed, Oct 22, 10:34 PM
jlduran requested review of D53272: security/openssh-portable: Sync sshd_config patches.
Wed, Oct 22, 10:34 PM
jlduran requested review of D53271: security/openssh-portable: Sync ssh_config.5 manual.
Wed, Oct 22, 10:33 PM
jlduran requested review of D53270: security/openssh-portable: Sync sshd.c patches.
Wed, Oct 22, 10:33 PM
jlduran requested review of D53269: security/openssh-portable: Update session.c patch.
Wed, Oct 22, 10:33 PM
jlduran requested review of D53268: security/openssh-portable: X11Forwarding off by default.
Wed, Oct 22, 10:32 PM
jlduran requested review of D53267: security/openssh-portable: Update servconf.c patch.
Wed, Oct 22, 10:32 PM
jlduran requested review of D53266: security/openssh-portable: Remove blocklist probe.
Wed, Oct 22, 10:32 PM
jlduran added a reviewer for D53264: mtree: Remove stray wi directory: imp.
Wed, Oct 22, 10:15 PM
jlduran requested review of D53265: mtree: Remove stray an (Aironet) directory.
Wed, Oct 22, 9:19 PM
jlduran requested review of D53264: mtree: Remove stray wi directory.
Wed, Oct 22, 9:19 PM
jlduran added a reviewer for D53171: bsdinstall: Harden reading the kernel message buffer: security.
Wed, Oct 22, 7:30 PM
jlduran added a comment to D53177: bsdinstall: jail: Fix DISTMENU items.
In D53177#1216754, @jamie wrote:

It only touches peripherally on jails, but sure, looks good. One could ask why we decided to have a separate and subtlely different "dist" and "distname" but I suppose that's water long since under the bridge.

Wed, Oct 22, 6:24 PM
jlduran committed rG74921426d552: bsdinstall: jail: Fix DISTMENU items (authored by jlduran).
bsdinstall: jail: Fix DISTMENU items
Wed, Oct 22, 6:24 PM
jlduran closed D53177: bsdinstall: jail: Fix DISTMENU items.
Wed, Oct 22, 6:23 PM
jlduran committed rG8e8ee8bbe2a1: mtree: Remove stray atm directory (authored by jlduran).
mtree: Remove stray atm directory
Wed, Oct 22, 5:49 PM
jlduran closed D53260: mtree: Remove stray atm directory.
Wed, Oct 22, 5:48 PM
jlduran updated subscribers of D53260: mtree: Remove stray atm directory.
In D53260#1216709, @emaste wrote:

Ought to list Fixes: af0cc0b22362 I think

Wed, Oct 22, 5:33 PM
jlduran added a comment to D53260: mtree: Remove stray atm directory.
In D53260#1216709, @emaste wrote:

Ought to list Fixes: af0cc0b22362 I think

Wed, Oct 22, 4:55 PM
jlduran requested review of D53260: mtree: Remove stray atm directory.
Wed, Oct 22, 3:38 PM
jlduran added a reviewer for D53177: bsdinstall: jail: Fix DISTMENU items: Jails.
Wed, Oct 22, 3:23 PM

Tue, Oct 21

jlduran updated the diff for D53239: nuageinit: Add guards against empty user data.
  • The first line of the user data file cannot be empty
Tue, Oct 21, 9:38 PM
jlduran added inline comments to D53239: nuageinit: Add guards against empty user data.
Tue, Oct 21, 9:36 PM
jlduran updated the diff for D53239: nuageinit: Add guards against empty user data.

These are the current checks:

Tue, Oct 21, 4:30 PM
jlduran planned changes to D53239: nuageinit: Add guards against empty user data.
Tue, Oct 21, 4:10 PM
jlduran updated the diff for D53239: nuageinit: Add guards against empty user data.

At this point I'm lost against the file specifications:

Tue, Oct 21, 4:05 PM
jlduran updated the diff for D53239: nuageinit: Add guards against empty user data.
  • Guard earlier against line being empty
  • Guard against content being empty
Tue, Oct 21, 3:40 PM
jlduran retitled D53239: nuageinit: Add guards against empty user data from nuageinit: Add a guard against empty user data to nuageinit: Add guards against empty user data.
Tue, Oct 21, 3:38 PM
jlduran added inline comments to D53238: nuageinit: Silence luacheck warnings and fix typos.
Tue, Oct 21, 2:22 PM
jlduran added inline comments to D53239: nuageinit: Add guards against empty user data.
Tue, Oct 21, 2:15 PM
jlduran updated the diff for D53238: nuageinit: Silence luacheck warnings and fix typos.
  • Fix typos
Tue, Oct 21, 1:39 PM
jlduran retitled D53238: nuageinit: Silence luacheck warnings and fix typos from nuageinit: Silence luacheck warnings to nuageinit: Silence luacheck warnings and fix typos.
Tue, Oct 21, 1:39 PM
jlduran requested review of D53239: nuageinit: Add guards against empty user data.
Tue, Oct 21, 1:32 PM
jlduran requested review of D53238: nuageinit: Silence luacheck warnings and fix typos.
Tue, Oct 21, 1:32 PM

Mon, Oct 20

jlduran committed rG549cba3c9d1e: rc: dmesg: Allow umask to be configurable (authored by jlduran).
rc: dmesg: Allow umask to be configurable
Mon, Oct 20, 4:11 PM
jlduran committed rG2779d6310121: rc.conf: Fix typo interferring -> interfering (authored by jlduran).
rc.conf: Fix typo interferring -> interfering
Mon, Oct 20, 4:11 PM
jlduran committed rG829e479a0a37: bsdinstall: Fix typos (authored by jlduran).
bsdinstall: Fix typos
Mon, Oct 20, 4:10 PM
jlduran committed rGd8ddea0d4b0a: rc: dmesg: Allow umask to be configurable (authored by jlduran).
rc: dmesg: Allow umask to be configurable
Mon, Oct 20, 4:10 PM
jlduran committed rG907cb4ac5fea: rc.conf: Fix typo interferring -> interfering (authored by jlduran).
rc.conf: Fix typo interferring -> interfering
Mon, Oct 20, 4:10 PM
jlduran committed rGf28a5c92f9cd: bsdinstall: Fix typos (authored by jlduran).
bsdinstall: Fix typos
Mon, Oct 20, 4:09 PM
jlduran committed rGfa2e886206f4: rc: dmesg: Allow umask to be configurable (authored by jlduran).
rc: dmesg: Allow umask to be configurable
Mon, Oct 20, 4:09 PM
jlduran committed rG59c0a987e0d3: rc.conf: Fix typo interferring -> interfering (authored by jlduran).
rc.conf: Fix typo interferring -> interfering
Mon, Oct 20, 4:09 PM

Sat, Oct 18

jlduran committed rG4ee348e27143: bsdinstall: Fix typos (authored by jlduran).
bsdinstall: Fix typos
Sat, Oct 18, 5:15 PM