Note that I would have "accepted" the previous version if it wasn't for Eugene's remark. I can try adding a simple test that checks it is warning and not erroring when parsing a configuration file if you believe it is necessary.
Regarding the missing EOLs in the dprintf()s, I see those are no longer present, evidently the message needs updating upon commit.

• Rebase

• Implement a strsuftoll(3)-compatible function, as the value of NANO_SLICE_FAT_SIZE should be compatible with makefs(8) -s.

• Add more occurrences

• Update the comment to indicate that we also remove the time keyword

I've seen that when using ATF, ${PWD} is preferred over $(pwd) (efficiency, I guess).

Very nice!

Thank you!

I think this is not sufficient (just to avoid a missing mac.conf entry):
I test it thoroughly later, but for now:

# jail -c path=/ name=D54786 persist
# jls -s

Nice! I may steal a few ideas for some other similar tests.
I made a small observation, that can be ignored, I'm just thrilled with my recent discovery of atf_check -r.

After this refactoring, the test syslogd_test:forward becomes very flaky. It should be all fixed in the following revision.

But I also have one more question: one of the warnings is also about unexisting .Xr sysctl 2. As I can see, there is no sysctl(2) in FreeBSD, only sysctl(3). But the man pages talks about it in the context of syscalls, so it seems that we can't just change sysctl(2) to sysctl(3) since sysctl(3) is not a syscall. What sould we do about that?

In D54761#1251514, @tembun_bk.ru wrote:

In D54761#1251476, @jlduran wrote:

If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

Sure. One of the warnings is: STYLE: referenced manual not found: Xr pdwait4 2. As I can see, pdwait(2) syscall is about to be introduced by https://reviews.freebsd.org/D54592 soon. So shall we keep the reference to pdwait4(2) (but change it to pdwait(2))?

Thanks. The "fi" ligature was probably an artifact from copy/pasting from the PDF article.
If possible, try to fix all the mandoc -T lint share/man/man4/capsicum.4 recommendations while here.

I'll just submit the trivial rdr_action_head() fix and abandon the rest.
I'll wait for the test timeouts dust to settle and simply try sleeping a bit more once I gather all the flaky tests.
Thank you for your input!