When/if this patch lands, I think I should also land D34598 (in separate chunks) as well.

Rebase

In D53033#1213779, @emaste wrote:

There are still a few renamed LEGACY sysctls that were removed (and reverted):

Indeed, unfortunately they're not handled by a SYSCTL_PROC and there's not a convenient/trivial way to add a warning.

SYSCTL_UQUAD(_vfs_zfs, OID_AUTO, l2arc_write_max,
        CTLFLAG_RWTUN, &l2arc_write_max, 0,
        "Max write bytes per interval (LEGACY)");

I could add a SYSCTL_UQUAD wrapper that emits a warning but I didn't think it was worth doing. The auto_ashift sysctl was important to warn on for a few reasons:

• Setting it has a persistent effect, because it applies for the lifetime of a newly created vdev.
• The installer set it so it existed on a great number of systems.

In comparison I think the l2arc knobs are tuning parameters that, if legacy names are ignored, may have a performance impact but not a functional or persistent effect.

Thank you!

Ah, I see.
Sorry if I'm getting in the way to pkgbase.

I think stanzas got crossed-over?

Would it be worth addressing these suggestions here as well?:
https://lists.freebsd.org/archives/dev-commits-src-main/2025-October/036657.html

• Track the_active_state, for those probes where the ssh struct passed is NULL (like the one in _auth-pam.c_).

• Rebase with new nomenclature
• Fixup commit message

In D53046#1212029, @imp wrote:

I've not hit the // issue. When does it happen?

Sorry to bother, but I have the following doubt:
There are still a few renamed LEGACY sysctls that were removed (and reverted):

This is what we did for NO_ROOT NanoBSD images.
Beware of double slashes in the METALOG. Though they are not invalid per se, consider the following excerpt:

./base/aaa type=dir
./base//aaa/bbb type=dir

If sorted, it would turn out:

./base//aaa/bbb type=dir
./base/aaa type=dir

Apparently missing the ./base/aaa directory in the specification.

Bump PORTREVISION

In D52869#1210490, @emaste wrote:

What can/should we do to handle the blacklistd.conf -> blocklistd.conf transition?

Thank you!

In D51809#1209605, @jlduran wrote:

In D51809#1184078, @des wrote:

Thank you. We should consider upstreaming this, @emaste.

https://bugzilla.mindrot.org/show_bug.cgi?id=3874

Submitted upstream:

In D51809#1184078, @des wrote:

Thank you. We should consider upstreaming this, @emaste.

Thank you, these two commits fix GitHub's cross-builds on Linux.

• Update the reason for removal

Address sugestions:

This is just the MFV commit.

Closed by 1060684b04b0ee1e07c6c91f7c52978835ff676a

Closed by 307929b211e07f91260105211b57678e906327af

In D49500#1205269, @0mp wrote:

This could be closed in favor of https://reviews.freebsd.org/D49500